unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Mike Hamrick <mikeh@muppetlabs.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] TTY Support for ECMA-48 strike-through graphic rendition
Date: Fri, 26 Jun 2020 13:46:52 +0300	[thread overview]
Message-ID: <837dvurtnn.fsf@gnu.org> (raw)
In-Reply-To: <m1mu4qg6s4.fsf@eidolon.muppetlabs.com> (message from Mike Hamrick on Thu, 25 Jun 2020 14:44:11 -0700)

> From: Mike Hamrick <mikeh@muppetlabs.com>
> Date: Thu, 25 Jun 2020 14:44:11 -0700
> 
> Here is my patch which adds Emacs TTY support for strike-through
> rendering, which I personally use in org-mode for done TODO items. In
> order for this to work for you, your terminfo database entry needs to have the
> "smxx" capability defined, which I believe more recent versions[0] of the
> xterm entry have.
> 
> [0]: https://invisible-island.net/xterm/terminfo.html

Thanks.  The changes look good to me, but:

 . please add a NEWS item announcing the support for this face
   attribute
 . the changes are large enough to require you to sign a copyright
   assignment for them; if you agree to start your legal paperwork, I
   will send you the form to fill

Thank you for your interest in Emacs.



  reply	other threads:[~2020-06-26 10:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 21:44 [PATCH] TTY Support for ECMA-48 strike-through graphic rendition Mike Hamrick
2020-06-26 10:46 ` Eli Zaretskii [this message]
2020-06-26 19:23   ` Mike Hamrick
2020-06-26 19:38     ` Eli Zaretskii
2020-08-11 19:17     ` Eli Zaretskii
2020-08-12  9:36       ` Robert Pluim
2020-08-12 14:23         ` Eli Zaretskii
2020-08-12 16:19           ` Robert Pluim
2020-08-12 18:12             ` Stefan Monnier
2020-09-13 23:05       ` Mike Hamrick
2020-09-14 22:25       ` Mike Hamrick
2020-09-18  8:55         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837dvurtnn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mikeh@muppetlabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).