From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: mikeh@muppetlabs.com, emacs-devel@gnu.org
Subject: Re: [PATCH] TTY Support for ECMA-48 strike-through graphic rendition
Date: Wed, 12 Aug 2020 17:23:38 +0300 [thread overview]
Message-ID: <83imdondsl.fsf@gnu.org> (raw)
In-Reply-To: <m28seki4te.fsf@gmail.com> (message from Robert Pluim on Wed, 12 Aug 2020 11:36:29 +0200)
> From: Robert Pluim <rpluim@gmail.com>
> Cc: Mike Hamrick <mikeh@muppetlabs.com>, emacs-devel@gnu.org
> Date: Wed, 12 Aug 2020 11:36:29 +0200
>
> >>>>> On Tue, 11 Aug 2020 22:17:08 +0300, Eli Zaretskii <eliz@gnu.org> said:
>
> Eli> Please use our style of indentation in C source files (basically, make
> Eli> sure indent-tabs-mode is non-nil).
>
> That is not reflected in our .dir-locals.el for C files (for elisp it
> sets indent-tabs-mode to nil)
Because it's the default, I believe. Also because we couldn't agree
on a mandatory setting at the time this setting in .dir-locals.el was
discussed.
> I thought it was 'you can use tabs or spaces, but try match the usage
> of existing code when making changes' (which since Iʼm pro-space means
> that when making additions or when the lines Iʼm changing have a mix,
> I use spaces).
That would also indicate that the change in question should have used
mixed TABs and SPACEs.
next prev parent reply other threads:[~2020-08-12 14:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 21:44 [PATCH] TTY Support for ECMA-48 strike-through graphic rendition Mike Hamrick
2020-06-26 10:46 ` Eli Zaretskii
2020-06-26 19:23 ` Mike Hamrick
2020-06-26 19:38 ` Eli Zaretskii
2020-08-11 19:17 ` Eli Zaretskii
2020-08-12 9:36 ` Robert Pluim
2020-08-12 14:23 ` Eli Zaretskii [this message]
2020-08-12 16:19 ` Robert Pluim
2020-08-12 18:12 ` Stefan Monnier
2020-09-13 23:05 ` Mike Hamrick
2020-09-14 22:25 ` Mike Hamrick
2020-09-18 8:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83imdondsl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mikeh@muppetlabs.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).