From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] TTY Support for ECMA-48 strike-through graphic rendition
Date: Tue, 11 Aug 2020 22:17:08 +0300
Message-ID: <83v9hpngaz.fsf@gnu.org>
References: <m1mu4qg6s4.fsf@eidolon.muppetlabs.com> <837dvurtnn.fsf@gnu.org>
 <m1lfk9fx6j.fsf@eidolon.muppetlabs.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="26820"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Mike Hamrick <mikeh@muppetlabs.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 11 21:17:52 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1k5ZmS-0006sW-IR
	for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Aug 2020 21:17:52 +0200
Original-Received: from localhost ([::1]:50540 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1k5ZmR-0007CS-HS
	for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Aug 2020 15:17:51 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54966)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1k5Zlv-0006nL-Qh
 for emacs-devel@gnu.org; Tue, 11 Aug 2020 15:17:19 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47959)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1k5Zlv-0005R5-HI; Tue, 11 Aug 2020 15:17:19 -0400
Original-Received: from [176.228.60.248] (port=2568 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1k5Zlu-0006GX-Up; Tue, 11 Aug 2020 15:17:19 -0400
In-Reply-To: <m1lfk9fx6j.fsf@eidolon.muppetlabs.com> (message from Mike
 Hamrick on Fri, 26 Jun 2020 12:23:48 -0700)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:253647
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/253647>

> From: Mike Hamrick <mikeh@muppetlabs.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 26 Jun 2020 12:23:48 -0700
> 
> I've updated my patch to include a NEWS item.  I grepped through the
> manual looking for areas that might need updating, and did not find
> any.

Thanks, a couple of really minor nits below:

> @@ -1971,7 +1974,8 @@ turn_off_face (struct frame *f, int face_id)
>        if (face->tty_bold_p
>  	  || face->tty_italic_p
>  	  || face->tty_reverse_p
> -	  || face->tty_underline_p)
> +	  || face->tty_underline_p
> +          || face->tty_strike_through_p)

Please use our style of indentation in C source files (basically, make
sure indent-tabs-mode is non-nil).

Also, please make sure the patch still applies to the current master,
and if not, please update it.

Thanks.