From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: buffer.c/buffer.h: How to add new buffer-local variables? Date: Tue, 09 Apr 2019 09:13:59 +0300 Message-ID: <83tvf77ljs.fsf@gnu.org> References: <3C6817C0-1CDB-4F83-805E-BF6B93C77F44@gnu.org> <87y34kl7y5.fsf@igel.home> <831s2c8kav.fsf@gnu.org> <5d4bef90-0fdc-31e2-0543-a322cdc4eea4@cs.ucla.edu> <87ef6cywbp.fsf@md5i.com> <16aa8fe9-82dc-c3f6-dbb5-1027ef8ae796@cs.ucla.edu> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="203720"; mail-complaints-to="usenet@blaine.gmane.org" Cc: mwd@md5i.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 09 08:15:42 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDk2n-000qse-Qh for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 08:15:41 +0200 Original-Received: from localhost ([127.0.0.1]:36048 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDk2m-0002nc-Qw for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 02:15:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDk1E-0002Dy-Nk for emacs-devel@gnu.org; Tue, 09 Apr 2019 02:14:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDk1D-0005rb-Sw; Tue, 09 Apr 2019 02:14:04 -0400 Original-Received: from [176.228.60.248] (port=4548 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hDk1C-0002rB-Fc; Tue, 09 Apr 2019 02:14:02 -0400 In-reply-to: <16aa8fe9-82dc-c3f6-dbb5-1027ef8ae796@cs.ucla.edu> (message from Paul Eggert on Mon, 8 Apr 2019 16:06:07 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235153 Archived-At: > From: Paul Eggert > Date: Mon, 8 Apr 2019 16:06:07 -0700 > > On 4/8/19 3:19 PM, Michael Welsh Duggan wrote: > > I would also add a comment after the > > cursor_in_non_selected_windows_ entry to the effect that the define > > needs to be updated if more are added afterward. > > There's already a comment there to that effect, and similar comments > near similar boundaries in other structures. A patch to regularize > and/or clarify them would be welcome. > > Not sure I want to add a macro, though, as it's one more thing to > maintain and it's not clear it's worth the hassle since one can get the > macro wrong too. I agree. A macro doesn't necessarily tell what it's replaced with, so when you read code which uses the macro, you many times need to look up that macro to understand what it hides. A comment doesn't have this problem.