unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: David Kastrup <dak@gnu.org>
Cc: oub@mat.ucm.es, emacs-devel@gnu.org
Subject: Re: RCS: (vc-next-action 1) only New Backend
Date: Sat, 19 Sep 2015 14:06:37 +0300	[thread overview]
Message-ID: <83si6apt1e.fsf@gnu.org> (raw)
In-Reply-To: <87wpvmk75y.fsf@fencepost.gnu.org>

> From: David Kastrup <dak@gnu.org>
> Cc: oub@mat.ucm.es,  emacs-devel@gnu.org
> Date: Sat, 19 Sep 2015 12:58:01 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > (If I knew that removing this "rollback" also removes the ability to
> > force a revision at checkin time, I'd have objected to the removal.
> > But that never came up, AFAIR; instead, the only issue discussed at
> > length was the meaning of "rollback" for modern VCSes.)
> 
> I don't think that this commit is really related to the "rollback"
> discussion.

You are right, the commit you've shown is about vc-register, which I
didn't change for the reasons explained in my previous message.

> There actually is
> 
> commit ea8b9df12e38775600e850b8a57add2cf523bde5
> Author: Eric S. Raymond <esr@thyrsus.com>
> Date:   Thu Dec 11 22:44:32 2014 -0500
> 
>     Remove VC rollback method.
>     
>     * vc/vc.el, vc/vc-hg.el, vc/vc-git.el, vc/vc-hooks.el,
>     vc/vc-mtn.el, vc/vc-rcs.el, vc/vc-sccs.el, vc/vc-src.el: rrollback
>     method removed, to be replaced in the future by uncommit.
> 
> which has an author date 10 days later than the removal of the initial
> revision argument.

Maybe, but then the commit which is to blame for Uwe's trouble, viz.:

  commit f83109f0fabe13c0175ca6fe23b475bd8a9d9d99
  Author: Eric S. Raymond <esr@thyrsus.com>
  Date:   Thu Nov 20 02:37:06 2014 -0500

      Remove never-used rev argument from VC's backend checkin methods.

      Alters vc/vc-arch.el, vc/vc-bzr.el, vc/vc-cvs.el, vc/vc-dav.el,
      vc/vc-git.el, vc/vc-hg.el, vc/vc-mtn.el, vc/vc-rcs.el,
      vc/vc-sccs.el, vc/vc-svn.el, vc/vc.el.

      Only the RCS, SCCS, and CVS back ends tried to do anything with it,
      and that code was never exercised. Chiseling away the cruft of
      decades...

was never discussed at all, at least I couldn't find it.  And that is
what I partially resurrected.



  reply	other threads:[~2015-09-19 11:06 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 15:39 RCS: (vc-next-action 1) only New Backend Uwe Brauer
2015-09-18 17:18 ` Eli Zaretskii
2015-09-18 20:46   ` Uwe Brauer
2015-09-19  7:00     ` Eli Zaretskii
2015-09-19  8:46       ` Uwe Brauer
2015-09-19  8:59         ` David Kastrup
2015-09-19  9:23           ` Eli Zaretskii
2015-09-19  9:36             ` Uwe Brauer
2015-09-19 10:34               ` Eli Zaretskii
2015-09-19  9:30           ` Eli Zaretskii
2015-09-19 10:00             ` David Kastrup
2015-09-19 10:30               ` Uwe Brauer
2015-09-19 10:40               ` Eli Zaretskii
2015-09-19 10:58                 ` David Kastrup
2015-09-19 11:06                   ` Eli Zaretskii [this message]
2015-09-19 12:29                 ` Uwe Brauer
2015-09-19 14:11                   ` Eli Zaretskii
2015-09-19 21:15                     ` Uwe Brauer
2015-09-19 16:05                 ` Dmitry Gutov
2015-09-19 17:35                   ` Eli Zaretskii
2015-09-19 17:41                     ` Dmitry Gutov
2015-09-19 17:49                       ` Eli Zaretskii
2015-09-19 19:44                         ` Dmitry Gutov
2015-09-19 21:14                           ` Uwe Brauer
2015-09-19 22:42                             ` Dmitry Gutov
2015-09-20  6:08                             ` Eli Zaretskii
2015-09-20 13:10                               ` Dmitry Gutov
2015-09-20 14:49                                 ` Eli Zaretskii
2015-09-20 16:27                                   ` Stefan Monnier
2015-09-20 17:10                                     ` Eli Zaretskii
2015-09-20 17:15                                       ` Eli Zaretskii
2015-09-20 19:25                                         ` Stefan Monnier
2015-09-20 19:40                                           ` Eli Zaretskii
2015-09-20 20:53                                             ` Dmitry Gutov
2015-09-21  6:17                                               ` Eli Zaretskii
2015-09-21  2:18                                             ` Stefan Monnier
2015-09-21  2:29                                               ` Dmitry Gutov
2015-09-21  6:59                                                 ` Eli Zaretskii
2015-09-21 14:06                                                   ` Dmitry Gutov
2015-09-21 16:12                                                     ` Eli Zaretskii
2015-09-21 16:48                                                       ` Dmitry Gutov
2015-09-21 16:59                                                         ` Eli Zaretskii
2015-09-21 17:33                                                           ` Dmitry Gutov
2015-09-21 19:21                                                             ` Eli Zaretskii
2015-09-21  5:30                                               ` David Kastrup
2015-09-21 13:14                                                 ` Stefan Monnier
2015-09-21  7:08                                               ` Eli Zaretskii
2015-09-20 23:54                                       ` Dmitry Gutov
2015-09-21  6:52                                         ` Eli Zaretskii
2015-09-20  6:03                           ` Eli Zaretskii
2015-09-19 20:21                       ` Stefan Monnier
2015-09-19  9:31           ` Uwe Brauer
2015-09-19 17:29             ` Stefan Monnier
2015-09-19 17:45               ` Eli Zaretskii
2015-09-19 20:18                 ` Stefan Monnier
2015-09-20  6:06                   ` Eli Zaretskii
2015-09-19  9:21         ` Eli Zaretskii
2015-09-19  9:35           ` Uwe Brauer
2015-09-19 10:34             ` Eli Zaretskii
2015-09-19 10:35               ` Uwe Brauer
2015-09-20 10:05               ` Uwe Brauer
2015-09-20 10:45                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83si6apt1e.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=oub@mat.ucm.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).