From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: RCS: (vc-next-action 1) only New Backend Date: Sat, 19 Sep 2015 14:06:37 +0300 Message-ID: <83si6apt1e.fsf@gnu.org> References: <87mvwjohyi.fsf@mat.ucm.es> <838u83r6hl.fsf@gnu.org> <87k2rn5ucg.fsf@mat.ucm.es> <837fnmrizs.fsf@gnu.org> <877fnm4wzn.fsf@mat.ucm.es> <876136lr83.fsf@fencepost.gnu.org> <83y4g2pxh3.fsf@gnu.org> <871tdulodu.fsf@fencepost.gnu.org> <83twqqpu91.fsf@gnu.org> <87wpvmk75y.fsf@fencepost.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1442660825 12810 80.91.229.3 (19 Sep 2015 11:07:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Sep 2015 11:07:05 +0000 (UTC) Cc: oub@mat.ucm.es, emacs-devel@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 19 13:06:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZdFyo-0002L7-RI for ged-emacs-devel@m.gmane.org; Sat, 19 Sep 2015 13:06:54 +0200 Original-Received: from localhost ([::1]:45156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdFyo-0005b4-8I for ged-emacs-devel@m.gmane.org; Sat, 19 Sep 2015 07:06:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdFyZ-0005ZW-5V for emacs-devel@gnu.org; Sat, 19 Sep 2015 07:06:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZdFyX-0006oe-S4 for emacs-devel@gnu.org; Sat, 19 Sep 2015 07:06:39 -0400 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:34941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdFyU-0006m7-2j; Sat, 19 Sep 2015 07:06:34 -0400 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NUX005007LULB00@mtaout27.012.net.il>; Sat, 19 Sep 2015 14:02:58 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NUX006PX80YUD00@mtaout27.012.net.il>; Sat, 19 Sep 2015 14:02:58 +0300 (IDT) In-reply-to: <87wpvmk75y.fsf@fencepost.gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.183 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190096 Archived-At: > From: David Kastrup > Cc: oub@mat.ucm.es, emacs-devel@gnu.org > Date: Sat, 19 Sep 2015 12:58:01 +0200 > > Eli Zaretskii writes: > > > (If I knew that removing this "rollback" also removes the ability to > > force a revision at checkin time, I'd have objected to the removal. > > But that never came up, AFAIR; instead, the only issue discussed at > > length was the meaning of "rollback" for modern VCSes.) > > I don't think that this commit is really related to the "rollback" > discussion. You are right, the commit you've shown is about vc-register, which I didn't change for the reasons explained in my previous message. > There actually is > > commit ea8b9df12e38775600e850b8a57add2cf523bde5 > Author: Eric S. Raymond > Date: Thu Dec 11 22:44:32 2014 -0500 > > Remove VC rollback method. > > * vc/vc.el, vc/vc-hg.el, vc/vc-git.el, vc/vc-hooks.el, > vc/vc-mtn.el, vc/vc-rcs.el, vc/vc-sccs.el, vc/vc-src.el: rrollback > method removed, to be replaced in the future by uncommit. > > which has an author date 10 days later than the removal of the initial > revision argument. Maybe, but then the commit which is to blame for Uwe's trouble, viz.: commit f83109f0fabe13c0175ca6fe23b475bd8a9d9d99 Author: Eric S. Raymond Date: Thu Nov 20 02:37:06 2014 -0500 Remove never-used rev argument from VC's backend checkin methods. Alters vc/vc-arch.el, vc/vc-bzr.el, vc/vc-cvs.el, vc/vc-dav.el, vc/vc-git.el, vc/vc-hg.el, vc/vc-mtn.el, vc/vc-rcs.el, vc/vc-sccs.el, vc/vc-svn.el, vc/vc.el. Only the RCS, SCCS, and CVS back ends tried to do anything with it, and that code was never exercised. Chiseling away the cruft of decades... was never discussed at all, at least I couldn't find it. And that is what I partially resurrected.