From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: scratch/backend-completion 9a62da21c2 1/2: Integrate Stefan suggestions but rename it to "external-completion.el"
Date: Wed, 07 Dec 2022 15:56:09 +0200 [thread overview]
Message-ID: <83r0xb48sm.fsf@gnu.org> (raw)
In-Reply-To: <CALDnm507ziXQES6eFqvgWGUFoM9=FZDLE00VGSzeass--A1FDQ@mail.gmail.com> (message from João Távora on Wed, 7 Dec 2022 11:09:02 +0000)
> From: João Távora <joaotavora@gmail.com>
> Date: Wed, 7 Dec 2022 11:09:02 +0000
> Cc: emacs-devel <emacs-devel@gnu.org>
>
> Eli, if you haven't been following this discussion closely, this is a refactor of
> functionality already present in Eglot that consolidates the support for
> offering completions coming from external tools (like LSP servers, but not only)
> and makes it available to more third party packages.
>
> I think there shouldn't be any adverse effects of pushing this to the emacs-29
> branch, but if you think it's better, I'll push it to master instead.
>
> It shouldn't make much of a difference since the new external-completion.el
> file is going to be a GNU ELPA :core package and as such it will be available
> in Emacs 28 anyway via package-install.
>
> Let me know what you think. The commentary of the new file, the docstring
> of external-completion-table and the commit messages should give details.
> I'll be happy to fix them further if you have comments.
I'm fine with installing this on the emacs-29 branch, but I think
external-completion.el warrants a NEWS entry.
next prev parent reply other threads:[~2022-12-07 13:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167007345844.23701.8454474119701440468@vcs2.savannah.gnu.org>
[not found] ` <20221203131739.3FCF9C004BE@vcs2.savannah.gnu.org>
2022-12-03 14:10 ` scratch/backend-completion aaaa016056 2/2: Speed it up Stefan Monnier
2022-12-03 23:30 ` João Távora
2022-12-04 0:18 ` Stefan Monnier
2022-12-04 11:11 ` João Távora
[not found] ` <20221203131739.2A601C004BA@vcs2.savannah.gnu.org>
2022-12-03 14:26 ` scratch/backend-completion 9a62da21c2 1/2: Integrate Stefan suggestions but rename it to "external-completion.el" Stefan Monnier
2022-12-03 23:36 ` João Távora
2022-12-04 0:31 ` Stefan Monnier
2022-12-04 10:02 ` João Távora
2022-12-04 16:54 ` Stefan Monnier
2022-12-04 20:04 ` João Távora
2022-12-06 0:14 ` Stefan Monnier
2022-12-07 11:09 ` João Távora
2022-12-07 13:56 ` Eli Zaretskii [this message]
2022-12-07 19:09 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r0xb48sm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).