From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: scratch/backend-completion 9a62da21c2 1/2: Integrate Stefan suggestions but rename it to "external-completion.el"
Date: Sun, 4 Dec 2022 20:04:27 +0000 [thread overview]
Message-ID: <CALDnm50S9YjFgwZZM31t2GHKTHfUxNX+3AAoCM+XnRUq+pnyWQ@mail.gmail.com> (raw)
In-Reply-To: <jwvfsdvxgde.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]
On Sun, Dec 4, 2022, 16:54 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
There's one I can think of: SLY, because there external tool's
> completion code can be tweaked to fit the needs of Emacs :-)
>
> For most others it's probably difficult, indeed, which is why
> I suggested to make it optional (unless you know how the tool
> does its matching in which case you may be able to re-use
> `completion-pcm--merge-try` or to implement something similar).
>
Yup, this rhymes exactly with what I wrote in the docstring in the latest
version. I understand how it could be used now. Another question is if I
as SLY author would use it. I don't think so, to be honest, seems to much
hassle for not a lot of benefit. But others may want to, of course.
> Else, I think we end up contacting the external tool one too many times
> for
> > the same PATTERN. That's at least with the popular completion front-ends
> > such as fido/vertico who probably go for the 'allc' immediately.
>
> The default UI uses either tryc (when you hit TAB) or allc (when you
> ask the see *Completions*) not both.
Yes and eventually if you hit TAB twice that's two requests. So we need
caching. But that's fine, I've implemented that already. Have a look at the
latest commit when you find the time.
João
[-- Attachment #2: Type: text/html, Size: 2018 bytes --]
next prev parent reply other threads:[~2022-12-04 20:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167007345844.23701.8454474119701440468@vcs2.savannah.gnu.org>
[not found] ` <20221203131739.3FCF9C004BE@vcs2.savannah.gnu.org>
2022-12-03 14:10 ` scratch/backend-completion aaaa016056 2/2: Speed it up Stefan Monnier
2022-12-03 23:30 ` João Távora
2022-12-04 0:18 ` Stefan Monnier
2022-12-04 11:11 ` João Távora
[not found] ` <20221203131739.2A601C004BA@vcs2.savannah.gnu.org>
2022-12-03 14:26 ` scratch/backend-completion 9a62da21c2 1/2: Integrate Stefan suggestions but rename it to "external-completion.el" Stefan Monnier
2022-12-03 23:36 ` João Távora
2022-12-04 0:31 ` Stefan Monnier
2022-12-04 10:02 ` João Távora
2022-12-04 16:54 ` Stefan Monnier
2022-12-04 20:04 ` João Távora [this message]
2022-12-06 0:14 ` Stefan Monnier
2022-12-07 11:09 ` João Távora
2022-12-07 13:56 ` Eli Zaretskii
2022-12-07 19:09 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm50S9YjFgwZZM31t2GHKTHfUxNX+3AAoCM+XnRUq+pnyWQ@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).