From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: scratch/backend-completion 9a62da21c2 1/2: Integrate Stefan suggestions but rename it to "external-completion.el" Date: Wed, 07 Dec 2022 15:56:09 +0200 Message-ID: <83r0xb48sm.fsf@gnu.org> References: <167007345844.23701.8454474119701440468@vcs2.savannah.gnu.org> <20221203131739.2A601C004BA@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39682"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 07 14:56:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2uuu-000A5T-RF for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Dec 2022 14:56:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2uuP-0000vx-5F; Wed, 07 Dec 2022 08:56:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2uuN-0000vK-Hm for emacs-devel@gnu.org; Wed, 07 Dec 2022 08:56:23 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2uuM-0007re-IK; Wed, 07 Dec 2022 08:56:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=XgknAb9XXzkGBvlakw72WXLP7OQ8OvfCf+hm5gixttQ=; b=jOu6JM6s3idnxI8WXQlX G3etZvlbic8MQzHtVhsFGRJyejSKEStkd8IhS68GI8Uin5jGX2iZXAFSly+1kwqvIVdUUHJQqQA+5 4q3zuWZycWkyI1I/JqD9T3Dxdj6SPBel6PeD7G1b/bD/wQe1PLud0RJSPCGKFyb74a7PfRUx+bfse M7o4ySHqYIUo/a1Pd5uc0+vEV38k8+fh2p5TqJcolglIZewmkGDGfj36Q4PthGAA3AWjLcmotCgRQ SqgJo3aZgCc/NfBpGkvl1yQgxme4BRNJZ78F+/GLf4CzyY2rnxl5aLrq60IjAKVO9j4WGFA5kqHaM YTIdDkgxPSrpuA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2uuM-0002yw-0z; Wed, 07 Dec 2022 08:56:22 -0500 In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Wed, 7 Dec 2022 11:09:02 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301014 Archived-At: > From: João Távora > Date: Wed, 7 Dec 2022 11:09:02 +0000 > Cc: emacs-devel > > Eli, if you haven't been following this discussion closely, this is a refactor of > functionality already present in Eglot that consolidates the support for > offering completions coming from external tools (like LSP servers, but not only) > and makes it available to more third party packages. > > I think there shouldn't be any adverse effects of pushing this to the emacs-29 > branch, but if you think it's better, I'll push it to master instead. > > It shouldn't make much of a difference since the new external-completion.el > file is going to be a GNU ELPA :core package and as such it will be available > in Emacs 28 anyway via package-install. > > Let me know what you think. The commentary of the new file, the docstring > of external-completion-table and the commit messages should give details. > I'll be happy to fix them further if you have comments. I'm fine with installing this on the emacs-29 branch, but I think external-completion.el warrants a NEWS entry.