From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: scratch/backend-completion aaaa016056 2/2: Speed it up
Date: Sat, 3 Dec 2022 23:30:37 +0000 [thread overview]
Message-ID: <CALDnm52NBGi7zjk45MnDkZ2B13WRs_h1=FS2aRH6QN79_+p0TQ@mail.gmail.com> (raw)
In-Reply-To: <jwv359w37li.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
> But I'm surprised it made things slow: this code should only be involved
> when the user choose some *other* completion style, so could you check
> which method of the completion table was invoked?
It seems to be called with both `nil` and `lambda`. I've added this to the
FIXME comment.
It made things slow because when selecting a candidate with
fido-vertical-mode it did another useless 0.5s/1s lookup for the thing
I had just selected.
> Maybe we should only use that code when `action` is one of `t` or `nil`?
Maybe. Anyway in my tests it's working fine without it. But `nil` doesn't
break them, so I'm fine if you add them. I'm just confused about the
possible benefits that may come from that complexity. I wish you could
post an illustrative example with some strings that a mere mortal might
follow along.
João
[-- Attachment #2: Type: text/html, Size: 1088 bytes --]
next prev parent reply other threads:[~2022-12-03 23:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167007345844.23701.8454474119701440468@vcs2.savannah.gnu.org>
[not found] ` <20221203131739.3FCF9C004BE@vcs2.savannah.gnu.org>
2022-12-03 14:10 ` scratch/backend-completion aaaa016056 2/2: Speed it up Stefan Monnier
2022-12-03 23:30 ` João Távora [this message]
2022-12-04 0:18 ` Stefan Monnier
2022-12-04 11:11 ` João Távora
[not found] ` <20221203131739.2A601C004BA@vcs2.savannah.gnu.org>
2022-12-03 14:26 ` scratch/backend-completion 9a62da21c2 1/2: Integrate Stefan suggestions but rename it to "external-completion.el" Stefan Monnier
2022-12-03 23:36 ` João Távora
2022-12-04 0:31 ` Stefan Monnier
2022-12-04 10:02 ` João Távora
2022-12-04 16:54 ` Stefan Monnier
2022-12-04 20:04 ` João Távora
2022-12-06 0:14 ` Stefan Monnier
2022-12-07 11:09 ` João Távora
2022-12-07 13:56 ` Eli Zaretskii
2022-12-07 19:09 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm52NBGi7zjk45MnDkZ2B13WRs_h1=FS2aRH6QN79_+p0TQ@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).