From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs-24.5-1-universal.dmg for macosx dumps on first keystroke Date: Mon, 29 Aug 2016 17:32:20 +0300 Message-ID: <83poorbq8b.fsf@gnu.org> References: <20160825223858.GA51405@breton.holly.idiocy.org> <20160826182149.GA51596@breton.holly.idiocy.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1472481175 26916 195.159.176.226 (29 Aug 2016 14:32:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 Aug 2016 14:32:55 +0000 (UTC) Cc: randy@psg.com, emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 29 16:32:50 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1beNcG-0006DC-A1 for ged-emacs-devel@m.gmane.org; Mon, 29 Aug 2016 16:32:48 +0200 Original-Received: from localhost ([::1]:43869 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beNcD-0004db-Sa for ged-emacs-devel@m.gmane.org; Mon, 29 Aug 2016 10:32:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beNbz-0004ae-Kx for emacs-devel@gnu.org; Mon, 29 Aug 2016 10:32:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1beNbv-00065R-0r for emacs-devel@gnu.org; Mon, 29 Aug 2016 10:32:31 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beNbu-00065N-TP; Mon, 29 Aug 2016 10:32:26 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4280 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1beNbt-0007pK-Nc; Mon, 29 Aug 2016 10:32:26 -0400 In-reply-to: (message from Alan Third on Mon, 29 Aug 2016 10:28:38 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206869 Archived-At: > From: Alan Third > Date: Mon, 29 Aug 2016 10:28:38 +0100 > Cc: Emacs-Devel devel > > On 26 August 2016 at 19:21, Alan Third wrote: > > As a quick fix for you, Randy, instead of using "alt", use 'alt. That > > works as you’d expect. I still need to work out why this crashes, > > though. Presumably something somewhere is looking for a symbol and > > really doesn’t like getting a string instead. > > I've had a look about and am currently none the wiser. Is there a standard > way of handling this sort of thing in C code? Is it just a case of putting > some sort of SYMBOLP check in before the variable is used or should we > be able to handle a string instead of a symbol? This is not NS specific. The following recipe will crash Emacs on any platform: (let ((where-is-preferred-modifier "alt")) (where-is 'goto-char)) I think I've fixed this on the master branch, by outright rejecting non-symbol values of modifiers in parse_solitary_modifier. I don't think supporting strings there is required, as this clearly is a cockpit error. Thanks.