From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] TTY Support for ECMA-48 strike-through graphic rendition Date: Wed, 12 Aug 2020 17:23:38 +0300 Message-ID: <83imdondsl.fsf@gnu.org> References: <837dvurtnn.fsf@gnu.org> <83v9hpngaz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1114"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mikeh@muppetlabs.com, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 12 16:24:18 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5rfu-000096-1V for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Aug 2020 16:24:18 +0200 Original-Received: from localhost ([::1]:57100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5rfs-0002wm-V2 for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Aug 2020 10:24:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5rfQ-0002Vm-Hp for emacs-devel@gnu.org; Wed, 12 Aug 2020 10:23:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34817) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5rfQ-0002xT-21; Wed, 12 Aug 2020 10:23:48 -0400 Original-Received: from [176.228.60.248] (port=4860 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k5rfP-0003z8-10; Wed, 12 Aug 2020 10:23:47 -0400 In-Reply-To: (message from Robert Pluim on Wed, 12 Aug 2020 11:36:29 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253690 Archived-At: > From: Robert Pluim > Cc: Mike Hamrick , emacs-devel@gnu.org > Date: Wed, 12 Aug 2020 11:36:29 +0200 > > >>>>> On Tue, 11 Aug 2020 22:17:08 +0300, Eli Zaretskii said: > > Eli> Please use our style of indentation in C source files (basically, make > Eli> sure indent-tabs-mode is non-nil). > > That is not reflected in our .dir-locals.el for C files (for elisp it > sets indent-tabs-mode to nil) Because it's the default, I believe. Also because we couldn't agree on a mandatory setting at the time this setting in .dir-locals.el was discussed. > I thought it was 'you can use tabs or spaces, but try match the usage > of existing code when making changes' (which since Iʼm pro-space means > that when making additions or when the lines Iʼm changing have a mix, > I use spaces). That would also indicate that the change in question should have used mixed TABs and SPACEs.