[emacs-announce] Emacs pretest 25.0.93

[emacs-announce] Emacs pretest 25.0.93

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

Hi!

Another pretest for what will be the 25.1 release of Emacs
(the extensible text editor) is available at

  ftp://alpha.gnu.org/gnu/emacs/pretest/emacs-25.0.93.tar.xz

You can get the PGP signature at

  ftp://alpha.gnu.org/gnu/emacs/pretest/emacs-25.0.93.tar.xz.sig

Please give it as much testing as you can.

As always, if you encounter problems building or using Emacs,
send a report to bug-gnu-emacs@gnu.org with full details
(if possible, use M-x report-emacs-bug).

Thanks for helping to test Emacs.

Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: [emacs-announce] Emacs pretest 25.0.93

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

Nicolas Petton <nicolas@petton.fr> schrieb am Fr., 22. Apr. 2016 um
19:26 Uhr:

> Hi!
>
> Another pretest for what will be the 25.1 release of Emacs
> (the extensible text editor) is available at
>
>   ftp://alpha.gnu.org/gnu/emacs/pretest/emacs-25.0.93.tar.xz
>
>
Thanks! One question: for the other pretests you added tags to the Git
repo, could you please do the same for this pretest?

[-- Attachment #2: Type: text/html, Size: 789 bytes --]

Re: [emacs-announce] Emacs pretest 25.0.93

[Eli Zaretskii]

> From: Nicolas Petton <nicolas@petton.fr>
> Date: Fri, 22 Apr 2016 19:26:02 +0200
> 
> Another pretest for what will be the 25.1 release of Emacs
> (the extensible text editor) is available at
> 
>   ftp://alpha.gnu.org/gnu/emacs/pretest/emacs-25.0.93.tar.xz

Thanks.  However, building the current emacs-25 branch still produces
a 25.0.92.NNN version.

Re: [emacs-announce] Emacs pretest 25.0.93

[nicolas]

> Thanks.  However, building the current emacs-25 branch still produces
> a 25.0.92.NNN version.

I will have a look at that.

Nico

Re: [emacs-announce] Emacs pretest 25.0.93

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks.  However, building the current emacs-25 branch still produces
> a 25.0.92.NNN version.

Of course, I forgot to push my commits :)

Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: [emacs-announce] Emacs pretest 25.0.93

[Eli Zaretskii]

> From: Nicolas Petton <nicolas@petton.fr>
> Date: Fri, 22 Apr 2016 21:12:03 +0200
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Thanks.  However, building the current emacs-25 branch still produces
> > a 25.0.92.NNN version.
> 
> Of course, I forgot to push my commits :)

Thanks, now everything seems to be in order.

Re: [emacs-announce] Emacs pretest 25.0.93

[Achim Gratz]

Nicolas Petton writes:
> As always, if you encounter problems building or using Emacs,
> send a report to bug-gnu-emacs@gnu.org with full details
> (if possible, use M-x report-emacs-bug).

When I'm trying to build this from Git, the build errors out with

"Invalid time specification"

on trying to create any of the loaddefs files.  What's up with that?


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

Re: [emacs-announce] Emacs pretest 25.0.93

[Eli Zaretskii]

> From: Achim Gratz <Stromeko@nexgo.de>
> Date: Sat, 23 Apr 2016 13:41:38 +0200
> 
> Nicolas Petton writes:
> > As always, if you encounter problems building or using Emacs,
> > send a report to bug-gnu-emacs@gnu.org with full details
> > (if possible, use M-x report-emacs-bug).
> 
> When I'm trying to build this from Git, the build errors out with
> 
> "Invalid time specification"
> 
> on trying to create any of the loaddefs files.  What's up with that?

Doesn't happen here.  What command fails, exactly?  Is that
reproducible if you invoke the same command by hand?

Re: [emacs-announce] Emacs pretest 25.0.93

[Achim Gratz]

Eli Zaretskii writes:
> Doesn't happen here.  What command fails, exactly?  Is that
> reproducible if you invoke the same command by hand?

EMACSLOADPATH= '../src/bootstrap-emacs' -batch --no-site-file --no-site-lisp -l autoload \
   --eval "(setq generate-autoload-cookie \";;;###cal-autoload\")" \
   --eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"../../lisp/calendar/cal-loaddefs.el\")))" \
   -f batch-update-autoloads ../../lisp/calendar
Invalid time specification

And yes, the same thing happens when I run this command manually.
Trying to run bootstrap-emacs in interactive mode results in this error:

Loading /home/gratz/lisp/emacs/lisp/delsel.el (source)...done
Loading /home/gratz/lisp/emacs/lisp/gnus/gnus.el (source)...
Eager macro-expansion failure: (void-function cl-subseq) [3 times]
Loading /home/gratz/lisp/emacs/lisp/gnus/gnus.el (source)...done
Loading /home/gratz/lisp/emacs/lisp/paren.el (source)...done
Eager macro-expansion failure: (void-function cl-subseq) [8 times]
setq: Symbol’s function definition is void: cl-subseq

When I then run the same stuff from the scratch buffer I get the same error.

Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

Re: [emacs-announce] Emacs pretest 25.0.93

[Achim Gratz]

Achim Gratz writes:
> When I then run the same stuff from the scratch buffer I get the same error.

While trying to bisect this it becoame clear that this is caused by the
build environment.  I'm running openSUSE/Tumbleweed, so the 20 days
since the last successful build had quite a lot of updates.  I have no
idea what to look for, though.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables

Re: [emacs-announce] Emacs pretest 25.0.93

[Eli Zaretskii]

> From: Achim Gratz <Stromeko@nexgo.de>
> Date: Sat, 23 Apr 2016 14:37:14 +0200
> 
> Achim Gratz writes:
> > When I then run the same stuff from the scratch buffer I get the same error.
> 
> While trying to bisect this it becoame clear that this is caused by the
> build environment.  I'm running openSUSE/Tumbleweed, so the 20 days
> since the last successful build had quite a lot of updates.  I have no
> idea what to look for, though.

Run the faulting command under a debugger, put a breakpoint in
Fsignal, and show the backtrace.  That might produce enough hints to
find out what is failing and why.

Re: [emacs-announce] Emacs pretest 25.0.93

[Eli Zaretskii]

> From: Achim Gratz <Stromeko@nexgo.de>
> Date: Sat, 23 Apr 2016 14:28:38 +0200
> 
> Eli Zaretskii writes:
> > Doesn't happen here.  What command fails, exactly?  Is that
> > reproducible if you invoke the same command by hand?
> 
> EMACSLOADPATH= '../src/bootstrap-emacs' -batch --no-site-file --no-site-lisp -l autoload \
>    --eval "(setq generate-autoload-cookie \";;;###cal-autoload\")" \
>    --eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"../../lisp/calendar/cal-loaddefs.el\")))" \
>    -f batch-update-autoloads ../../lisp/calendar
> Invalid time specification
> 
> And yes, the same thing happens when I run this command manually.
> Trying to run bootstrap-emacs in interactive mode results in this error:

Not surprisingly, this doesn't fail here.  The only difference I can
spot is that I build inside the source tree, whereas you (evidently)
have a separate build directory.  But I don't think this could explain
the error.

Re: [emacs-announce] Emacs pretest 25.0.93

[Achim Gratz]

Eli Zaretskii writes:
> Run the faulting command under a debugger, put a breakpoint in
> Fsignal, and show the backtrace.  That might produce enough hints to
> find out what is failing and why.

It doesn't really fault, at least not at the lisp level.  There actually
is an auto-save file that seems to have all the extracted loaddefs in,
but somehow it then doesn't finish.  For the autoloads entries there are
lots of differences like these (I'm comparing with the installed version
of my last build):

-;;;### (autoloads nil "cal-iso" "cal-iso.el" t)
+;;;### (autoloads nil "cal-iso" "cal-iso.el" (22225 49314 854982
+;;;;;;  791000))


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for KORG EX-800 and Poly-800MkII V0.9:
http://Synth.Stromeko.net/Downloads.html#KorgSDada

Re: [emacs-announce] Emacs pretest 25.0.93

[Eli Zaretskii]

> From: Achim Gratz <Stromeko@nexgo.de>
> Date: Sat, 23 Apr 2016 15:29:42 +0200
> 
> Eli Zaretskii writes:
> > Run the faulting command under a debugger, put a breakpoint in
> > Fsignal, and show the backtrace.  That might produce enough hints to
> > find out what is failing and why.
> 
> It doesn't really fault, at least not at the lisp level.

Fsignal is on the C level, so a breakpoint set there in GDB will catch
any error.

> There actually is an auto-save file that seems to have all the
> extracted loaddefs in, but somehow it then doesn't finish.  For the
> autoloads entries there are lots of differences like these (I'm
> comparing with the installed version of my last build):
> 
> -;;;### (autoloads nil "cal-iso" "cal-iso.el" t)
> +;;;### (autoloads nil "cal-iso" "cal-iso.el" (22225 49314 854982
> +;;;;;;  791000))

AFAIU, these differences are meaningless.  But I have no autoloads
whose time stamp is 't'.

The problem is still the error that is signaled, and the way to
investigate it is to figure out why the error is signaled.

Re: [emacs-announce] Emacs pretest 25.0.93

[Michael Heerdegen]

[-- Attachment #1: Type: text/plain, Size: 704 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> > -;;;### (autoloads nil "cal-iso" "cal-iso.el" t)
> > +;;;### (autoloads nil "cal-iso" "cal-iso.el" (22225 49314 854982
> > +;;;;;;  791000))
>
> AFAIU, these differences are meaningless.  But I have no autoloads
> whose time stamp is 't'.

FWIW, I once saw this while calling "make" for Helm.  I investigated and
saw such a "t" timestamp in the loaddefs file.  I didn't think long
about it.  I just deleted that loaddefs file - after that, "make"
succeeded, and instead of "t" there was a "real" time stamp.

But we are lucky, I still have a Lisp backtrace from the error in my
Trash (not from building, but from reproducing with
`update-directory-autoloads'):


[-- Attachment #2: bt.txt_1407PLz --]
[-- Type: text/plain, Size: 7810 bytes --]

Debugger entered--Lisp error: (error "Invalid time specification")
  time-less-p(t (22288 49208 740259 566000))
  (not (time-less-p (nth 4 form) (nth 5 (file-attributes file))))
  (cond ((and (consp file) (stringp (car file))) (autoload-remove-section (match-beginning 0)) (setq last-time (nth 4 form)) (let ((--dolist-tail-- file)) (while --dolist-tail-- (let ((file (car --dolist-tail--))) (let ((file-time ...)) (if (and file-time ...) (progn ... ...))) (setq --dolist-tail-- (cdr --dolist-tail--)))))) ((not (stringp file))) ((or (not (file-exists-p file)) (member file done) (member (expand-file-name file) autoload-excludes)) (autoload-remove-section (match-beginning 0))) ((not (time-less-p (nth 4 form) (nth 5 (file-attributes file)))) nil) (t (autoload-remove-section (match-beginning 0)) (if (autoload-generate-file-autoloads file (current-buffer) buffer-file-name) (setq no-autoloads (cons file no-autoloads)))))
  (let* ((form (autoload-read-section-header)) (file (nth 3 form))) (cond ((and (consp file) (stringp (car file))) (autoload-remove-section (match-beginning 0)) (setq last-time (nth 4 form)) (let ((--dolist-tail-- file)) (while --dolist-tail-- (let ((file ...)) (let (...) (if ... ...)) (setq --dolist-tail-- (cdr --dolist-tail--)))))) ((not (stringp file))) ((or (not (file-exists-p file)) (member file done) (member (expand-file-name file) autoload-excludes)) (autoload-remove-section (match-beginning 0))) ((not (time-less-p (nth 4 form) (nth 5 (file-attributes file)))) nil) (t (autoload-remove-section (match-beginning 0)) (if (autoload-generate-file-autoloads file (current-buffer) buffer-file-name) (setq no-autoloads (cons file no-autoloads))))) (setq done (cons file done)) (setq files (delete file files)))
  (while (search-forward generate-autoload-section-header nil t) (let* ((form (autoload-read-section-header)) (file (nth 3 form))) (cond ((and (consp file) (stringp (car file))) (autoload-remove-section (match-beginning 0)) (setq last-time (nth 4 form)) (let ((--dolist-tail-- file)) (while --dolist-tail-- (let (...) (let ... ...) (setq --dolist-tail-- ...))))) ((not (stringp file))) ((or (not (file-exists-p file)) (member file done) (member (expand-file-name file) autoload-excludes)) (autoload-remove-section (match-beginning 0))) ((not (time-less-p (nth 4 form) (nth 5 (file-attributes file)))) nil) (t (autoload-remove-section (match-beginning 0)) (if (autoload-generate-file-autoloads file (current-buffer) buffer-file-name) (setq no-autoloads (cons file no-autoloads))))) (setq done (cons file done)) (setq files (delete file files))))
  (save-excursion (setq files (delete (file-relative-name buffer-file-name) (mapcar 'file-relative-name files))) (goto-char (point-min)) (while (search-forward generate-autoload-section-header nil t) (let* ((form (autoload-read-section-header)) (file (nth 3 form))) (cond ((and (consp file) (stringp (car file))) (autoload-remove-section (match-beginning 0)) (setq last-time (nth 4 form)) (let ((--dolist-tail-- file)) (while --dolist-tail-- (let ... ... ...)))) ((not (stringp file))) ((or (not (file-exists-p file)) (member file done) (member (expand-file-name file) autoload-excludes)) (autoload-remove-section (match-beginning 0))) ((not (time-less-p (nth 4 form) (nth 5 ...))) nil) (t (autoload-remove-section (match-beginning 0)) (if (autoload-generate-file-autoloads file (current-buffer) buffer-file-name) (setq no-autoloads (cons file no-autoloads))))) (setq done (cons file done)) (setq files (delete file files)))))
  (save-current-buffer (set-buffer (autoload-find-generated-file)) (save-excursion (setq files (delete (file-relative-name buffer-file-name) (mapcar 'file-relative-name files))) (goto-char (point-min)) (while (search-forward generate-autoload-section-header nil t) (let* ((form (autoload-read-section-header)) (file (nth 3 form))) (cond ((and (consp file) (stringp ...)) (autoload-remove-section (match-beginning 0)) (setq last-time (nth 4 form)) (let (...) (while --dolist-tail-- ...))) ((not (stringp file))) ((or (not ...) (member file done) (member ... autoload-excludes)) (autoload-remove-section (match-beginning 0))) ((not (time-less-p ... ...)) nil) (t (autoload-remove-section (match-beginning 0)) (if (autoload-generate-file-autoloads file ... buffer-file-name) (setq no-autoloads ...)))) (setq done (cons file done)) (setq files (delete file files))))) (let ((no-autoloads-time (or last-time '(0 0 0 0))) file-time) (let ((--dolist-tail-- files)) (while --dolist-tail-- (let ((file (car --dolist-tail--))) (cond ((member ... autoload-excludes) nil) ((setq file-time ...) (setq no-autoloads ...) (if ... ...))) (setq --dolist-tail-- (cdr --dolist-tail--))))) (if no-autoloads (progn (setq no-autoloads (sort no-autoloads 'string<)) (goto-char (point-max)) (search-backward "\f" nil t) (autoload-insert-section-header (current-buffer) nil nil no-autoloads no-autoloads-time) (insert generate-autoload-section-trailer)))) (let ((version-control 'never)) (save-buffer)) (autoload-save-buffers))
  (let* ((files-re (let ((tmp nil)) (let ((--dolist-tail-- (get-load-suffixes))) (while --dolist-tail-- (let (...) (if ... nil ...) (setq --dolist-tail-- ...)))) (concat "^[^=.].*" (regexp-opt tmp t) "\\'"))) (files (apply 'nconc (mapcar #'(lambda (dir) (directory-files ... t files-re)) dirs))) (done nil) (last-time) (no-autoloads nil) (autoload-modified-buffers nil) (generated-autoload-file (if (called-interactively-p 'interactive) (read-file-name "Write autoload definitions to file: ") generated-autoload-file))) (save-current-buffer (set-buffer (autoload-find-generated-file)) (save-excursion (setq files (delete (file-relative-name buffer-file-name) (mapcar 'file-relative-name files))) (goto-char (point-min)) (while (search-forward generate-autoload-section-header nil t) (let* ((form (autoload-read-section-header)) (file (nth 3 form))) (cond ((and ... ...) (autoload-remove-section ...) (setq last-time ...) (let ... ...)) ((not ...)) ((or ... ... ...) (autoload-remove-section ...)) ((not ...) nil) (t (autoload-remove-section ...) (if ... ...))) (setq done (cons file done)) (setq files (delete file files))))) (let ((no-autoloads-time (or last-time '(0 0 0 0))) file-time) (let ((--dolist-tail-- files)) (while --dolist-tail-- (let ((file ...)) (cond (... nil) (... ... ...)) (setq --dolist-tail-- (cdr --dolist-tail--))))) (if no-autoloads (progn (setq no-autoloads (sort no-autoloads 'string<)) (goto-char (point-max)) (search-backward "\f" nil t) (autoload-insert-section-header (current-buffer) nil nil no-autoloads no-autoloads-time) (insert generate-autoload-section-trailer)))) (let ((version-control 'never)) (save-buffer)) (autoload-save-buffers)))
  update-directory-autoloads(".")
  (let ((generated-autoload-file (expand-file-name "helm-autoloads.el" ".")) (backup-inhibited t)) (update-directory-autoloads "."))
  (progn (let ((generated-autoload-file (expand-file-name "helm-autoloads.el" ".")) (backup-inhibited t)) (update-directory-autoloads ".")))
  eval((progn (let ((generated-autoload-file (expand-file-name "helm-autoloads.el" ".")) (backup-inhibited t)) (update-directory-autoloads "."))) nil)
  pp-eval-expression((progn (let ((generated-autoload-file (expand-file-name "helm-autoloads.el" ".")) (backup-inhibited t)) (update-directory-autoloads "."))))
  my-pp-eval-expression((my-eval-in-mb-wrapper (let ((generated-autoload-file (expand-file-name "helm-autoloads.el" ".")) (backup-inhibited t)) (update-directory-autoloads "."))) nil)
  funcall-interactively(my-pp-eval-expression (my-eval-in-mb-wrapper (let ((generated-autoload-file (expand-file-name "helm-autoloads.el" ".")) (backup-inhibited t)) (update-directory-autoloads "."))) nil)
  call-interactively(my-pp-eval-expression nil nil)
  command-execute(my-pp-eval-expression)

[-- Attachment #3: Type: text/plain, Size: 17 bytes --]



HTH,

Michael.

Re: [emacs-announce] Emacs pretest 25.0.93

[Achim Gratz]

Michael Heerdegen writes:
> FWIW, I once saw this while calling "make" for Helm.  I investigated and
> saw such a "t" timestamp in the loaddefs file.  I didn't think long
> about it.  I just deleted that loaddefs file - after that, "make"
> succeeded, and instead of "t" there was a "real" time stamp.

Just like you, the removal of the existing autoload files made the build
succeed again.  The reason for why there was no proper timestamp on
these entries was that during my last build on 3rd of April I built also
an EMacs from master and that build destroys trhe time-stamps that
emacs-25 so desperately needs.  Really, if there's something wrong with
a file the build can re-create, it should not error out.  Plus, there
really needs to be some Makefile target to really clean up (no, 'make
distclean' didn't do it).  Plus, the fact that the lisp directory is
shared between different builds and doesn't contain just the sources
doesn't really help, either.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

Re: [emacs-announce] Emacs pretest 25.0.93

[Michael Heerdegen]

Achim Gratz <Stromeko@nexgo.de> writes:

> The reason for why there was no proper timestamp on these entries was
> that during my last build on 3rd of April I built also an EMacs from
> master [...]

Exactly the same story here.


Michael.

Re: Emacs pretest 25.0.93

[Glenn Morris]

Achim Gratz wrote:

> The reason for why there was no proper timestamp on these entries was
> that during my last build on 3rd of April I built also an EMacs from
> master and that build destroys trhe time-stamps that emacs-25 so
> desperately needs. Really, if there's something wrong with a file the
> build can re-create, it should not error out. Plus, there really needs
> to be some Makefile target to really clean up (no, 'make distclean'
> didn't do it). Plus, the fact that the lisp directory is shared
> between different builds and doesn't contain just the sources doesn't
> really help, either.

Ie, you switched in place from master to the release branch without
cleaning up first. You can't expect this to work. An older branch cannot
reliably clean-up for a newer branch.

Please take the emacs-announce keyword out of the subject (future
announcements should use Keyword: instead to avoid this), since this
whole chain is not an announcement. It's not even related to the
pretest, since you built from git, not the pretest.

Re: Emacs pretest 25.0.93

[Achim Gratz]

Glenn Morris writes:
> Ie, you switched in place from master to the release branch without
> cleaning up first. You can't expect this to work. An older branch cannot
> reliably clean-up for a newer branch.

If Emacs had proper out-of-tree build it would.  With the current state
of affairs it might be better not to pretend that out-of-tree builds are
supposed to work because they don't.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

Re: [emacs-announce] Emacs pretest 25.0.93

[Eli Zaretskii]

> From: Michael Heerdegen <michael_heerdegen@web.de>
> Date: Sat, 23 Apr 2016 19:23:40 +0200
> 
> Achim Gratz <Stromeko@nexgo.de> writes:
> 
> > The reason for why there was no proper timestamp on these entries was
> > that during my last build on 3rd of April I built also an EMacs from
> > master [...]
> 
> Exactly the same story here.

IOW, you both build in the same directory from 2 different Git
branches, is that right?

Re: [emacs-announce] Emacs pretest 25.0.93

[Achim Gratz]

Eli Zaretskii writes:
> IOW, you both build in the same directory from 2 different Git
> branches, is that right?

No, I built emacs-25 in build-25 and master in build-master.  But it's
all for naught anyway because the build doesn't put all build products
into the build dirs.  You actually need to do a 'make extraclean', but
I'm rather going to build in-tree and use git-worktree instead, that
seems easier to me.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

Re: Emacs pretest 25.0.93

[Glenn Morris]

Anyway, sounds like using a dummy timestamp like (0 0 0 0) instead of t
might be better.

Re: [emacs-announce] Emacs pretest 25.0.93

[Michael Heerdegen]

Eli Zaretskii <eliz@gnu.org> writes:

> IOW, you both build in the same directory from 2 different Git
> branches, is that right?

I think so.  To make it clear: I had no problems with (building) Emacs
itself.

I had Helm build with master.  Then I switched to emacs-25 and tried to
upgrade Helm.  Helm's makefile calling `update-directory-autoloads' gave
the error.


Michael.

Re: [emacs-announce] Emacs pretest 25.0.93

[Eli Zaretskii]

> From: Michael Heerdegen <michael_heerdegen@web.de>
> Date: Sun, 24 Apr 2016 00:19:13 +0200
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > IOW, you both build in the same directory from 2 different Git
> > branches, is that right?
> 
> I think so.  To make it clear: I had no problems with (building) Emacs
> itself.
> 
> I had Helm build with master.  Then I switched to emacs-25 and tried to
> upgrade Helm.  Helm's makefile calling `update-directory-autoloads' gave
> the error.

I don't think this can be done reliably without completely cleaning
your Git clone (with Git commands), in addition to "make distclean"
etc.  Emacs branches diverge too quickly for this to work (like it
does with some other projects); it's why I use two separate directory
trees to track both branches simultaneously.

Re: Emacs pretest 25.0.93

[Achim Gratz]

Eli Zaretskii writes:
> I don't think this can be done reliably without completely cleaning
> your Git clone (with Git commands), in addition to "make distclean"
> etc.

No, you can't do that since .gitignore tells Fit to leave those files
alone. As I said before, the only command that removes those files is
"make extraclean".

> Emacs branches diverge too quickly for this to work (like it
> does with some other projects); it's why I use two separate directory
> trees to track both branches simultaneously.

Yes, that's what I'm using now and what I'd recommend to anyone with a
new enough Git to have "git worktree".  Don't bother with out-of-tree
builds, they just don't work the way you would expect them to.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

Re: Emacs pretest 25.0.93

[Phillip Lord]

I've build the windows binaries for this pre-test.

One think I notice is that the splash screen is now in italics. Was this
deliberate?

Phil

Re: Emacs pretest 25.0.93

[Eli Zaretskii]

> From: phillip.lord@russet.org.uk (Phillip Lord)
> Date: Mon, 25 Apr 2016 11:09:12 +0100
> 
> I've build the windows binaries for this pre-test.

Thanks.

> One think I notice is that the splash screen is now in italics.

It isn't here.  Can you show a screenshot?

Re: Emacs pretest 25.0.93

[Chris Zheng]

[-- Attachment #1.1: Type: text/plain, Size: 424 bytes --]

Hi Eli,

The attached is the screenshot running with `emacs -Q'.



On Mon, Apr 25, 2016 at 6:21 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: phillip.lord@russet.org.uk (Phillip Lord)
> > Date: Mon, 25 Apr 2016 11:09:12 +0100
> >
> > I've build the windows binaries for this pre-test.
>
> Thanks.
>
> > One think I notice is that the splash screen is now in italics.
>
> It isn't here.  Can you show a screenshot?
>
>

[-- Attachment #1.2: Type: text/html, Size: 904 bytes --]

[-- Attachment #2: splash.png --]
[-- Type: image/png, Size: 61040 bytes --]

Re: Emacs pretest 25.0.93

[Phillip Lord]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: phillip.lord@russet.org.uk (Phillip Lord)
>> Date: Mon, 25 Apr 2016 11:09:12 +0100
>> 
>> I've build the windows binaries for this pre-test.
>
> Thanks.
>
>> One think I notice is that the splash screen is now in italics.
>
> It isn't here.  Can you show a screenshot?

Do you mean, your build isn't in italics, or my build isn't in italics?

The screen by Chris is exactly what I am getting. I don't see the same
thing with previous pretests.

Phil

Re: Emacs pretest 25.0.93

[Eli Zaretskii]

> Date: Mon, 25 Apr 2016 21:25:59 +0800
> From: Chris Zheng <chriszheng99@gmail.com>
> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> 
> The attached is the screenshot running with `emacs -Q'.

Unbelievable!

AFAICT, the font used is actually bold-italic, not just italic, right?
When you click S-mouse-1 and select "Change Buffer Font" from the menu
that pops up, which font is shown as the current one?

Anyway, I have no idea what could cause this, it certainly doesn't
happen to me with the binary of the same tarball I built myself.  Does
anyone else see that with 25.0.93 pretest (or the latest emacs-25
branch)?  If not, I guess Phillip will have to see how this build was
different from the previous one he did.

Thanks.

Re: Emacs pretest 25.0.93

[Eli Zaretskii]

> From: phillip.lord@russet.org.uk (Phillip Lord)
> Cc: emacs-devel@gnu.org
> Date: Mon, 25 Apr 2016 23:30:39 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: phillip.lord@russet.org.uk (Phillip Lord)
> >> Date: Mon, 25 Apr 2016 11:09:12 +0100
> >> 
> >> I've build the windows binaries for this pre-test.
> >
> > Thanks.
> >
> >> One think I notice is that the splash screen is now in italics.
> >
> > It isn't here.  Can you show a screenshot?
> 
> Do you mean, your build isn't in italics, or my build isn't in italics?

The former, of course.

> The screen by Chris is exactly what I am getting. I don't see the same
> thing with previous pretests.

And I don't see this with the current pretest (or any of the previous
ones), and not with the current emacs-25 branch.  It is something in
the way you built this pretest, I presume.  Or maybe I'm missing
something.

Re: Emacs pretest 25.0.93

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

In the *About GNU Emacs* buffer (C-h C-a), I see those bold italics from
Chris Zheng's build (as he sees the same too, of course).
I don't see that on my latest build of emacs-25 as of yesterday on RHEL 6.6.

On Tue, Apr 26, 2016 at 9:43 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: phillip.lord@russet.org.uk (Phillip Lord)
> > Cc: emacs-devel@gnu.org
> > Date: Mon, 25 Apr 2016 23:30:39 +0100
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > >> From: phillip.lord@russet.org.uk (Phillip Lord)
> > >> Date: Mon, 25 Apr 2016 11:09:12 +0100
> > >>
> > >> I've build the windows binaries for this pre-test.
> > >
> > > Thanks.
> > >
> > >> One think I notice is that the splash screen is now in italics.
> > >
> > > It isn't here.  Can you show a screenshot?
> >
> > Do you mean, your build isn't in italics, or my build isn't in italics?
>
> The former, of course.
>
> > The screen by Chris is exactly what I am getting. I don't see the same
> > thing with previous pretests.
>
> And I don't see this with the current pretest (or any of the previous
> ones), and not with the current emacs-25 branch.  It is something in
> the way you built this pretest, I presume.  Or maybe I'm missing
> something.
>
> --

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1999 bytes --]

Re: Emacs pretest 25.0.93

[Phillip Lord]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Mon, 25 Apr 2016 21:25:59 +0800
>> From: Chris Zheng <chriszheng99@gmail.com>
>> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
>> 
>> The attached is the screenshot running with `emacs -Q'.
>
> Unbelievable!
>
> AFAICT, the font used is actually bold-italic, not just italic, right?
> When you click S-mouse-1 and select "Change Buffer Font" from the menu
> that pops up, which font is shown as the current one?
>
> Anyway, I have no idea what could cause this, it certainly doesn't
> happen to me with the binary of the same tarball I built myself.  Does
> anyone else see that with 25.0.93 pretest (or the latest emacs-25
> branch)?  If not, I guess Phillip will have to see how this build was
> different from the previous one he did.

AFAICT, I did nothing different.

I had a go at bisecting this, and the results are so surprising, that I
need to replicate them on a different machine....


git bisect start
# bad: [5c587fdff164e8b90beb47f6da64b4884290e40a] Bump version to 25.0.93
git bisect bad 5c587fdff164e8b90beb47f6da64b4884290e40a
# good: [6287381da495ac5cc2a2a4acb7f49825677a44c8] ; Auto-commit of loaddefs files.
git bisect good 6287381da495ac5cc2a2a4acb7f49825677a44c8
# bad: [45577d548d3abfe504d3f936b3c9b997d0cf7f9c] Avoid GTK 3 crash with icons and masks
git bisect bad 45577d548d3abfe504d3f936b3c9b997d0cf7f9c
# good: [26b56dc739460bfd35bd12b4aca7434d381d9ef5] Fix some single quotes in documentation
git bisect good 26b56dc739460bfd35bd12b4aca7434d381d9ef5
# good: [9094304a9c109495bf2212a713df1b07270d15cd] * lisp/progmodes/xref.el (xref-buffer-name, xref--window): Move definitions before use.
git bisect good 9094304a9c109495bf2212a713df1b07270d15cd
# good: [d8b2ce5f8a6a849e55b48699dfa0e769a4b9a3f6] Ignore invalid base64 encoded embedded images
git bisect good d8b2ce5f8a6a849e55b48699dfa0e769a4b9a3f6
# good: [c0165ea4d6ecf81db6728782c7322c311ee0a783] Resurrect GNUS-NEWS autogeneration
git bisect good c0165ea4d6ecf81db6728782c7322c311ee0a783
# bad: [7eba90c12227d86636aaa3da8d68b0c213fb3910] Improve font selection by family on MS-Windows
git bisect bad 7eba90c12227d86636aaa3da8d68b0c213fb3910
# good: [9524ec5e4e3c7c3036f2640b2595d3755894c1b3] Ignore more merges when generating ChangeLog
git bisect good 9524ec5e4e3c7c3036f2640b2595d3755894c1b3
# bad: [73d213f2816876fe9c6c429e75a3be5454a42b34] Comint, term, and compile now set EMACS
git bisect bad 73d213f2816876fe9c6c429e75a3be5454a42b34
# first bad commit: [73d213f2816876fe9c6c429e75a3be5454a42b34] Comint, term, and compile now set EMACS


So, it's *that* commit again, setting EMACS=t. And here is the irony;
that commit has largely been reverted on current emacs-25.

I probably wont be able to test this on another machine today, so, I'm
sending this in case anyone has time to try the last two commits in the
bisect.

Phil

Re: Emacs pretest 25.0.93

[Eli Zaretskii]

> From: phillip.lord@russet.org.uk (Phillip Lord)
> Cc: Chris Zheng <chriszheng99@gmail.com>,  emacs-devel@gnu.org
> Date: Tue, 26 Apr 2016 17:49:45 +0100
> 
> I had a go at bisecting this, and the results are so surprising, that I
> need to replicate them on a different machine....

I don't know what happened with your bisecting, because the culprit is
indeed 7eba90c12227d86636aaa3da8d68b0c213fb3910.  What happens is that
the variable-pitch face picks up a bold-italic font.  This is why
tooltips also display in that font: they use variable-pitch.

The strange thing is, I cannot see the problem on my main development
system. only on another box.  Maybe it has something to do with font
setup, I don't know.

I cannot just revert that commit, because it fixed a problem that is
no less serious.  Ideas welcome.

Re: Emacs pretest 25.0.93

[Phillip Lord]

On Tue, April 26, 2016 6:26 pm, Eli Zaretskii wrote:
>> From: phillip.lord@russet.org.uk (Phillip Lord)
>> Cc: Chris Zheng <chriszheng99@gmail.com>,  emacs-devel@gnu.org
>> Date: Tue, 26 Apr 2016 17:49:45 +0100
>>
>>
>> I had a go at bisecting this, and the results are so surprising, that I
>>  need to replicate them on a different machine....
>
> I don't know what happened with your bisecting, because the culprit is
> indeed 7eba90c12227d86636aaa3da8d68b0c213fb3910.

I'm terrible at manual bisects:-)

Ah, well, I thought my result was odd indeed.

Re: Emacs pretest 25.0.93

[Eli Zaretskii]

> Date: Tue, 26 Apr 2016 20:26:41 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: chriszheng99@gmail.com, emacs-devel@gnu.org
> 
> I cannot just revert that commit, because it fixed a problem that is
> no less serious.  Ideas welcome.

Could people who are affected please try this kludgey workaround, and
see if it gives good results?  Thanks.

(Of course, if someone has got a better idea, please speak up.)

diff --git a/lisp/faces.el b/lisp/faces.el
index 612bd16..3d3adaa 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -2281,7 +2281,9 @@ fixed-pitch
   :group 'basic-faces)
 
 (defface variable-pitch
-  '((t :family "Sans Serif"))
+  '((((type w32))
+     :font "-outline-Arial-normal-normal-normal-sans-*-*-*-*-p-*-iso8859-1")
+    (t :family "Sans Serif"))
   "The basic variable-pitch face."
   :group 'basic-faces)
 

Re: Emacs pretest 25.0.93

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

I don't have the setup to build emacs on Windows. So I tried applying your
patch just to <emacs extracted dir>/share/emacs/25.0.93/lisp/faces.el,
recompiling faces.elc and restarting emacs. But the variable-pitch is still
"Sans Serif" family instead of being set to Arial.

On my windows, C-h v system-type gives windows-nt. So I replaced w32 with
windows-nt, recompiled faces.elc, restarted emacs, and still nothing
happened.

I am not sure I any of my previous emails were received, but FWIW, I cannot
figure out if edits to that faces.el are being effective on Windows, or if
that patch is working for me.

On Tue, Apr 26, 2016 at 2:30 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Tue, 26 Apr 2016 20:26:41 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: chriszheng99@gmail.com, emacs-devel@gnu.org
> >
> > I cannot just revert that commit, because it fixed a problem that is
> > no less serious.  Ideas welcome.
>
> Could people who are affected please try this kludgey workaround, and
> see if it gives good results?  Thanks.
>
> (Of course, if someone has got a better idea, please speak up.)
>
> diff --git a/lisp/faces.el b/lisp/faces.el
> index 612bd16..3d3adaa 100644
> --- a/lisp/faces.el
> +++ b/lisp/faces.el
> @@ -2281,7 +2281,9 @@ fixed-pitch
>    :group 'basic-faces)
>
>  (defface variable-pitch
> -  '((t :family "Sans Serif"))
> +  '((((type w32))
> +     :font
> "-outline-Arial-normal-normal-normal-sans-*-*-*-*-p-*-iso8859-1")
> +    (t :family "Sans Serif"))
>    "The basic variable-pitch face."
>    :group 'basic-faces)
>
>
> --

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 2281 bytes --]

Re: Emacs pretest 25.0.93

[Eli Zaretskii]

> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Tue, 26 Apr 2016 19:09:18 +0000
> Cc: emacs-devel@gnu.org
> 
> I don't have the setup to build emacs on Windows. So I tried applying your patch just to <emacs extracted
> dir>/share/emacs/25.0.93/lisp/faces.el, recompiling faces.elc and restarting emacs. But the variable-pitch is
> still "Sans Serif" family instead of being set to Arial. 

No, it's not Sans Serif, it's Arial, just the bold-italic variant of
it.  Try this:

  M-: (face-font 'variable-pitch) RET

What do you see?

> On my windows, C-h v system-type gives windows-nt. So I replaced w32 with windows-nt, recompiled
> faces.elc, restarted emacs, and still nothing happened.

faces is preloaded, so it's not enough to recompile it.  And w32 is
correct, since it should name the frame type (a.k.a. 'window-system')
value, not the system type.

> I am not sure I any of my previous emails were received, but FWIW, I cannot figure out if edits to that faces.el
> are being effective on Windows, or if that patch is working for me.

You need to dump Emacs after byte-compiling faces.el.

Re: Emacs pretest 25.0.93

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

>
> No, it's not Sans Serif, it's Arial, just the bold-italic variant of
> it.  Try this:
>
>   M-: (face-font 'variable-pitch) RET
>
> What do you see?
>

Correct, variable-pitch face is set to bold-italic variant of Arial; I get

"-outline-Arial-bold-italic-normal-sans-17-*-*-*-p-*-ascii-0"

I tried applying your patch but that was futile (I get the same result) as
I cannot build emacs on Windows.

faces is preloaded, so it's not enough to recompile it.  And w32 is
> correct, since it should name the frame type (a.k.a. 'window-system')
> value, not the system type.
>


> You need to dump Emacs after byte-compiling faces.el.
>

Thanks for that info. Some one who can build emacs on Windows should be
then able to verify the patch.
-- 

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1391 bytes --]

Re: Emacs pretest 25.0.93

[Stephen Leake]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Tue, 26 Apr 2016 20:26:41 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: chriszheng99@gmail.com, emacs-devel@gnu.org
>> 
>> I cannot just revert that commit, because it fixed a problem that is
>> no less serious.  Ideas welcome.
>
> Could people who are affected please try this kludgey workaround, and
> see if it gives good results?  Thanks.

Fixes the problem for me, for both splash screen and tooltips.

>
>
> (Of course, if someone has got a better idea, please speak up.)
>
> diff --git a/lisp/faces.el b/lisp/faces.el
> index 612bd16..3d3adaa 100644
> --- a/lisp/faces.el
> +++ b/lisp/faces.el
> @@ -2281,7 +2281,9 @@ fixed-pitch
>    :group 'basic-faces)
>  
>  (defface variable-pitch
> -  '((t :family "Sans Serif"))
> +  '((((type w32))
> +     :font "-outline-Arial-normal-normal-normal-sans-*-*-*-*-p-*-iso8859-1")
> +    (t :family "Sans Serif"))
>    "The basic variable-pitch face."
>    :group 'basic-faces)
>  
>
>

-- 
-- Stephe

Re: Emacs pretest 25.0.93

[Eli Zaretskii]

> From: Stephen Leake <stephen_leake@stephe-leake.org>
> Cc: phillip.lord@russet.org.uk,  chriszheng99@gmail.com,  emacs-devel@gnu.org
> Date: Tue, 26 Apr 2016 14:32:38 -0500
> 
> > Could people who are affected please try this kludgey workaround, and
> > see if it gives good results?  Thanks.
> 
> Fixes the problem for me, for both splash screen and tooltips.

Thanks.

I will wait a few days for more feedback (and hopefully better ideas),
and commit after that, if nothing bad comes out.

Re: Emacs pretest 25.0.93

[Phillip Lord]

On Tue, April 26, 2016 8:40 pm, Eli Zaretskii wrote:
>> From: Stephen Leake <stephen_leake@stephe-leake.org>
>> Cc: phillip.lord@russet.org.uk,  chriszheng99@gmail.com,
>> emacs-devel@gnu.org Date: Tue, 26 Apr 2016 14:32:38 -0500
>>
>>
>>> Could people who are affected please try this kludgey workaround, and
>>>  see if it gives good results?  Thanks.
>>
>> Fixes the problem for me, for both splash screen and tooltips.
>>
>
> Thanks.
>
>
> I will wait a few days for more feedback (and hopefully better ideas),
> and commit after that, if nothing bad comes out.


Also, it works for me.

Re: Emacs pretest 25.0.93

[Eli Zaretskii]

> Date: Tue, 26 Apr 2016 23:32:45 +0100
> From: "Phillip Lord" <phillip.lord@russet.org.uk>
> Cc: "Stephen Leake" <stephen_leake@stephe-leake.org>,
>  chriszheng99@gmail.com,
>  emacs-devel@gnu.org,
>  phillip.lord@russet.org.uk
> 
> > I will wait a few days for more feedback (and hopefully better ideas),
> > and commit after that, if nothing bad comes out.
> 
> Also, it works for me.

Thanks.

Re: Emacs pretest 25.0.93

[Eli Zaretskii]

> Date: Tue, 26 Apr 2016 22:40:11 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: chriszheng99@gmail.com, emacs-devel@gnu.org, phillip.lord@russet.org.uk
> 
> > From: Stephen Leake <stephen_leake@stephe-leake.org>
> > Cc: phillip.lord@russet.org.uk,  chriszheng99@gmail.com,  emacs-devel@gnu.org
> > Date: Tue, 26 Apr 2016 14:32:38 -0500
> > 
> > > Could people who are affected please try this kludgey workaround, and
> > > see if it gives good results?  Thanks.
> > 
> > Fixes the problem for me, for both splash screen and tooltips.
> 
> Thanks.
> 
> I will wait a few days for more feedback (and hopefully better ideas),
> and commit after that, if nothing bad comes out.

Done.