Re: Moving kbd to subr.el

[Eli Zaretskii <eliz@gnu.org>]

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Wed, 13 Oct 2021 14:50:12 +0200
> Cc: Lars Ingebrigtsen <larsi@gnus.org>, Emacs developers <emacs-devel@gnu.org>
> > > -  (should (equal (kbd "C-x a") "\C-xa"))
> > > +
> > > +  ;; Modifiers.
> > > +  (should (equal (kbd "C-x a") "\^Xa"))
> > > +  (should (equal (kbd "M-x a") [134217848 97]))
> > > +  (should (equal (kbd "H-x a") [16777336 97]))
> > > +  (should (equal (kbd "s-x a") [8388728 97]))
> > > +  (should (equal (kbd "S-x a") [33554552 97]))
> >
> > Isn't this a bit ad-hoc?  E.g., why did you change the "C-x a" result?
> 
> I don't think I see what has changed.  This is what I get in Emacs 27.2:
> 
>     (kbd "C-x a")
>     " ^Xa"

I didn't say anything has changed, I asked why you didn't leave the
original "C-x a" intact.

> If I did my job right, nothing will have changed as this should just
> be a straight conversion from CL-Lib to ELisp.  I might have made a
> mistake somewhere, of course, and as I said I didn't look it over for
> correctness in much detail yet.

Precisely because there could be mistakes, we should not adapt what
should happen to what did happen, we should keep the previous results
where we had them.