From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Wed, 13 Oct 2021 16:28:31 +0300 Message-ID: <83h7dlnjeo.fsf@gnu.org> References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <20211004081727.4F24921048@vcs0.savannah.gnu.org> <871r4qcs8s.fsf@gnus.org> <87o87ubcnl.fsf@gnus.org> <87h7dm9en7.fsf@gnus.org> <87czoa9e7p.fsf@gnus.org> <878ryxakv9.fsf@gnus.org> <831r4pp0ms.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15905"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 13 15:29:23 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maeJu-0003xM-FG for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 15:29:22 +0200 Original-Received: from localhost ([::1]:48604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maeJt-0004nA-77 for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 09:29:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maeJA-0003hs-Sx for emacs-devel@gnu.org; Wed, 13 Oct 2021 09:28:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60152) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maeJA-000341-Jq; Wed, 13 Oct 2021 09:28:36 -0400 Original-Received: from [87.69.77.57] (port=3061 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maeJ9-0007dG-Rl; Wed, 13 Oct 2021 09:28:36 -0400 In-Reply-To: (message from Stefan Kangas on Wed, 13 Oct 2021 14:50:12 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276897 Archived-At: > From: Stefan Kangas > Date: Wed, 13 Oct 2021 14:50:12 +0200 > Cc: Lars Ingebrigtsen , Emacs developers > > > - (should (equal (kbd "C-x a") "\C-xa")) > > > + > > > + ;; Modifiers. > > > + (should (equal (kbd "C-x a") "\^Xa")) > > > + (should (equal (kbd "M-x a") [134217848 97])) > > > + (should (equal (kbd "H-x a") [16777336 97])) > > > + (should (equal (kbd "s-x a") [8388728 97])) > > > + (should (equal (kbd "S-x a") [33554552 97])) > > > > Isn't this a bit ad-hoc? E.g., why did you change the "C-x a" result? > > I don't think I see what has changed. This is what I get in Emacs 27.2: > > (kbd "C-x a") > " ^Xa" I didn't say anything has changed, I asked why you didn't leave the original "C-x a" intact. > If I did my job right, nothing will have changed as this should just > be a straight conversion from CL-Lib to ELisp. I might have made a > mistake somewhere, of course, and as I said I didn't look it over for > correctness in much detail yet. Precisely because there could be mistakes, we should not adapt what should happen to what did happen, we should keep the previous results where we had them.