From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [GNU ELPA] eglot-x.el: Protocol extensions for Eglot Date: Fri, 05 May 2023 16:26:18 +0300 Message-ID: <83h6sqj4ed.fsf@gnu.org> References: <874jorc7q2.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40792"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, joaotavora@gmail.com To: Felician Nemeth Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 05 15:26:42 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puvSM-000ANE-8p for ged-emacs-devel@m.gmane-mx.org; Fri, 05 May 2023 15:26:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puvRo-0006JM-4c; Fri, 05 May 2023 09:26:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puvRf-0006Aq-Sz for emacs-devel@gnu.org; Fri, 05 May 2023 09:26:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puvRe-0000MI-HM; Fri, 05 May 2023 09:25:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=5ShkPSCb96138rX4CsOairqgG+Bx5a7D09knzgb3/Y8=; b=GUprhOIrwOiwzbPzKLgN slJgD9dsdCehny+m5WvKqw4YvuBHZBMagAuR+XThYIHWVB7Q0G+9hBwMtxHIdUwZoHD1jSZxQHm8f 90I36QbkTm0kJfim2Vbemoyy+BH/itToPpJrJ4cdmkghuKV3cMPayFM1hZqtkxhAhK0VoqZ7UP5Vg 5O0qSf6Fy9vjXIOm8I9mfuEPPt2fbtTetbaAaFE4CrKc3+yDQu6YAft/UGP3pz9WbI1egI0GNxycc 7B5pWLSHdlDzvVnvuuSrFUL8Ml9c7Qoa0W+rkc42/t5Ii6suL3NpkgcwVlJPqEfuLhrQGV5s6eXwD pEPsf47KpIpjAg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puvR6-0000I8-8P; Fri, 05 May 2023 09:25:39 -0400 In-Reply-To: <874jorc7q2.fsf@betli.tmit.bme.hu> (message from Felician Nemeth on Fri, 05 May 2023 13:56:21 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305877 Archived-At: > From: Felician Nemeth > Cc: João Távora > Date: Fri, 05 May 2023 13:56:21 +0200 > > I'd like to submit a new package called eglot-x to ELPA. Its commentary > starts with: > > ;; Eglot supports (a subset of) the Language Server Protocol. However, > ;; there are useful protocol extensions that are not part of the > ;; official protocol specification. Eglot-x adds support for some of > ;; them. If you find a bug in Eglot, please, try to reproduce it > ;; without Eglot-x, because Eglot-x is substantially modifies Eglot's > ;; normal behavior as well. > > João intend to support only the standardized protocol features in > eglot.el, but lots of LSP servers extend the protocol in their own way. > (It was João who suggested the package name long ago.) I considered > eglot-x just an experiment and a learning possibility, but people seem > to use it, so I'd like to make their life easier by this submission. It sounds strange to me to refuse to support LSP extensions in eglot.el. At the very least, eglot.el could benefit from offering a supported mechanism for adding such extensions; there should be no need for using advice for that. João, why would you not consider supporting these extensions as part of eglot.el?