* Re: master 1773679: Ensure that sentinels are called during 'accept-process-output'.
@ 2021-01-17 14:39 Eli Zaretskii
2021-01-18 10:41 ` Philipp Stephani
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2021-01-17 14:39 UTC (permalink / raw)
To: Philipp Stephani; +Cc: emacs-devel
branch: master
commit 1773679af3241919a85d6174b1554070a63cca79
Author: Philipp Stephani <phst@google.com>
Commit: Philipp Stephani <phst@google.com>
Ensure that sentinels are called during 'accept-process-output'.
When we're trying to notify a process about a status change, we need
to ignore the SIGCHLD pipe temporarily, otherwise the code would
likely not run into the timeout case that's necessary for a status
change to happen.
* src/process.c (wait_reading_process_output): Ignore the SIGCHLD pipe
when notifying a process about a status change.
* test/src/process-tests.el (process-tests/sentinel-called)
(process-tests/sentinel-with-multiple-processes): New unit tests.
Why do these new tests have to rely on Bash and on a particular
variety of 'echo'? Can't you use (another instance of) Emacs instead?
That would allow to be able to run these tests on more platforms.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: master 1773679: Ensure that sentinels are called during 'accept-process-output'.
2021-01-17 14:39 master 1773679: Ensure that sentinels are called during 'accept-process-output' Eli Zaretskii
@ 2021-01-18 10:41 ` Philipp Stephani
2021-01-18 16:45 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Philipp Stephani @ 2021-01-18 10:41 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Emacs developers
Am So., 17. Jan. 2021 um 15:39 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
> Why do these new tests have to rely on Bash and on a particular
> variety of 'echo'? Can't you use (another instance of) Emacs instead?
> That would allow to be able to run these tests on more platforms.
Yeah, that's a fair point, I've now did that with commit
3b4050154e3f72c06501cd9a5ad83841b92c7bd6.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 1773679: Ensure that sentinels are called during 'accept-process-output'.
2021-01-18 10:41 ` Philipp Stephani
@ 2021-01-18 16:45 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2021-01-18 16:45 UTC (permalink / raw)
To: Philipp Stephani; +Cc: emacs-devel
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Mon, 18 Jan 2021 11:41:40 +0100
> Cc: Emacs developers <emacs-devel@gnu.org>
>
> Am So., 17. Jan. 2021 um 15:39 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > Why do these new tests have to rely on Bash and on a particular
> > variety of 'echo'? Can't you use (another instance of) Emacs instead?
> > That would allow to be able to run these tests on more platforms.
>
> Yeah, that's a fair point, I've now did that with commit
> 3b4050154e3f72c06501cd9a5ad83841b92c7bd6.
Thanks, I've now verified that these tests run on MS-Windows and pass.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-18 16:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-17 14:39 master 1773679: Ensure that sentinels are called during 'accept-process-output' Eli Zaretskii
2021-01-18 10:41 ` Philipp Stephani
2021-01-18 16:45 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).