From: Eli Zaretskii <eliz@gnu.org>
To: p.stephani2@gmail.com (Philipp Stephani)
Cc: emacs-devel@gnu.org
Subject: Re: master 1773679: Ensure that sentinels are called during 'accept-process-output'.
Date: Sun, 17 Jan 2021 16:39:24 +0200 [thread overview]
Message-ID: <83lfcr8w6b.fsf@gnu.org> (raw)
branch: master
commit 1773679af3241919a85d6174b1554070a63cca79
Author: Philipp Stephani <phst@google.com>
Commit: Philipp Stephani <phst@google.com>
Ensure that sentinels are called during 'accept-process-output'.
When we're trying to notify a process about a status change, we need
to ignore the SIGCHLD pipe temporarily, otherwise the code would
likely not run into the timeout case that's necessary for a status
change to happen.
* src/process.c (wait_reading_process_output): Ignore the SIGCHLD pipe
when notifying a process about a status change.
* test/src/process-tests.el (process-tests/sentinel-called)
(process-tests/sentinel-with-multiple-processes): New unit tests.
Why do these new tests have to rely on Bash and on a particular
variety of 'echo'? Can't you use (another instance of) Emacs instead?
That would allow to be able to run these tests on more platforms.
Thanks.
next reply other threads:[~2021-01-17 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 14:39 Eli Zaretskii [this message]
2021-01-18 10:41 ` master 1773679: Ensure that sentinels are called during 'accept-process-output' Philipp Stephani
2021-01-18 16:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lfcr8w6b.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).