From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 1773679: Ensure that sentinels are called during 'accept-process-output'. Date: Sun, 17 Jan 2021 16:39:24 +0200 Message-ID: <83lfcr8w6b.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8183"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: p.stephani2@gmail.com (Philipp Stephani) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 17 15:39:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l19DZ-00023a-Fi for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Jan 2021 15:39:49 +0100 Original-Received: from localhost ([::1]:49296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l19DY-0002c0-I3 for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Jan 2021 09:39:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l19D7-0002DA-7o for emacs-devel@gnu.org; Sun, 17 Jan 2021 09:39:21 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37763) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l19D7-0005SJ-0U; Sun, 17 Jan 2021 09:39:21 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1826 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l19D6-0006VG-CM; Sun, 17 Jan 2021 09:39:20 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263124 Archived-At: branch: master commit 1773679af3241919a85d6174b1554070a63cca79 Author: Philipp Stephani Commit: Philipp Stephani Ensure that sentinels are called during 'accept-process-output'. When we're trying to notify a process about a status change, we need to ignore the SIGCHLD pipe temporarily, otherwise the code would likely not run into the timeout case that's necessary for a status change to happen. * src/process.c (wait_reading_process_output): Ignore the SIGCHLD pipe when notifying a process about a status change. * test/src/process-tests.el (process-tests/sentinel-called) (process-tests/sentinel-with-multiple-processes): New unit tests. Why do these new tests have to rely on Bash and on a particular variety of 'echo'? Can't you use (another instance of) Emacs instead? That would allow to be able to run these tests on more platforms. Thanks.