unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: Towards a cleaner build: select.el
Date: Sun, 16 Jun 2019 19:19:33 +0300	[thread overview]
Message-ID: <83ef3tv6y2.fsf@gnu.org> (raw)
In-Reply-To: <m3v9x56133.fsf_-_@gnus.org> (message from Lars Ingebrigtsen on Sun, 16 Jun 2019 16:45:20 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Sun, 16 Jun 2019 16:45:20 +0200
> 
> In xselect--encode-string:
> select.el:482:24:Warning: `string-make-unibyte' is an obsolete function (as of
>     26.1); use `encode-coding-string'.
> 
> It's this code:
> 
> 	   ((eq type 'C_STRING)
>             ;; If STR is unibyte (the normal case), use it; otherwise
>             ;; we assume some of the characters are eight-bit, and
>             ;; take their lower 8 bits.
> 	    (setq str (string-make-unibyte str)))
> 
> Stefan suggested, I think, that we should just use string-to-unibyte
> here.  Eli, do you agree?

Sorry, no, at least not yet.  I still cannot wrap my head around that
code, and Kenichi Handa didn't respond to my questions.  Please leave
this alone for now, it's still on my todo.



  parent reply	other threads:[~2019-06-16 16:19 UTC|newest]

Thread overview: 300+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17  2:15 Towards a cleaner build Lars Ingebrigtsen
2019-05-17  2:33 ` Lars Ingebrigtsen
2019-05-17 18:38   ` Stefan Monnier
2019-05-17  2:50 ` Lars Ingebrigtsen
2019-05-18  8:33   ` Towards a cleaner build: epa-mail Lars Ingebrigtsen
2019-05-17  3:01 ` Towards a cleaner build Lars Ingebrigtsen
2019-05-17  4:14   ` Stefan Monnier
2019-05-17  4:21     ` Lars Ingebrigtsen
2019-05-17  3:06 ` Lars Ingebrigtsen
2019-05-17  4:18   ` Stefan Monnier
2019-05-17  4:29     ` Lars Ingebrigtsen
2019-05-17  5:50       ` Eli Zaretskii
2019-05-17  6:12         ` Lars Ingebrigtsen
2019-05-17  6:38           ` Lars Ingebrigtsen
2019-05-17  8:37           ` Eli Zaretskii
2019-05-17 10:05             ` Lars Ingebrigtsen
2019-05-17 11:25               ` Noam Postavsky
2019-05-17 11:34                 ` Lars Ingebrigtsen
2019-05-17 12:31                   ` Lars Ingebrigtsen
2019-05-17 12:39                     ` Lars Ingebrigtsen
2019-05-17 13:32                       ` Lars Ingebrigtsen
2019-05-17 13:41                         ` Lars Ingebrigtsen
2019-05-17 14:07                           ` Lars Ingebrigtsen
2019-05-17 14:37                             ` Lars Ingebrigtsen
2019-05-27 23:03                               ` Noam Postavsky
2019-05-28  9:49                                 ` Lars Ingebrigtsen
2019-05-28 11:22                                   ` Noam Postavsky
2019-05-28 11:26                                     ` Lars Ingebrigtsen
2019-05-28 11:36                                       ` Noam Postavsky
2019-05-28 11:39                                         ` Lars Ingebrigtsen
2019-05-28 12:29                                           ` Stefan Monnier
2019-05-28 15:07                                           ` Eli Zaretskii
2019-05-28 15:11                                             ` Lars Ingebrigtsen
2019-05-28 18:44                                               ` Eli Zaretskii
2019-05-29 11:19                                                 ` Lars Ingebrigtsen
2019-05-28 20:43                                               ` Noam Postavsky
2019-05-28 21:16                                                 ` Stefan Monnier
2019-05-29 11:17                                                 ` Lars Ingebrigtsen
2019-05-29 15:48                                                   ` Stefan Monnier
2019-05-29 23:12                                                     ` Lars Ingebrigtsen
2019-06-09 13:48                                                     ` Lars Ingebrigtsen
2019-06-09 14:53                                                       ` Lars Ingebrigtsen
2019-06-09 15:02                                                         ` Noam Postavsky
2019-06-09 15:50                                                           ` Lars Ingebrigtsen
2019-06-09 18:33                                                             ` Stefan Monnier
2019-06-09 19:12                                                               ` Lars Ingebrigtsen
2019-06-09 20:09                                                                 ` Lars Ingebrigtsen
2019-06-11 14:53                                                                   ` Eli Zaretskii
2019-06-12 14:01                                                                     ` Lars Ingebrigtsen
2019-06-12 16:37                                                                       ` Lars Ingebrigtsen
2019-06-12 22:07                                                                         ` Stefan Monnier
2019-06-13  0:06                                                                           ` Lars Ingebrigtsen
2019-06-13  7:57                                                                             ` Stefan Monnier
2019-06-13 12:04                                                                             ` Lars Ingebrigtsen
2019-06-13 12:09                                                                               ` Lars Ingebrigtsen
2019-06-13 12:44                                                                                 ` Towards a cleaner build: rmailmm Lars Ingebrigtsen
2019-06-13 22:15                                                                                   ` Stefan Monnier
2019-06-14  7:23                                                                                     ` Eli Zaretskii
2019-06-14  9:57                                                                                       ` Stefan Monnier
2019-06-14 11:45                                                                                       ` Lars Ingebrigtsen
2019-06-13 13:40                                                                                 ` Towards a cleaner build: eieio Lars Ingebrigtsen
2019-06-13 16:13                                                                                   ` Stefan Monnier
2019-06-14 12:11                                                                                     ` Lars Ingebrigtsen
2019-06-14 13:52                                                                                       ` Stefan Monnier
2019-06-14 14:06                                                                                         ` Lars Ingebrigtsen
2019-06-14 19:13                                                                                           ` Stefan Monnier
2019-06-15 12:46                                                                                             ` Lars Ingebrigtsen
2019-06-15 14:04                                                                                               ` Towards a cleaner build: bindat Lars Ingebrigtsen
2019-06-15 14:22                                                                                                 ` Eli Zaretskii
2019-06-15 14:34                                                                                                   ` Lars Ingebrigtsen
2019-06-15 14:50                                                                                                     ` Lars Ingebrigtsen
2019-06-15 14:56                                                                                                       ` Eli Zaretskii
2019-06-15 15:28                                                                                                         ` Towards a cleaner build: feedmail Lars Ingebrigtsen
2019-06-15 15:30                                                                                                           ` Eli Zaretskii
2019-06-15 15:42                                                                                                             ` Lars Ingebrigtsen
2019-06-15 16:11                                                                                                               ` Towards a cleaner build: tags Lars Ingebrigtsen
2019-06-15 16:33                                                                                                                 ` Towards a cleaner build: srecode/insert Lars Ingebrigtsen
2019-06-16 14:19                                                                                                                   ` Eric Ludlam
2019-06-16 14:25                                                                                                                     ` Lars Ingebrigtsen
2019-06-16  0:30                                                                                                                 ` Towards a cleaner build: tags Dmitry Gutov
2019-06-16 13:20                                                                                                                   ` Lars Ingebrigtsen
2019-06-16 14:45                                                                                                                     ` Towards a cleaner build: select.el Lars Ingebrigtsen
2019-06-16 15:31                                                                                                                       ` Towards a cleaner build: calc.el Lars Ingebrigtsen
2019-06-16 15:55                                                                                                                         ` Lars Ingebrigtsen
2019-06-16 16:23                                                                                                                           ` Noam Postavsky
2019-06-16 17:03                                                                                                                             ` Lars Ingebrigtsen
2019-06-16 17:28                                                                                                                         ` Lars Ingebrigtsen
2019-06-16 21:51                                                                                                                         ` Stefan Monnier
2019-06-16 22:00                                                                                                                           ` Lars Ingebrigtsen
2019-06-17 10:47                                                                                                                             ` Lars Ingebrigtsen
2019-06-17 11:03                                                                                                                               ` Mattias Engdegård
2019-06-16 16:19                                                                                                                       ` Eli Zaretskii [this message]
2019-06-16 16:43                                                                                                                         ` Towards a cleaner build: select.el Lars Ingebrigtsen
2019-06-18 13:44                                                                                                                     ` Towards a cleaner build: tags Dmitry Gutov
2019-06-19 13:18                                                                                                                       ` Lars Ingebrigtsen
2019-06-20 12:00                                                                                                                         ` Lars Ingebrigtsen
2019-06-20 12:02                                                                                                                           ` Dmitry Gutov
2019-06-20 12:08                                                                                                                             ` Lars Ingebrigtsen
2019-06-20 12:04                                                                                                                         ` Dmitry Gutov
2019-06-20 12:09                                                                                                                           ` Lars Ingebrigtsen
2019-06-15 16:31                                                                                               ` Towards a cleaner build: eieio Stefan Monnier
2019-06-16 12:36                                                                                                 ` Lars Ingebrigtsen
2019-06-16 16:41                                                                                                   ` Lars Ingebrigtsen
2019-06-16 22:39                                                                                                     ` Stefan Monnier
2019-06-16 22:44                                                                                                       ` Lars Ingebrigtsen
2019-06-17  1:03                                                                                                         ` Stefan Monnier
2019-06-17  9:40                                                                                                           ` Lars Ingebrigtsen
2019-06-17  9:51                                                                                                             ` Lars Ingebrigtsen
2019-06-17 10:53                                                                                                               ` Lars Ingebrigtsen
2019-06-17 10:58                                                                                                                 ` Lars Ingebrigtsen
2019-06-13 13:50                                                                                 ` Towards a cleaner build: ieieo Lars Ingebrigtsen
2019-06-13 16:16                                                                                   ` Stefan Monnier
2019-06-14 12:13                                                                                     ` Lars Ingebrigtsen
2019-06-14 19:49                                                                                       ` Stefan Monnier
2019-06-15 12:38                                                                                         ` Lars Ingebrigtsen
2019-06-13 15:54                                                                                 ` string-to-multibyte and string-make-*byte (was: Towards a cleaner build) Stefan Monnier
2019-06-14 12:33                                                                                   ` string-to-multibyte and string-make-*byte Lars Ingebrigtsen
2019-06-17 12:08                                                                           ` Towards a cleaner build: pcomplete Lars Ingebrigtsen
2019-06-17 13:23                                                                             ` Stefan Monnier
2019-06-17 13:30                                                                             ` Lars Ingebrigtsen
2019-06-17 14:05                                                                               ` Towards a cleaner build: other output Lars Ingebrigtsen
2019-06-17 16:04                                                                                 ` Richard Stallman
2019-06-17 17:11                                                                                   ` Eli Zaretskii
2019-06-18  3:01                                                                                     ` Richard Stallman
2019-06-18  9:49                                                                                       ` Lars Ingebrigtsen
2019-06-18 12:30                                                                                         ` Stefan Monnier
2019-06-19  2:06                                                                                         ` Richard Stallman
2019-06-17 19:48                                                                                 ` Lars Ingebrigtsen
2019-06-17 19:56                                                                                 ` Lars Ingebrigtsen
2019-06-17 20:27                                                                                   ` Lars Ingebrigtsen
2019-06-17 20:29                                                                                     ` Lars Ingebrigtsen
2019-06-17 22:48                                                                                   ` Stefan Monnier
2019-06-17 23:02                                                                                     ` Lars Ingebrigtsen
2019-06-17 23:08                                                                                       ` Stefan Monnier
2019-06-17 23:27                                                                                         ` Lars Ingebrigtsen
2019-06-18  4:04                                                                                         ` Clément Pit-Claudel
2019-06-18 12:28                                                                                           ` Stefan Monnier
2019-06-18 12:35                                                                                             ` Lars Ingebrigtsen
2019-06-18 12:42                                                                                               ` Stefan Monnier
2019-06-18 13:36                                                                                                 ` Lars Ingebrigtsen
2019-06-18 14:05                                                                                                   ` Stefan Monnier
2019-06-19 12:53                                                                                                     ` Lars Ingebrigtsen
2019-06-19 13:33                                                                                                       ` Stefan Monnier
2019-06-20 11:40                                                                                                         ` Lars Ingebrigtsen
2019-06-20 12:02                                                                                                           ` Noam Postavsky
2019-06-20 12:09                                                                                                             ` Lars Ingebrigtsen
2019-06-20 13:08                                                                                                               ` Eli Zaretskii
2019-06-20 13:31                                                                                                                 ` Lars Ingebrigtsen
2019-06-20 13:23                                                                                                               ` Stefan Monnier
2019-06-20 14:19                                                                                                                 ` Lars Ingebrigtsen
2019-06-20 18:55                                                                                                                   ` Stefan Monnier
2019-06-21 10:44                                                                                                                     ` Lars Ingebrigtsen
2019-06-21 14:35                                                                                                                       ` Stefan Monnier
2019-06-20 12:24                                                                                                           ` Towards a cleaner build: done! Lars Ingebrigtsen
2019-06-20 13:22                                                                                                             ` Noam Postavsky
2019-06-20 13:31                                                                                                               ` Lars Ingebrigtsen
2019-06-22  8:37                                                                                                             ` Eli Zaretskii
2019-06-25 21:12                                                                                                             ` Arash Esbati
2019-06-25 21:25                                                                                                               ` Lars Ingebrigtsen
2019-06-18 15:41                                                                                           ` Towards a cleaner build: other output Eli Zaretskii
2019-06-17 22:40                                                                                 ` Stefan Monnier
2019-06-17 22:53                                                                                   ` Lars Ingebrigtsen
2019-06-18  9:56                                                                                   ` Lars Ingebrigtsen
2019-06-18 12:11                                                                                     ` Stefan Monnier
2019-06-18 13:38                                                                                       ` Lars Ingebrigtsen
2019-06-18 14:00                                                                                         ` Lars Ingebrigtsen
2019-06-18 14:09                                                                                           ` Stefan Monnier
2019-06-18 14:15                                                                                             ` Lars Ingebrigtsen
2019-06-12 23:21                                                                       ` Towards a cleaner build: viper-ex Lars Ingebrigtsen
2019-06-12 23:35                                                                         ` Towards a cleaner build: project.el Lars Ingebrigtsen
2019-06-12 23:55                                                                           ` Towards a cleaner build: obsolete/cl-compat.el Lars Ingebrigtsen
2019-06-13  0:04                                                                           ` Towards a cleaner build: erc.el Lars Ingebrigtsen
2019-06-13  0:18                                                                             ` Towards a cleaner build: calendar Lars Ingebrigtsen
2019-06-13  1:38                                                                               ` Towards a cleaner build: cedet Lars Ingebrigtsen
2019-06-13 14:44                                                                                 ` Lars Ingebrigtsen
2019-06-13 15:46                                                                                   ` Noam Postavsky
2019-06-13 15:56                                                                                     ` Lars Ingebrigtsen
2019-06-13 16:15                                                                                       ` Noam Postavsky
2019-06-13 16:19                                                                                         ` Lars Ingebrigtsen
2019-06-13 15:10                                                                                 ` Lars Ingebrigtsen
2019-06-13 16:23                                                                                   ` Lars Ingebrigtsen
2019-06-13 16:35                                                                                 ` Stefan Monnier
2019-06-14 12:16                                                                                   ` Lars Ingebrigtsen
2019-06-14 13:54                                                                                     ` Stefan Monnier
2019-06-14 14:10                                                                                       ` Lars Ingebrigtsen
2019-06-14 19:16                                                                                         ` Stefan Monnier
2019-06-15 12:46                                                                                           ` Lars Ingebrigtsen
2019-06-14 12:27                                                                                   ` Lars Ingebrigtsen
2019-06-14 13:22                                                                                     ` Lars Ingebrigtsen
2019-06-14 19:51                                                                                       ` Stefan Monnier
2019-06-14 20:05                                                                                       ` Dmitry Gutov
2019-06-15 12:41                                                                                         ` Lars Ingebrigtsen
2019-06-15 13:05                                                                                           ` Dmitry Gutov
2019-06-15 16:05                                                                                             ` Lars Ingebrigtsen
2019-06-15 20:14                                                                                               ` Dmitry Gutov
2019-06-15 22:58                                                                                   ` Eric Ludlam
2019-06-16 12:34                                                                                     ` Lars Ingebrigtsen
2019-06-14 14:30                                                                               ` Towards a cleaner build: calendar Lars Ingebrigtsen
2019-06-14 16:05                                                                                 ` Eli Zaretskii
2019-06-15 12:31                                                                                   ` Lars Ingebrigtsen
2019-06-13  0:27                                                                             ` Towards a cleaner build: disass.el Lars Ingebrigtsen
2019-06-13  3:43                                                                               ` Eli Zaretskii
2019-06-13 11:57                                                                                 ` Lars Ingebrigtsen
2019-06-13 16:23                                                                               ` Stefan Monnier
2019-06-13 16:21                                                                             ` Towards a cleaner build: erc.el Stefan Monnier
2019-06-14 11:49                                                                               ` Lars Ingebrigtsen
2019-06-13 12:55                                                                           ` Towards a cleaner build: project.el Dmitry Gutov
2019-06-13 12:58                                                                             ` Lars Ingebrigtsen
2019-06-13 13:10                                                                               ` Dmitry Gutov
2019-06-13 13:24                                                                                 ` Lars Ingebrigtsen
2019-06-13 16:30                                                                                   ` Towards a cleaner build: byte-run.el Lars Ingebrigtsen
2019-06-13 20:55                                                                                     ` Stefan Monnier
2019-06-14 11:24                                                                                       ` Lars Ingebrigtsen
2019-06-13  3:41                                                                         ` Towards a cleaner build: viper-ex Eli Zaretskii
2019-06-13 12:00                                                                           ` Lars Ingebrigtsen
2019-06-13 12:46                                                                             ` Eli Zaretskii
2019-06-13 12:47                                                                               ` Lars Ingebrigtsen
2019-06-13 12:51                                                                                 ` Eli Zaretskii
2019-06-13 12:52                                                                             ` Dmitry Gutov
2019-06-13 12:54                                                                               ` Lars Ingebrigtsen
2019-06-13 15:21                                                                                 ` Dmitry Gutov
2019-06-09 23:01                                                                 ` Towards a cleaner build Stefan Monnier
2019-06-10  8:44                                                                   ` Lars Ingebrigtsen
2019-06-10 13:36                                                                     ` Stefan Monnier
2019-06-09 17:26                                                         ` Andreas Schwab
2019-06-09 15:31                                                       ` Stefan Monnier
2019-06-09 15:40                                                       ` Lars Ingebrigtsen
2019-06-09 16:15                                                         ` Noam Postavsky
2019-06-09 16:24                                                           ` Lars Ingebrigtsen
2019-06-09 16:28                                                             ` Noam Postavsky
2019-06-09 16:44                                                               ` Lars Ingebrigtsen
2019-06-09 18:24                                                           ` Stefan Monnier
2019-06-09 19:08                                                             ` Lars Ingebrigtsen
2019-06-09 22:57                                                               ` Stefan Monnier
2019-06-09 16:31                                                         ` Lars Ingebrigtsen
2019-06-09 16:42                                                           ` Lars Ingebrigtsen
2019-06-09 18:18                                                             ` Lars Ingebrigtsen
2019-05-28 12:00                                     ` Stefan Monnier
2019-05-17 16:13                           ` Stefan Monnier
2019-05-18  5:02                             ` Lars Ingebrigtsen
2019-05-18 12:43                               ` Stefan Monnier
2019-05-18  5:18                             ` Lars Ingebrigtsen
2019-05-17 11:40                 ` Lars Ingebrigtsen
2019-05-17 12:28                   ` Stefan Monnier
2019-05-18  6:45                     ` Lars Ingebrigtsen
2019-05-17 12:06                 ` Eli Zaretskii
2019-05-17 12:33                 ` Stefan Monnier
2019-05-17  3:24 ` Drew Adams
2019-05-17  3:32 ` Lars Ingebrigtsen
2019-05-17  8:16   ` Eli Zaretskii
2019-05-17 10:24     ` Lars Ingebrigtsen
2019-05-17 11:43       ` Eli Zaretskii
2019-05-17  3:51 ` Lars Ingebrigtsen
2019-05-17  8:31   ` Eli Zaretskii
2019-05-17 10:13     ` Lars Ingebrigtsen
2019-05-17  5:44 ` Eli Zaretskii
2019-05-17  5:52   ` Lars Ingebrigtsen
2019-05-17  8:33     ` Eli Zaretskii
2019-05-17 10:19       ` Lars Ingebrigtsen
2019-05-17 11:41         ` Eli Zaretskii
2019-05-17 11:49           ` Lars Ingebrigtsen
2019-05-17 13:06           ` Stefan Monnier
2019-05-17 10:35 ` Towards a cleaner build: arc-mode Lars Ingebrigtsen
2019-05-17 12:01   ` Eli Zaretskii
2019-05-18  3:56     ` Lars Ingebrigtsen
2019-05-18  4:04       ` Lars Ingebrigtsen
2019-05-18  5:39         ` Eli Zaretskii
2019-05-18  6:04           ` Lars Ingebrigtsen
2019-05-18  7:50             ` Eli Zaretskii
2019-05-18  8:02               ` Lars Ingebrigtsen
2019-05-18  6:01       ` Eli Zaretskii
2019-05-18 12:59       ` Stefan Monnier
2019-05-18 13:17         ` Lars Ingebrigtsen
2019-05-18  4:21     ` Lars Ingebrigtsen
2019-05-18  4:31       ` Lars Ingebrigtsen
2019-05-18  6:03       ` Eli Zaretskii
2019-05-18  4:36     ` Lars Ingebrigtsen
2019-05-18  5:57       ` Eli Zaretskii
2019-05-18  6:00         ` Lars Ingebrigtsen
2019-05-19 16:36           ` Lars Ingebrigtsen
2019-05-19 17:03             ` Eli Zaretskii
2019-05-17 10:41 ` Towards a cleaner build: ehelp Lars Ingebrigtsen
2019-05-17 13:01   ` Stefan Monnier
2019-05-18  4:41     ` Lars Ingebrigtsen
2019-05-17 12:45 ` Towards a cleaner build: hexl Lars Ingebrigtsen
2019-05-17 12:49   ` Noam Postavsky
2019-05-17 13:26   ` Eli Zaretskii
2019-05-18  5:07     ` Lars Ingebrigtsen
2019-05-17 16:23   ` Stefan Monnier
2019-05-18  4:39     ` Lars Ingebrigtsen
2019-05-18  5:32 ` Towards a cleaner build: custom Lars Ingebrigtsen
2019-05-18  5:34 ` Towards a cleaner build: frameset Lars Ingebrigtsen
2019-05-18 12:56   ` Stefan Monnier
2019-05-28  9:50     ` Lars Ingebrigtsen
2019-05-28 13:06       ` Stefan Monnier
2019-05-28 13:22         ` Lars Ingebrigtsen
2019-05-28 13:27           ` Stefan Monnier
2019-05-18  8:42 ` Towards a cleaner build: epa-file Lars Ingebrigtsen
2019-05-18  9:13   ` Eli Zaretskii
2019-05-18  9:17     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ef3tv6y2.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).