From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Towards a cleaner build: select.el
Date: Sun, 16 Jun 2019 19:19:33 +0300
Message-ID: <83ef3tv6y2.fsf@gnu.org>
References: <m3r28xrfl9.fsf@gnus.org> <m3k1dpk7y7.fsf@gnus.org>
 <m3ftodk7ps.fsf@gnus.org> <m3blz1ioxz.fsf_-_@gnus.org>
 <jwv36kdsbw8.fsf-monnier+emacs@gnu.org> <m3pnngmko2.fsf@gnus.org>
 <jwvr27wwa0b.fsf-monnier+emacs@gnu.org> <m3v9x8l0rq.fsf@gnus.org>
 <jwvftocvv3v.fsf-monnier+emacs@gnu.org> <m34l4rauem.fsf@gnus.org>
 <m3a7ej9c87.fsf_-_@gnus.org> <831rzvvsgp.fsf@gnu.org>
 <m3wohm9atz.fsf@gnus.org> <m3r27u9a3o.fsf@gnus.org>
 <83y322vqvg.fsf@gnu.org> <m3k1dm98c2.fsf_-_@gnus.org>
 <83v9x6vpap.fsf@gnu.org> <m3ef3u97nr.fsf@gnus.org>
 <m31rzu96bq.fsf_-_@gnus.org>
 <52332265-2d02-a01c-e221-20b00b1edf86@yandex.ru>
 <m3a7eh7jlp.fsf@gnus.org> <m3v9x56133.fsf_-_@gnus.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="206264"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Lars Ingebrigtsen <larsi@gnus.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 16 18:20:13 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hcXt4-000rRg-FQ
	for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 18:20:10 +0200
Original-Received: from localhost ([::1]:41438 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hcXt3-0005nC-Fy
	for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 12:20:09 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60540)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <eliz@gnu.org>) id 1hcXsN-0005my-51
 for emacs-devel@gnu.org; Sun, 16 Jun 2019 12:19:28 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58939)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1hcXsL-000869-Tl; Sun, 16 Jun 2019 12:19:26 -0400
Original-Received: from [176.228.60.248] (port=1486 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1hcXsK-0000l8-Tk; Sun, 16 Jun 2019 12:19:25 -0400
In-reply-to: <m3v9x56133.fsf_-_@gnus.org> (message from Lars Ingebrigtsen on
 Sun, 16 Jun 2019 16:45:20 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:237734
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/237734>

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Sun, 16 Jun 2019 16:45:20 +0200
> 
> In xselect--encode-string:
> select.el:482:24:Warning: `string-make-unibyte' is an obsolete function (as of
>     26.1); use `encode-coding-string'.
> 
> It's this code:
> 
> 	   ((eq type 'C_STRING)
>             ;; If STR is unibyte (the normal case), use it; otherwise
>             ;; we assume some of the characters are eight-bit, and
>             ;; take their lower 8 bits.
> 	    (setq str (string-make-unibyte str)))
> 
> Stefan suggested, I think, that we should just use string-to-unibyte
> here.  Eli, do you agree?

Sorry, no, at least not yet.  I still cannot wrap my head around that
code, and Kenichi Handa didn't respond to my questions.  Please leave
this alone for now, it's still on my todo.