From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: master 40dcf9c2ab 4/5: read-multiple-choice: Display "SPC" instead of " "
Date: Sun, 26 Dec 2021 18:32:24 +0200 [thread overview]
Message-ID: <83ee5znx7r.fsf@gnu.org> (raw)
> branch: master
> commit 40dcf9c2abd62425e599f30548dc53fa58fe2202
> Author: Stefan Kangas <stefan@marxist.se>
> Commit: Stefan Kangas <stefan@marxist.se>
>
> read-multiple-choice: Display "SPC" instead of " "
>
> * lisp/emacs-lisp/rmc.el (rmc--add-key-description): Improve display
> of the keys TAB, RET, SPC, DEL, and ESC. This fixes a bug where " "
> was highlighted in the description in a confusing way.
> * test/lisp/emacs-lisp/rmc-tests.el
> (test-rmc--add-key-description)
> (test-rmc--add-key-description/with-attributes): Update tests for the
> above change.
I don't think I like the result of this changeset. Now SPC is
displayed as [SPC], in brackets, for a reason I cannot understand.
Those brackets get in the way, especially if the Help buffer is
already shown, because there the keys are shown as they should be:
without any brackets.
This affects novice.el, which is for newbies, and so the instructions
cannot be confusing.
Why is it a good idea to show some of the responses in brackets? I
say let's remove the brackets altogether, they are not needed,
especially since the keys are already in a special face. Too many
features at once are not necessarily a Good Thing.
next reply other threads:[~2021-12-26 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 16:32 Eli Zaretskii [this message]
2021-12-26 17:09 ` master 40dcf9c2ab 4/5: read-multiple-choice: Display "SPC" instead of " " Stefan Kangas
2021-12-26 18:23 ` Eli Zaretskii
2021-12-26 20:41 ` Stefan Kangas
2021-12-27 17:56 ` Eli Zaretskii
2021-12-27 19:50 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ee5znx7r.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).