Re: master 40dcf9c2ab 4/5: read-multiple-choice: Display "SPC" instead of " "

[Stefan Kangas <stefan@marxist.se>]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> Why not allow read-multiple-choice to specify longer strings?  It
> already does, with "yes" and "no", doesn't it?

Yup, so I added "(the space bar)".

> I think having the keys/responses in a special face, even if it's
> without the underline, should be enough.  The face should provide
> alternatives for the underline, such as distinct colors.

I think you're right about the brackets.  See the attached patch, WDYT?

[-- Attachment #2: rmc-prompt.diff --]
[-- Type: text/x-diff, Size: 1365 bytes --]

diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el
index 522d395eba..9d5fe40f9a 100644
--- a/lisp/emacs-lisp/rmc.el
+++ b/lisp/emacs-lisp/rmc.el
@@ -38,10 +38,10 @@ rmc--add-key-description
            ;; Not in the name string, or a special character.
            ((or (not pos)
                 (member desc '("ESC" "TAB" "RET" "DEL" "SPC")))
-            (format "[%s] %s"
+            (format "%s %s"
                     (if graphical-terminal
                         (propertize desc 'face 'read-multiple-choice-face)
-                      desc)
+                      (propertize desc 'face 'help-key-name))
                     name))
            ;; The prompt character is in the name, so highlight
            ;; it on graphical terminals.
diff --git a/lisp/novice.el b/lisp/novice.el
index 0cf54df160..d48b1109d0 100644
--- a/lisp/novice.el
+++ b/lisp/novice.el
@@ -88,7 +88,7 @@ disabled-command-function
                                      '((?y "yes")
                                        (?n "no")
                                        (?! "yes; enable for session")
-                                       (?\s "yes; once"))
+                                       (?\s "(the space bar) yes; once"))
                                      help-string
                                      "*Disabled Command*"))))
     (pcase char