From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: master 40dcf9c2ab 4/5: read-multiple-choice: Display "SPC" instead of " " Date: Sun, 26 Dec 2021 18:32:24 +0200 Message-ID: <83ee5znx7r.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12102"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 26 17:33:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1WSK-0002xL-J5 for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Dec 2021 17:33:08 +0100 Original-Received: from localhost ([::1]:39128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1WSJ-0001Bw-6g for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Dec 2021 11:33:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1WRQ-0000Mv-1a for emacs-devel@gnu.org; Sun, 26 Dec 2021 11:32:12 -0500 Original-Received: from [2001:470:142:3::e] (port=57774 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1WRP-00077e-HX; Sun, 26 Dec 2021 11:32:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=eraPZ4s+nvyt6I+EofMjYRZjlyd3Blp3wbFCMOfPGRY=; b=XaVkXgYEmLJ5J1 pKp1lFrQ4ULFKLeW8qs2jtm6WigJZAN4Sc4ZytMBLNZpVgGSRtnxrqjyUo3VkWT1Zgho5i6ecqLOg DqrFPjc2LhKwn6oHGUa9wCFEhCdvsA46KD2RYAJnxhD5lQvl+REWtSuPXKELpvMVU6o/DtmUkwzEG UGW5EJI+TwC1OB3eHL1xGptbQPt0PsfqWfNDP08hR19/kq87ayirLDn2CR3/VWFocb43QLsmxlRLT wUlKcWdP6FUXmHbbG3/rXx2ao54oYDVHG/89jbPLNvlbc3UgRQ8ouJFIe8TB2IJ89cqeTY8kg7Yez lh2fK76psWP0L1XRq2Iw==; Original-Received: from [87.69.77.57] (port=3556 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1WRP-0000N6-3Z; Sun, 26 Dec 2021 11:32:11 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283336 Archived-At: > branch: master > commit 40dcf9c2abd62425e599f30548dc53fa58fe2202 > Author: Stefan Kangas > Commit: Stefan Kangas > > read-multiple-choice: Display "SPC" instead of " " > > * lisp/emacs-lisp/rmc.el (rmc--add-key-description): Improve display > of the keys TAB, RET, SPC, DEL, and ESC. This fixes a bug where " " > was highlighted in the description in a confusing way. > * test/lisp/emacs-lisp/rmc-tests.el > (test-rmc--add-key-description) > (test-rmc--add-key-description/with-attributes): Update tests for the > above change. I don't think I like the result of this changeset. Now SPC is displayed as [SPC], in brackets, for a reason I cannot understand. Those brackets get in the way, especially if the Help buffer is already shown, because there the keys are shown as they should be: without any brackets. This affects novice.el, which is for newbies, and so the instructions cannot be confusing. Why is it a good idea to show some of the responses in brackets? I say let's remove the brackets altogether, they are not needed, especially since the keys are already in a special face. Too many features at once are not necessarily a Good Thing.