From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: master 40dcf9c2ab 4/5: read-multiple-choice: Display "SPC" instead of " "
Date: Sun, 26 Dec 2021 20:23:02 +0200 [thread overview]
Message-ID: <83a6gnns3d.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmkHYM4_1VefhK7VHxrnC3q-43b7shb06s2uaFdEo3Cwhg@mail.gmail.com> (message from Stefan Kangas on Sun, 26 Dec 2021 09:09:15 -0800)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Sun, 26 Dec 2021 09:09:15 -0800
> Cc: emacs-devel@gnu.org
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I don't think I like the result of this changeset. Now SPC is
> > displayed as [SPC], in brackets, for a reason I cannot understand.
>
> Before this change, SPC in `read-multiple-choice' was displayed as, for
> example
>
> yes; use once
> ^
>
> Where the indicated space character was underlined. So this is
> much less confusing, I think. (See below regarding the brackets.)
I;m not against using "SPC", I only don't like the brackets around it
(and around "!" as well). They distract and confuse, IMO.
> Though when moving `disabled-command' to use `read-multiple-choice' it
> is true that we did lose the explanation in the old prompt that said:
>
> Type y, n, ! or SPC (the space bar):
>
> I'm not sure what, if anything we should do about this. One idea is to
> explain what SPC means at the bottom of the *Disabled Command* buffer.
Why not allow read-multiple-choice to specify longer strings? It
already does, with "yes" and "no", doesn't it?
> (Personally, I think by the time you stumble upon `disabled-command' you
> should already be proficient enough to know what SPC means.
No, we need to support the case where the user type "C-n n" by
mistake.
> > Why is it a good idea to show some of the responses in brackets? I
> > say let's remove the brackets altogether, they are not needed,
> > especially since the keys are already in a special face. Too many
> > features at once are not necessarily a Good Thing.
>
> I think you have a point regarding these brackets, but note that they
> have always been there with `read-multiple-choice'.
>
> We could remove them, I think, but would they still be needed on
> terminals that can't display underline? Or should we perhaps just use
> help-key-binding in that case?
I think having the keys/responses in a special face, even if it's
without the underline, should be enough. The face should provide
alternatives for the underline, such as distinct colors.
next prev parent reply other threads:[~2021-12-26 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 16:32 master 40dcf9c2ab 4/5: read-multiple-choice: Display "SPC" instead of " " Eli Zaretskii
2021-12-26 17:09 ` Stefan Kangas
2021-12-26 18:23 ` Eli Zaretskii [this message]
2021-12-26 20:41 ` Stefan Kangas
2021-12-27 17:56 ` Eli Zaretskii
2021-12-27 19:50 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a6gnns3d.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).