From: Eli Zaretskii <eliz@gnu.org>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: juri@linkov.net, larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: master 6a2ee981c3: Add new functions for splitting the root window
Date: Thu, 15 Sep 2022 08:45:46 +0300 [thread overview]
Message-ID: <83bkrh1985.fsf@gnu.org> (raw)
In-Reply-To: <87mtb1r1xk.fsf@melete.silentflame.com> (message from Sean Whitton on Wed, 14 Sep 2022 16:06:31 -0700)
> From: Sean Whitton <spwhitton@spwhitton.name>
> Date: Wed, 14 Sep 2022 16:06:31 -0700
>
> Thanks for reviewing. Others haven't chimed in on this part of the
> discussion, and I've gone ahead and pushed.
FWIW, if you want to give people chance to chime in, you should wait
longer than you did in this case. Just 7 hours is not nearly enough.
The fact that people didn't speak up in the discussion until you post
an actual patch doesn't mean they won't want to say something about
the patch, it just means they didn't have anything they considered
useful to say in response to the previous messages. It definitely
doesn't mean no one else is interested in this discussion.
My rule of thumb is to wait for at least a week before concluding that
no one has anything to say about a patch. Yes, this slows down the
commit rate, but IMO it makes our community sense better, and
eventually the code cleaner.
next prev parent reply other threads:[~2022-09-15 5:45 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166240424802.11417.12502552895310232639@vcs2.savannah.gnu.org>
[not found] ` <20220905185728.838CEC0088A@vcs2.savannah.gnu.org>
2022-09-06 16:17 ` master 6a2ee981c3: Add new functions for splitting the root window Juri Linkov
2022-09-07 0:32 ` Sean Whitton
2022-09-07 12:57 ` Lars Ingebrigtsen
2022-09-07 18:01 ` Juri Linkov
2022-09-08 11:50 ` Lars Ingebrigtsen
2022-09-08 12:09 ` Robert Pluim
2022-09-08 12:18 ` Lars Ingebrigtsen
2022-09-08 14:54 ` [External] : " Drew Adams
2022-09-10 19:27 ` Juri Linkov
2022-09-11 11:03 ` Lars Ingebrigtsen
2022-09-11 17:48 ` Sean Whitton
2022-09-11 18:31 ` chad
2022-09-12 10:00 ` Lars Ingebrigtsen
2022-09-12 14:10 ` Sean Whitton
2022-09-13 11:11 ` Lars Ingebrigtsen
2022-09-13 13:52 ` Sean Whitton
2022-09-13 13:56 ` Lars Ingebrigtsen
2022-09-13 14:12 ` Sean Whitton
2022-09-14 12:29 ` Lars Ingebrigtsen
2022-09-14 13:49 ` Eli Zaretskii
2022-09-14 16:37 ` Sean Whitton
2022-09-14 16:37 ` Sean Whitton
2022-09-12 14:29 ` Visuwesh
2022-09-12 10:04 ` Lars Ingebrigtsen
2022-09-12 14:35 ` Sean Whitton
2022-09-13 4:08 ` Richard Stallman
2022-09-13 14:29 ` [External] : " Drew Adams
2022-09-12 17:34 ` Juri Linkov
2022-09-12 18:57 ` Sean Whitton
2022-09-12 19:31 ` Juri Linkov
2022-09-13 14:01 ` Sean Whitton
2022-09-13 18:29 ` Juri Linkov
2022-09-13 22:12 ` Sean Whitton
2022-09-14 6:53 ` Juri Linkov
2022-09-14 16:52 ` Sean Whitton
2022-09-14 19:22 ` Juri Linkov
2022-09-14 23:06 ` Sean Whitton
2022-09-15 5:45 ` Eli Zaretskii [this message]
2022-09-15 16:14 ` Sean Whitton
2022-09-12 17:50 ` Stefan Monnier
2022-09-12 18:55 ` Sean Whitton
2022-09-12 19:29 ` Juri Linkov
2022-09-12 23:40 ` Sean Whitton
2022-09-13 6:50 ` Juri Linkov
2022-09-13 13:54 ` Sean Whitton
2022-09-13 9:33 ` Gregory Heytings
2022-09-13 11:14 ` Lars Ingebrigtsen
2022-09-13 13:51 ` Sean Whitton
2022-09-13 14:01 ` Gregory Heytings
2022-09-13 14:19 ` Sean Whitton
2022-09-13 14:26 ` Gregory Heytings
2022-09-13 15:22 ` Yuri Khan
2022-09-13 16:33 ` Gregory Heytings
2022-09-13 17:09 ` Yuri Khan
2022-09-13 18:16 ` Juri Linkov
2022-09-13 19:28 ` Gregory Heytings
2022-09-14 6:47 ` Juri Linkov
2022-09-14 8:13 ` Gregory Heytings
2022-09-14 9:21 ` Yuri Khan
2022-09-14 10:51 ` Gregory Heytings
2022-09-14 12:11 ` Yuri Khan
2022-09-15 7:19 ` Augusto Stoffel
2022-09-16 14:30 ` Gregory Heytings
2022-09-16 15:03 ` Augusto Stoffel
2022-09-19 6:53 ` Emanuel Berg
2022-09-08 12:22 ` Gregory Heytings
2022-09-08 14:54 ` [External] : " Drew Adams
2022-09-08 17:25 ` Juri Linkov
2022-09-09 17:07 ` Lars Ingebrigtsen
2022-09-09 17:25 ` Visuwesh
2022-09-09 17:36 ` Lars Ingebrigtsen
2022-09-11 3:37 ` Richard Stallman
2022-09-19 23:55 ` Emanuel Berg
2022-09-20 6:50 ` Juri Linkov
2022-09-20 7:47 ` Emanuel Berg
2022-09-20 16:06 ` Juri Linkov
2022-09-20 21:24 ` Emanuel Berg
2022-09-21 18:41 ` Juri Linkov
2022-09-21 21:16 ` Emanuel Berg
2022-09-09 17:53 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkrh1985.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).