Re: master 6a2ee981c3: Add new functions for splitting the root window

[Sean Whitton <spwhitton@spwhitton.name>]

[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]

Hello,

On Wed 14 Sep 2022 at 09:53AM +03, Juri Linkov wrote:

>>>  - tear-off-window   - C-x w ^   - detach window to a new frame
>>>  - tab-window-detach - C-x t ^ w - detach window to a new tab
>>>  - tab-detach        - C-x t ^ f - detach tab to a new frame
>>
>> My own intuition is that C-x t is for operations *on* tabs, and C-x w
>> for operations *on* windows, so what do you (and others) think about:
>>
>> C-x w ^ f                     -- tear-off-window
>> C-x w ^ t                     -- tab-window-detach
>> C-x t ^                       -- tab-detach
>
> Nice, these keys also have transitional semantics:
>
>   w ^ f   - from window to frame
>   w ^ t   - from window to tab

Indeed!

> So for consistency tab-detach also could be:
>
>   t ^ f   - from tab to frame
>
> if another key also makes sense:
>
>   t ^ w   - from tab to window

Do you think it does?

Or perhaps we should do it anyway in case we later want to put another
detach command under the submap -- perhaps we'll want C-x t ^ F for some
variant on tab-detach, since '^' can't be capitalised.

Here is a patch for review, though it's pretty trivial -- I am wondering
if an additional NEWS entry is warranted or not.  I don't believe there
are any manual updates required.

Nice to resolve this subthread.

-- 
Sean Whitton

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Use-key-for-detach-command-bindings.patch --]
[-- Type: text/x-patch, Size: 1476 bytes --]

From 2a128e9796b77f2b1d5c0b779929bd7deebe2ea1 Mon Sep 17 00:00:00 2001
From: Sean Whitton <spwhitton@spwhitton.name>
Date: Wed, 14 Sep 2022 09:49:27 -0700
Subject: [PATCH] Use '^' key for detach command bindings

* lisp/tab-bar.el (tab-prefix-map): Move tear-off-window to C-x w ^ f.
Bind tab-window-detach to C-x w ^ t.
* lisp/window.el (window-prefix-map): Bind tab-detach to C-x t ^ f.
---
 lisp/tab-bar.el | 1 +
 lisp/window.el  | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index cf5ae09a24..abefd996a8 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -2411,6 +2411,7 @@ 'tab-list
 (keymap-set tab-prefix-map "M"   #'tab-move-to)
 (keymap-set tab-prefix-map "G"   #'tab-group)
 (keymap-set tab-prefix-map "r"   #'tab-rename)
+(keymap-set tab-prefix-map "^ f"  #'tab-detach)
 (keymap-set tab-prefix-map "RET" #'tab-switch)
 (keymap-set tab-prefix-map "b"   #'switch-to-buffer-other-tab)
 (keymap-set tab-prefix-map "f"   #'find-file-other-tab)
diff --git a/lisp/window.el b/lisp/window.el
index d5f42dd10b..905803b19e 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -10593,7 +10593,8 @@ window-prefix-map
   "2" #'split-root-window-below
   "3" #'split-root-window-right
   "s" #'window-toggle-side-windows
-  "f" #'tear-off-window
+  "^ f" #'tear-off-window
+  "^ t" #'tab-window-detach
   "-" #'fit-window-to-buffer
   "0" #'delete-windows-on)
 (define-key ctl-x-map "w" window-prefix-map)
-- 
2.30.2