From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 6a2ee981c3: Add new functions for splitting the root window Date: Thu, 15 Sep 2022 08:45:46 +0300 Message-ID: <83bkrh1985.fsf@gnu.org> References: <166240424802.11417.12502552895310232639@vcs2.savannah.gnu.org> <20220905185728.838CEC0088A@vcs2.savannah.gnu.org> <86h71kseiw.fsf@mail.linkov.net> <87illzmjew.fsf@gnus.org> <868rmvxdvj.fsf@mail.linkov.net> <87bkrq5bmb.fsf@gnus.org> <87pmg69ifi.fsf@gmail.com> <87h71i3vr3.fsf@gnus.org> <864jxfghcf.fsf@mail.linkov.net> <87sfkygokp.fsf@gnus.org> <87r10hg5u7.fsf@melete.silentflame.com> <86pmg0v6my.fsf@mail.linkov.net> <87a674beup.fsf@melete.silentflame.com> <86v8psqtj7.fsf@mail.linkov.net> <87edwfe5lg.fsf@melete.silentflame.com> <864jxbw2k7.fsf@mail.linkov.net> <87o7vidiu3.fsf@melete.silentflame.com> <86r10ev44h.fsf@mail.linkov.net> <87tu59ucdx.fsf@melete.silentflame.com> <86mtb1n4ku.fsf@mail.linkov.net> <87mtb1r1xk.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32057"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juri@linkov.net, larsi@gnus.org, emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 15 07:51:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYhmv-0008E3-CV for ged-emacs-devel@m.gmane-mx.org; Thu, 15 Sep 2022 07:51:49 +0200 Original-Received: from localhost ([::1]:50436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYhmu-00057Z-70 for ged-emacs-devel@m.gmane-mx.org; Thu, 15 Sep 2022 01:51:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYhhF-0002zJ-8D for emacs-devel@gnu.org; Thu, 15 Sep 2022 01:45:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47096) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYhhE-0005jq-Eb; Thu, 15 Sep 2022 01:45:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pqTVMO6LMEL7sjXoiZLvWAOqdJE9N36MFFbaP2ARAFc=; b=SU6tp+6PvvX6 mezo0ghebOrjBObH7zDmWXX51tv8jbh6ozgWG78ocK93T2a6VLBSVd5hFgBcVX2ygy5PzSqpj+fvJ O3+xjbAN+ctHxdblQ/9MGYpP28Jsqn4FvzGXSJhMsLA8rOOak4ZfCPK3WlLpTK+SAb/ki0JcpX0pZ o7I2MymD7sDLPInfkMmLrgXLme5E1doTuf6HsWyCa5RqkzCUv1SJE++DdaHLPCGYSnkG2Tzflzc8w ufh52dheQ/y9QN65pXko27sDxKtAytk1knRgpvHA2C8LEAllRXEsBBoat0GZfzGxLFwXiYEHhFT9t 0fdoWOz6KcKk5qy4uiP0SQ==; Original-Received: from [87.69.77.57] (port=1445 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYhhD-0000am-Of; Thu, 15 Sep 2022 01:45:56 -0400 In-Reply-To: <87mtb1r1xk.fsf@melete.silentflame.com> (message from Sean Whitton on Wed, 14 Sep 2022 16:06:31 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295379 Archived-At: > From: Sean Whitton > Date: Wed, 14 Sep 2022 16:06:31 -0700 > > Thanks for reviewing. Others haven't chimed in on this part of the > discussion, and I've gone ahead and pushed. FWIW, if you want to give people chance to chime in, you should wait longer than you did in this case. Just 7 hours is not nearly enough. The fact that people didn't speak up in the discussion until you post an actual patch doesn't mean they won't want to say something about the patch, it just means they didn't have anything they considered useful to say in response to the previous messages. It definitely doesn't mean no one else is interested in this discussion. My rule of thumb is to wait for at least a week before concluding that no one has anything to say about a patch. Yes, this slows down the commit rate, but IMO it makes our community sense better, and eventually the code cleaner.