* Re: What is the point of `url-dired-minor-mode'?
2022-07-31 18:32 What is the point of `url-dired-minor-mode'? Stefan Kangas
@ 2022-07-31 18:42 ` Lars Ingebrigtsen
2022-07-31 19:00 ` Eli Zaretskii
1 sibling, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-31 18:42 UTC (permalink / raw)
To: Stefan Kangas; +Cc: emacs-devel
Stefan Kangas <stefan@marxist.se> writes:
> I can't see that `url-dired-minor-mode' (defined in url-dired.el) does
> anything at all? AFAICT, things work exactly the same in Dired whether
> it is enabled or not.
>
> Am I missing something?
It seems pointless to me in its current state, because all the stuff
that did something was taken out by the patch below. (With a not-very
helpful commit message.)
So I think it can be obsoleted.
diff --git a/lisp/url/ChangeLog b/lisp/url/ChangeLog
index 5ebac63b0b..13c5b09f44 100644
--- a/lisp/url/ChangeLog
+++ b/lisp/url/ChangeLog
@@ -1,3 +1,9 @@
+2007-11-28 Diane Murray <disumu@x3y2z1.net>
+
+ * url-dired.el: Don't require w3-fetch and w3-open-local.
+ (url-dired-find-file): Use `find-file'. Doc fix.
+ (url-dired-find-file-mouse, url-dired-minor-mode): Doc fix.
+
2007-11-24 Glenn Morris <rgm@gnu.org>
* url-privacy.el (url-device-type): Fix typo.
diff --git a/lisp/url/url-dired.el b/lisp/url/url-dired.el
index 189628468b..93c9944755 100644
--- a/lisp/url/url-dired.el
+++ b/lisp/url/url-dired.el
@@ -24,8 +24,6 @@
;;; Code:
-(autoload 'w3-fetch "w3")
-(autoload 'w3-open-local "w3")
(autoload 'dired-get-filename "dired")
(defvar url-dired-minor-mode-map
@@ -41,22 +39,19 @@ url-dired-minor-mode
(make-variable-buffer-local 'url-dired-minor-mode)
(defun url-dired-find-file ()
- "In dired, visit the file or directory named on this line, using Emacs-W3."
+ "In dired, visit the file or directory named on this line."
(interactive)
(let ((filename (dired-get-filename)))
- (cond ((string-match "/\\(.*@.*\\):\\(/.*\\)" filename)
- (w3-fetch (concat "file://" (match-string 1 filename) (match-string 2 filename))))
- (t
- (w3-open-local filename)))))
+ (find-file filename)))
(defun url-dired-find-file-mouse (event)
- "In dired, visit the file or directory name you click on, using Emacs-W3."
+ "In dired, visit the file or directory name you click on."
(interactive "@e")
(mouse-set-point event)
(url-dired-find-file))
(defun url-dired-minor-mode (&optional arg)
- "Minor mode for directory browsing with Emacs-W3."
+ "Minor mode for directory browsing."
(interactive "P")
(cond
((null arg)
^ permalink raw reply related [flat|nested] 3+ messages in thread