From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: What is the point of `url-dired-minor-mode'?
Date: Sun, 31 Jul 2022 20:42:38 +0200 [thread overview]
Message-ID: <875yjd2kf5.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkmkShSEof9fmpU4RVfgZSinZo8NE7gC=L6Cq2NhzzB0qvA@mail.gmail.com> (Stefan Kangas's message of "Sun, 31 Jul 2022 14:32:17 -0400")
Stefan Kangas <stefan@marxist.se> writes:
> I can't see that `url-dired-minor-mode' (defined in url-dired.el) does
> anything at all? AFAICT, things work exactly the same in Dired whether
> it is enabled or not.
>
> Am I missing something?
It seems pointless to me in its current state, because all the stuff
that did something was taken out by the patch below. (With a not-very
helpful commit message.)
So I think it can be obsoleted.
diff --git a/lisp/url/ChangeLog b/lisp/url/ChangeLog
index 5ebac63b0b..13c5b09f44 100644
--- a/lisp/url/ChangeLog
+++ b/lisp/url/ChangeLog
@@ -1,3 +1,9 @@
+2007-11-28 Diane Murray <disumu@x3y2z1.net>
+
+ * url-dired.el: Don't require w3-fetch and w3-open-local.
+ (url-dired-find-file): Use `find-file'. Doc fix.
+ (url-dired-find-file-mouse, url-dired-minor-mode): Doc fix.
+
2007-11-24 Glenn Morris <rgm@gnu.org>
* url-privacy.el (url-device-type): Fix typo.
diff --git a/lisp/url/url-dired.el b/lisp/url/url-dired.el
index 189628468b..93c9944755 100644
--- a/lisp/url/url-dired.el
+++ b/lisp/url/url-dired.el
@@ -24,8 +24,6 @@
;;; Code:
-(autoload 'w3-fetch "w3")
-(autoload 'w3-open-local "w3")
(autoload 'dired-get-filename "dired")
(defvar url-dired-minor-mode-map
@@ -41,22 +39,19 @@ url-dired-minor-mode
(make-variable-buffer-local 'url-dired-minor-mode)
(defun url-dired-find-file ()
- "In dired, visit the file or directory named on this line, using Emacs-W3."
+ "In dired, visit the file or directory named on this line."
(interactive)
(let ((filename (dired-get-filename)))
- (cond ((string-match "/\\(.*@.*\\):\\(/.*\\)" filename)
- (w3-fetch (concat "file://" (match-string 1 filename) (match-string 2 filename))))
- (t
- (w3-open-local filename)))))
+ (find-file filename)))
(defun url-dired-find-file-mouse (event)
- "In dired, visit the file or directory name you click on, using Emacs-W3."
+ "In dired, visit the file or directory name you click on."
(interactive "@e")
(mouse-set-point event)
(url-dired-find-file))
(defun url-dired-minor-mode (&optional arg)
- "Minor mode for directory browsing with Emacs-W3."
+ "Minor mode for directory browsing."
(interactive "P")
(cond
((null arg)
next prev parent reply other threads:[~2022-07-31 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-31 18:32 What is the point of `url-dired-minor-mode'? Stefan Kangas
2022-07-31 18:42 ` Lars Ingebrigtsen [this message]
2022-07-31 19:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yjd2kf5.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).