From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: What is the point of `url-dired-minor-mode'? Date: Sun, 31 Jul 2022 20:42:38 +0200 Message-ID: <875yjd2kf5.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4466"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 31 20:44:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIDvB-000104-PS for ged-emacs-devel@m.gmane-mx.org; Sun, 31 Jul 2022 20:44:13 +0200 Original-Received: from localhost ([::1]:42950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIDvA-00025T-N7 for ged-emacs-devel@m.gmane-mx.org; Sun, 31 Jul 2022 14:44:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIDtp-0001Ns-4N for emacs-devel@gnu.org; Sun, 31 Jul 2022 14:42:49 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:56048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIDtn-0001J4-IE for emacs-devel@gnu.org; Sun, 31 Jul 2022 14:42:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jYJLWfss1qUehLf+t1N7SkbLmFq3rqYwaK63hSDwJ58=; b=oaKcexEAbRkMAXnmHKpylYOHTQ sxy+A6Dta78a+RHUnR4bVZ7vKJADp0mzGKRMXZRZBBztp4x/KLqxI04Ry65ZoruoONCnzQ4qm8MBx TD9/lXnBvGmA+K3FZBmTcdeDs+PkVcAoA7XjT08QjpIGn71pNcA/NJPFZnUVCPVuo1pU=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIDtf-0005h4-88; Sun, 31 Jul 2022 20:42:41 +0200 In-Reply-To: (Stefan Kangas's message of "Sun, 31 Jul 2022 14:32:17 -0400") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEViUE6NeXD///+N ib42AAAAAWJLR0QCZgt8ZAAAAAd0SU1FB+YHHxIoLii6HZ0AAAEpSURBVCjPRVJRjgUhCINE/p1E 74PJm39M5P5X2Rbf7prJxNpSEBSxI3/L8mRYE1FpAFgTp6qvuMj20mjyP4P/DkYg5XET3di3QuYK tWlTUoxRrgsQ40uCWwJb4QPaz1WeoMOhm+7o5XaTFkGLl+neomQe5tdbm72wkPNfKG5xZbrobj1u dXWErF+mA1gxKocALi7TZZTYIQBQVgLQvgYWvETolSVETy6EgUpk/eTeDBMzbzlzMSzm6m2+iTq2 jObe5tkAw83E+0QILtDROWkj5gOmN6a2weTIDWcdyp54rwtmlXVaqAmcNTgF1Kp7FeAAHbn3Beyt +fwFs2mB26bH9iJjNVXbqTjHg2DnPSVqGLVGGdzR4x1wPuM2slcHOj+8rbULaPhM9OIHGBsthXAq V+gAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDctMzFUMTg6NDA6NDYrMDA6MDAFT5R1AAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIyLTA3LTMxVDE4OjQwOjQ2KzAwOjAwdBIsyQAAAABJRU5ErkJggg== X-Now-Playing: Sussan Deyhim & Richard Horowitz's _Desert Equations: Azax Attra_: "Deser Equations (for Brion Gysin)" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292921 Archived-At: Stefan Kangas writes: > I can't see that `url-dired-minor-mode' (defined in url-dired.el) does > anything at all? AFAICT, things work exactly the same in Dired whether > it is enabled or not. > > Am I missing something? It seems pointless to me in its current state, because all the stuff that did something was taken out by the patch below. (With a not-very helpful commit message.) So I think it can be obsoleted. diff --git a/lisp/url/ChangeLog b/lisp/url/ChangeLog index 5ebac63b0b..13c5b09f44 100644 --- a/lisp/url/ChangeLog +++ b/lisp/url/ChangeLog @@ -1,3 +1,9 @@ +2007-11-28 Diane Murray + + * url-dired.el: Don't require w3-fetch and w3-open-local. + (url-dired-find-file): Use `find-file'. Doc fix. + (url-dired-find-file-mouse, url-dired-minor-mode): Doc fix. + 2007-11-24 Glenn Morris * url-privacy.el (url-device-type): Fix typo. diff --git a/lisp/url/url-dired.el b/lisp/url/url-dired.el index 189628468b..93c9944755 100644 --- a/lisp/url/url-dired.el +++ b/lisp/url/url-dired.el @@ -24,8 +24,6 @@ ;;; Code: -(autoload 'w3-fetch "w3") -(autoload 'w3-open-local "w3") (autoload 'dired-get-filename "dired") (defvar url-dired-minor-mode-map @@ -41,22 +39,19 @@ url-dired-minor-mode (make-variable-buffer-local 'url-dired-minor-mode) (defun url-dired-find-file () - "In dired, visit the file or directory named on this line, using Emacs-W3." + "In dired, visit the file or directory named on this line." (interactive) (let ((filename (dired-get-filename))) - (cond ((string-match "/\\(.*@.*\\):\\(/.*\\)" filename) - (w3-fetch (concat "file://" (match-string 1 filename) (match-string 2 filename)))) - (t - (w3-open-local filename))))) + (find-file filename))) (defun url-dired-find-file-mouse (event) - "In dired, visit the file or directory name you click on, using Emacs-W3." + "In dired, visit the file or directory name you click on." (interactive "@e") (mouse-set-point event) (url-dired-find-file)) (defun url-dired-minor-mode (&optional arg) - "Minor mode for directory browsing with Emacs-W3." + "Minor mode for directory browsing." (interactive "P") (cond ((null arg)