From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2ef6f943abd: Add option to control default outlining in 'C-h b' Date: Tue, 25 Apr 2023 12:09:58 +0300 Message-ID: <838regwcnt.fsf@gnu.org> References: <168233653969.13461.3810563138120581789@vcs2.savannah.gnu.org> <20230424114219.F2AEAC0004A@vcs2.savannah.gnu.org> <877cu1bf6q.fsf@gmail.com> <834jp5xn7v.fsf@gnu.org> <87a5ywn4qj.fsf@web.de> <83r0s8wjcf.fsf@gnu.org> <87leig9xm8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20986"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, emacs-devel@gnu.org, orontee@gmail.com To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 25 11:10:23 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prEgp-0005FY-LG for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Apr 2023 11:10:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prEg2-0001xq-TA; Tue, 25 Apr 2023 05:09:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prEg0-0001xY-FG for emacs-devel@gnu.org; Tue, 25 Apr 2023 05:09:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prEg0-0002t0-3f; Tue, 25 Apr 2023 05:09:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=XN7qFCC7pA4vMEVNgHPegcI0GJdEhCZG/cDBiDSg9bE=; b=E2Ryh7HQS2/jijMXAfXP E6LvURvzy7mLFGpwqu7y3s1GF2b6lpChQEfFBpJcAdrn8YWSPR1Qj2oGajgrKie6XTznN/U3uQ3IR piAs5XKWMpMieEf9HlGsmIrBOuvGYqFMpQiDUyyj8/XUi2jJ6f1HnQ0jL1vjKPnzP9s4tpfSWo5ZG EfNY0OPAsGaB7JZGbdN+RfJNN/qlCCUqLcAsIzIIY5mVbreHYOdHbnERZp6SNHr+gGc41ERqbvIQn juA7BstyowKw7UASP7e5lcra7MmdHjFaXHK6LbzE0n5oNMC0aue9CrfrL+e82a8EbHTKBjDZ7mUbn 10L3M44Q0UNGAg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prEfz-0001j0-Cd; Tue, 25 Apr 2023 05:09:31 -0400 In-Reply-To: <87leig9xm8.fsf@gmail.com> (message from Robert Pluim on Tue, 25 Apr 2023 10:25:51 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305644 Archived-At: > From: Robert Pluim > Cc: Michael Heerdegen , emacs-devel@gnu.org, > Matthias Meulien > Date: Tue, 25 Apr 2023 10:25:51 +0200 > > >>>>> On Tue, 25 Apr 2023 09:45:36 +0300, Eli Zaretskii said: > > Eli> Feel free to suggest a better tag, TIA. Bonus points for untangling > Eli> the IMNSHO confusing documentation of outline-default-rules in these > Eli> areas (e.g., what does "function is expected to toggle the heading > Eli> visibility" even mean??) and fixing that and the related tags as well. > Eli> I simply had no time for that, sorry, and saying just "Custom > Eli> function" without any hint what that function should do seemed like a > Eli> bad idea. > > The custom function is just funcallʼed, which is somewhat unfriendly, > since it forces the user to understand the details of how to hide > headings, which are not documented (what happens if the custom > function does nothing?). A predicate function would be more useful. > > This code and the defcustom is new in emacs-29, so we can still change > it to be a predicate instead. At least we should document is better Agreed. Patches welcome.