Re: master d7ff14fcba6: pcomplete--entries: In predicate, check file exists

Re: master d7ff14fcba6: pcomplete--entries: In predicate, check file exists

[Michael Albinus]

Sean Whitton <spwhitton@spwhitton.name> writes:

Hi Sean, Jim,

> commit d7ff14fcba6f0830eeadb98981bb626cf7314c53
> Author: Sean Whitton <spwhitton@spwhitton.name>
> Commit: Sean Whitton <spwhitton@spwhitton.name>
>
>     pcomplete--entries: In predicate, check file exists
>
>     * lisp/pcomplete.el (pcomplete--entries): In the predicate passed to
>     completion-table-with-predicate, when PREDICATE is nil, take ourselves
>     to be responsible for calling file-exists-p (bug#67661).

This commit lets em-cmpl-tests.el fail:

--8<---------------cut here---------------start------------->8---
# make -C test em-cmpl-tests
make: Entering directory '/home/albinus/src/emacs/test'
make[1]: Entering directory '/home/albinus/src/emacs/test'
  GEN      lisp/eshell/em-cmpl-tests.log
Running 27 tests (2024-01-17 12:36:17+0100, selector `(not (tag :unstable))')
Loading em-alias...
Loading em-banner...
Loading em-basic...
Loading em-extpipe...
Loading em-glob...
Loading em-ls...
Loading em-pred...
Loading em-prompt...
Loading em-script...
Loading em-term...
   passed   1/27  em-cmpl-test/command-completion (0.067966 sec)
   passed   2/27  em-cmpl-test/file-completion/after-list (0.006515 sec)
   passed   3/27  em-cmpl-test/file-completion/glob (0.001798 sec)
Test em-cmpl-test/file-completion/non-unique backtrace:
  signal(ert-test-failed (((should (looking-at "Complete, but not uniq
  ert-fail(((should (looking-at "Complete, but not unique")) :form (lo
  (if (unwind-protect (setq value-77 (apply fn-75 args-76)) (setq form
  (let (form-description-79) (if (unwind-protect (setq value-77 (apply
  (let ((value-77 'ert-form-evaluation-aborted-78)) (let (form-descrip
  (let* ((fn-75 #'looking-at) (args-76 (condition-case err (let ((sign
  (save-excursion (goto-char (point-max)) (forward-line -1) (let* ((fn
  (save-current-buffer (set-buffer (messages-buffer)) (save-excursion
  (progn (write-region nil nil (expand-file-name "file.txt")) (write-r
  (unwind-protect (progn (write-region nil nil (expand-file-name "file
  (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct
  (save-current-buffer (set-buffer eshell-buffer) (let* ((coding-syste
  (unwind-protect (save-current-buffer (set-buffer eshell-buffer) (let
  (let* ((process-environment (cons "HISTFILE" process-environment)) (
  (progn (let* ((process-environment (cons "HISTFILE" process-environm
  (unwind-protect (progn (let* ((process-environment (cons "HISTFILE"
  (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct
  (save-current-buffer (let* ((coding-system-for-write nil) (temp-file
  (closure (t) nil (save-current-buffer (let* ((coding-system-for-writ
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name em-cmpl-test/file-completion/non-uniq
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/em-cmpl-tests
  command-line()
  normal-top-level()
Test em-cmpl-test/file-completion/non-unique condition:
    (ert-test-failed
     ((should (looking-at "Complete, but not unique")) :form
      (looking-at "Complete, but not unique") :value nil))
   FAILED   4/27  em-cmpl-test/file-completion/non-unique (0.012443 sec) at lisp/eshell/em-cmpl-tests.el:172
...
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.

Re: master d7ff14fcba6: pcomplete--entries: In predicate, check file exists

[Jim Porter]

On 1/17/2024 3:42 AM, Michael Albinus wrote:
> Sean Whitton <spwhitton@spwhitton.name> writes:
>> commit d7ff14fcba6f0830eeadb98981bb626cf7314c53
>> Author: Sean Whitton <spwhitton@spwhitton.name>
>> Commit: Sean Whitton <spwhitton@spwhitton.name>
>>
>>      pcomplete--entries: In predicate, check file exists
>>
>>      * lisp/pcomplete.el (pcomplete--entries): In the predicate passed to
>>      completion-table-with-predicate, when PREDICATE is nil, take ourselves
>>      to be responsible for calling file-exists-p (bug#67661).
> 
> This commit lets em-cmpl-tests.el fail:

Thanks for the reminder. I think Sean had pinged me about this, but I 
was busy with other things and forgot about it. I've now pushed a fix 
for this that should make the test more robust.

- Jim

Re: master d7ff14fcba6: pcomplete--entries: In predicate, check file exists

[Michael Albinus]

Jim Porter <jporterbugs@gmail.com> writes:

Hi Jim,

> Thanks for the reminder. I think Sean had pinged me about this, but I
> was busy with other things and forgot about it. I've now pushed a fix
> for this that should make the test more robust.

Thanks. On emba, the test passes now.

> - Jim

Best regards, Michael.