From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: master d7ff14fcba6: pcomplete--entries: In predicate, check file exists Date: Wed, 17 Jan 2024 09:34:34 -0800 Message-ID: <4a9bfd6d-57f4-fa18-f2e6-1a04c08b0917@gmail.com> References: <170387172495.10805.1051075166758572806@vcs2.savannah.gnu.org> <20231229174205.414DBC004B9@vcs2.savannah.gnu.org> <874jfc9oee.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40894"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Sean Whitton To: Michael Albinus , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 17 18:35:13 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQ9on-000AOQ-51 for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Jan 2024 18:35:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQ9oH-0003bN-HT; Wed, 17 Jan 2024 12:34:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQ9oF-0003UA-5e for emacs-devel@gnu.org; Wed, 17 Jan 2024 12:34:39 -0500 Original-Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQ9oC-0004Wp-Ah for emacs-devel@gnu.org; Wed, 17 Jan 2024 12:34:38 -0500 Original-Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1d6efe27c1dso4732675ad.0 for ; Wed, 17 Jan 2024 09:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705512874; x=1706117674; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=0NcJenoGMu9GVe1ocZqpk/X4P+id8NsOfwK+REdd0w8=; b=ffh2UmIQ3UDIWr2IEKeu9RdBt2OdfaHBngBCCKjY1xBC0Ks+Fdvle7Ih02V1gzyb+y kAZ+nzX2WzDfLh5gEbJFN92AUJukNJqcJhCraB8euJtWZwIt47nY7LQ8zBI6qEDzGm58 1J3qli7trLQrnsH+3BIdIPlHTKEJEwgmuvZcv6Ukv3G2UlWc28GC1tXQxG2rnvzksM0k P8VqpqAPDfCJPNIkP4m7/pVVW7XMJNSkaSOgTo7jgOtLdRfl+mXw/TGQW44y3n6qRBDh p2ElE57x+RGHV61ep/iEakDQYkd8zrCE7iY74IRcXS7L+qx5TepLJod5bz0+mYuTd2qH vs5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705512874; x=1706117674; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0NcJenoGMu9GVe1ocZqpk/X4P+id8NsOfwK+REdd0w8=; b=Nzp82uH2DANNx3707Zmn3czUz0FLoc9Slt/bczlovyasAtzYTJK3ihsc8bfHHxB1lC /U8prG7fhJQm20LgQYuLXg0VYSA9qbBAcwQ+RnpH7OsY1qGvnI+qZ+leqHl7Melel7w/ 4kf6e4AOrZvCX2QDikky8HexvlwtLECCPGCSjtc7OxZRHxVJXHThpTfX10ox0nmTWDlI 18R1czkZqgWPk8iSwU7xnfQrb7GWtm+7C3j0YwE+C9SqA9bpVmEOS1Bcum1K4wRG3LEk aRP95FsyoczOa0n8zlpYu/c0w3RMxV3h2ib0X/hVtDkqxlcfwz2+SkcW2yQfN+NCa7Vq D6sw== X-Gm-Message-State: AOJu0Yw2PxoHsawj92THh0AR8pwBAdhPkZfwj0MM0SF29vILgXA73J1q Vs/959MjgP5vQqSjykr4Fhk= X-Google-Smtp-Source: AGHT+IGyefWWAJF356324W+mPtVjoUhXyk3abBWZYKpCOBsLuIR9TPUcC5W2TgjpItj0wBNbwZLb2g== X-Received: by 2002:a17:902:f68e:b0:1d4:326c:1c99 with SMTP id l14-20020a170902f68e00b001d4326c1c99mr6935754plg.16.1705512874445; Wed, 17 Jan 2024 09:34:34 -0800 (PST) Original-Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id g11-20020a170902f74b00b001d4ceb32787sm11302872plw.78.2024.01.17.09.34.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jan 2024 09:34:33 -0800 (PST) Content-Language: en-US In-Reply-To: <874jfc9oee.fsf@gmx.de> Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315041 Archived-At: On 1/17/2024 3:42 AM, Michael Albinus wrote: > Sean Whitton writes: >> commit d7ff14fcba6f0830eeadb98981bb626cf7314c53 >> Author: Sean Whitton >> Commit: Sean Whitton >> >> pcomplete--entries: In predicate, check file exists >> >> * lisp/pcomplete.el (pcomplete--entries): In the predicate passed to >> completion-table-with-predicate, when PREDICATE is nil, take ourselves >> to be responsible for calling file-exists-p (bug#67661). > > This commit lets em-cmpl-tests.el fail: Thanks for the reminder. I think Sean had pinged me about this, but I was busy with other things and forgot about it. I've now pushed a fix for this that should make the test more robust. - Jim