From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master d7ff14fcba6: pcomplete--entries: In predicate, check file exists Date: Wed, 17 Jan 2024 12:42:49 +0100 Message-ID: <874jfc9oee.fsf@gmx.de> References: <170387172495.10805.1051075166758572806@vcs2.savannah.gnu.org> <20231229174205.414DBC004B9@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26621"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Sean Whitton , Jim Porter To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 17 12:43:39 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQ4KY-0006lE-TG for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Jan 2024 12:43:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQ4Jv-0006et-O3; Wed, 17 Jan 2024 06:42:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQ4Jt-0006ef-MH for emacs-devel@gnu.org; Wed, 17 Jan 2024 06:42:57 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQ4Jr-0006vD-D9 for emacs-devel@gnu.org; Wed, 17 Jan 2024 06:42:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1705491770; x=1706096570; i=michael.albinus@gmx.de; bh=0S1T/mngLbdKySV4Fyo/pVVMBJybFm87nDS9p+8fiqM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=YDmv/Hs9fNqrEebPjOVul34ZhqWe6Dlr9mtZaLMhPjRYQD9G38/6jGieOiS0huot Xs7tyTPQa+OdwNyVNTXVIgmd/k8pWMv2cvlQS+/75X2qqfsUDIqWk1f3qhM67QaoF XBp+Fo2T8n7NoZQO9V+uSp8b0D0Hd7ulEk4F0SybQ46WwLs0DNP2t3U9genSMgoNR t4aggOEwFcOfjmaF1aGDK9gtECh3TlGeoDQ2ygMtE3HYK7Z1bNrF9SMOQDlNLBeE9 cABou86pq4fDhGlg1ECQJ8wKI/1ZzGnes5IGJe3UPwZ+CoZOpY2K93dT/zMKYZs6f s4Bn6Oqkwzc2eGeeFg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MqJm5-1qlSUj0i4B-00nOVb; Wed, 17 Jan 2024 12:42:50 +0100 In-Reply-To: <20231229174205.414DBC004B9@vcs2.savannah.gnu.org> (Sean Whitton's message of "Fri, 29 Dec 2023 12:42:05 -0500 (EST)") X-Provags-ID: V03:K1:mCBBeypYbFzokZtgLZI7qagP+p75GxKKNbWoOxApEjG0C8OGkDa EpLUoUTM8Ir4UT04nqDf1mBQVZhCzZb/7JAmAaqojL/0ZT18SG3uK/gwKc8LicI7Zdi2qan foy2jV3sGvi6N0DiQG05+rSB+nXFb9QQ9uxkYJHuwT3+vPO380WD2j91UA23yYZq96qDWE1 sC/TADzUOu3pAHREGWqBw== UI-OutboundReport: notjunk:1;M01:P0:n6BDRaU7Fo0=;UDyI67oAKIE3wYfmX3ZPLFmGYKF owVJV9112noqFl82bA5mr8dB5CtBrkgliI9as03CO2c9DAv7qC1d3qgsX4jB95Xbr0uOq7f4m e+Gg1wc3QaigNv3KjtpXGWev63PeLHm5vD3SN5p1bDKUlxRP/IuVefIDe0R4mQVM8GVvhgd/c N3kZaDfRISGtQlZNxKbo9/KY5tuxAOhLdQ6YM5KH1gf6SRUqeRWzp48Vg6EQJPGvK28KdCG2q pn+rgWeE787hKtqKNvGkRMZo3iDpZGAOKTmc5khz4IYS1rJe4vX+8rS15yCJsbplkKUVGZO2i QFfsh/ONf0gftkdmbXFVLjdE2fK3Lc2Pi5fLI4SWrsQVZR5+DaRQsTWlLVA6OwUWe+XMFA5df WoDl1jRjpt7gymIXLIBe3icnAEC5yW4QOlzKvvnvK12Kl9/gE3w1xfreT3gQ9hrWADdRHKW5W QMQapp2yQTqWfcQ6y2ZmMvZEsTdG/0stDefRmecnUulbtnTTiRv809SySkooOKqDWxVF92BSq YgicKtLQZfHf5EZwDWFHr2MIJvyzKkvGAlswujLt5ksig3pI17f3nuGEuFzlAtTS//+hL4bw2 nayafkEUET49Ynj46t4UeTCU26CdRQr/DIqP4m9mjwlyuvUgSaJ2YI6tSaSn3khoso6dFPRIV u3XTiO/InELhfyfjfXjgNXqJQgT/ddM4eAqcWwUDTEUQ8F8NU1H5uiODQgvZznfOkWn8iKStJ 3Mfu/llTeZXrPMuxF+6dJ83Gf3DvZCgTJnTsWzF5AYYJTp6DYBlrVTNY3JkCMQ/xDOvMuZ+v Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315031 Archived-At: Sean Whitton writes: Hi Sean, Jim, > commit d7ff14fcba6f0830eeadb98981bb626cf7314c53 > Author: Sean Whitton > Commit: Sean Whitton > > pcomplete--entries: In predicate, check file exists > > * lisp/pcomplete.el (pcomplete--entries): In the predicate passed to > completion-table-with-predicate, when PREDICATE is nil, take ourselv= es > to be responsible for calling file-exists-p (bug#67661). This commit lets em-cmpl-tests.el fail: =2D-8<---------------cut here---------------start------------->8--- # make -C test em-cmpl-tests make: Entering directory '/home/albinus/src/emacs/test' make[1]: Entering directory '/home/albinus/src/emacs/test' GEN lisp/eshell/em-cmpl-tests.log Running 27 tests (2024-01-17 12:36:17+0100, selector `(not (tag :unstable)= )') Loading em-alias... Loading em-banner... Loading em-basic... Loading em-extpipe... Loading em-glob... Loading em-ls... Loading em-pred... Loading em-prompt... Loading em-script... Loading em-term... passed 1/27 em-cmpl-test/command-completion (0.067966 sec) passed 2/27 em-cmpl-test/file-completion/after-list (0.006515 sec) passed 3/27 em-cmpl-test/file-completion/glob (0.001798 sec) Test em-cmpl-test/file-completion/non-unique backtrace: signal(ert-test-failed (((should (looking-at "Complete, but not uniq ert-fail(((should (looking-at "Complete, but not unique")) :form (lo (if (unwind-protect (setq value-77 (apply fn-75 args-76)) (setq form (let (form-description-79) (if (unwind-protect (setq value-77 (apply (let ((value-77 'ert-form-evaluation-aborted-78)) (let (form-descrip (let* ((fn-75 #'looking-at) (args-76 (condition-case err (let ((sign (save-excursion (goto-char (point-max)) (forward-line -1) (let* ((fn (save-current-buffer (set-buffer (messages-buffer)) (save-excursion (progn (write-region nil nil (expand-file-name "file.txt")) (write-r (unwind-protect (progn (write-region nil nil (expand-file-name "file (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct (save-current-buffer (set-buffer eshell-buffer) (let* ((coding-syste (unwind-protect (save-current-buffer (set-buffer eshell-buffer) (let (let* ((process-environment (cons "HISTFILE" process-environment)) ( (progn (let* ((process-environment (cons "HISTFILE" process-environm (unwind-protect (progn (let* ((process-environment (cons "HISTFILE" (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct (save-current-buffer (let* ((coding-system-for-write nil) (temp-file (closure (t) nil (save-current-buffer (let* ((coding-system-for-writ ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name em-cmpl-test/file-completion/non-uniq ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/em-cmpl-tests command-line() normal-top-level() Test em-cmpl-test/file-completion/non-unique condition: (ert-test-failed ((should (looking-at "Complete, but not unique")) :form (looking-at "Complete, but not unique") :value nil)) FAILED 4/27 em-cmpl-test/file-completion/non-unique (0.012443 sec) a= t lisp/eshell/em-cmpl-tests.el:172 ... =2D-8<---------------cut here---------------end--------------->8--- Best regards, Michael.