From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master a0f6029: Fix misuses of `byte-compile-macro-environment` Date: Wed, 3 Mar 2021 16:23:19 +0100 Message-ID: <3E36FB6A-A691-4CD9-909B-6BF1BCFE4D8A@acm.org> References: <20210301171853.8051.45984@vcs0.savannah.gnu.org> <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org> <87h7lsthzh.fsf@tcd.ie> <43A0C407-D217-46AF-8472-28DD2DE80D6C@acm.org> <8735xctggp.fsf@tcd.ie> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20860"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 03 16:24:17 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHTMH-0005Id-Kb for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 16:24:17 +0100 Original-Received: from localhost ([::1]:60946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHTMG-0001wj-LA for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 10:24:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHTLU-00016Z-Po for emacs-devel@gnu.org; Wed, 03 Mar 2021 10:23:28 -0500 Original-Received: from mail1461c50.megamailservers.eu ([91.136.14.61]:44912 helo=mail267c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHTLS-0005qV-07 for emacs-devel@gnu.org; Wed, 03 Mar 2021 10:23:28 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1614785001; bh=wrLXc5rYgeWqASJ4jDERjq0VwSCHBd243LYXtaSu1Yo=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=IugWkhPhpaMRn2GgwG/PpMZlfUFRQEgDrY6fMdo0QYok1DL92Gk29f/EiBoEq3Erp BYM4S6+VZ45JwNG0k3VP0ISoz1PoICHfZe3usgKJZHhWg1sSJOZtKc7fdmAbIrwC9F Lwt7xp1qYrpKWGGhteOhUuD23TrNKOs+zWU6y0hA= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail267c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 123FNJAB014423; Wed, 3 Mar 2021 15:23:21 +0000 In-Reply-To: <8735xctggp.fsf@tcd.ie> X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F29.603FA9E9.0088, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=IrRgj43g c=1 sm=1 tr=0 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=UrsOld1qG7ekDAwy3lgA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.14.61; envelope-from=mattiase@acm.org; helo=mail267c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265885 Archived-At: 3 mars 2021 kl. 16.16 skrev Basil L. Contovounesios : > Indeed, 'make TEST_LOAD_EL=3Dyes test/pcase-tests' succeeds, > whereas 'make TEST_LOAD_EL=3Dno test/pcase-tests' fails. >=20 > Should 'make test/%' be fixed to behave more like 'make check'? Maybe -- test/Makefile.in says: # Whether to run tests from .el files in preference to .elc, we do # this by default since it gives nicer stacktraces. # If you just want a pass/fail, setting this to no is much faster. export TEST_LOAD_EL ?=3D \ $(if $(findstring $(MAKECMDGOALS), all check check-maybe),no,yes) For some tests it may be useful to run both .el and .elc; for others, = it's just a waste of time. My guess is that on balance, .elc is more important (and faster) but = obviously .el gives better diagnostics when something fails.