change to query-replace-read-args

change to query-replace-read-args

[Colin Walters]

What is the rationale behind the following change?

2001-12-30  Richard M. Stallman  <rms@gnu.org>

	* replace.el (query-replace-read-args): Immediate error if read-only.

This breaks ibuffer's multi-buffer query replace functionality, as it
uses `query-replace-read-args' to get the arguments, but the ibuffer
buffer itself is read-only.  Admittedly `query-replace-read-args' is
somewhat buried in the internals of replace.el, but if I can use it I'd
like to.







_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: change to query-replace-read-args

[Eli Zaretskii]

> From: Colin Walters <walters@verbum.org>
> Date: 22 Mar 2002 02:04:40 -0500
> 
> What is the rationale behind the following change?

A user complained on gnu.emacs.bug that query-replace, when invoked on
a read-only buffer, only barfs after you are prompted for the FROM and
TO strings, which might take a lot of effort to construct.

> 	* replace.el (query-replace-read-args): Immediate error if read-only.
> 
> This breaks ibuffer's multi-buffer query replace functionality, as it
> uses `query-replace-read-args' to get the arguments, but the ibuffer
> buffer itself is read-only.

This could be solved by splitting `query-replace-read-args' into 2
parts, one that does the real work unconditionally, the other that
tests whether the buffer is read-only and only invokes the real code
if it isn't.  You could then use the unconditional part in ibuffer.

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel