From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: change to query-replace-read-args Date: Fri, 22 Mar 2002 12:24:11 +0200 Sender: emacs-devel-admin@gnu.org Message-ID: <2950-Fri22Mar2002122411+0200-eliz@is.elta.co.il> References: <1016780680.3568.18.camel@space-ghost> Reply-To: Eli Zaretskii NNTP-Posting-Host: localhost.gmane.org X-Trace: main.gmane.org 1016793035 3660 127.0.0.1 (22 Mar 2002 10:30:35 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 22 Mar 2002 10:30:35 +0000 (UTC) Cc: emacs-devel@gnu.org Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 16oMJf-0000wv-00 for ; Fri, 22 Mar 2002 11:30:35 +0100 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 16oMQH-0004ek-00 for ; Fri, 22 Mar 2002 11:37:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 16oMJK-0006hJ-00; Fri, 22 Mar 2002 05:30:14 -0500 Original-Received: from freya.inter.net.il ([192.114.186.14]) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 16oMGu-0006XD-00 for ; Fri, 22 Mar 2002 05:27:45 -0500 Original-Received: from zaretsky (diup-217-59.inter.net.il [213.8.217.59]) by freya.inter.net.il (Mirapoint) with ESMTP id BGZ27229; Fri, 22 Mar 2002 12:27:29 +0200 (IST) Original-To: walters@verbum.org X-Mailer: emacs 21.2.50 (via feedmail 8 I) and Blat ver 1.8.9 In-Reply-To: <1016780680.3568.18.camel@space-ghost> (message from Colin Walters on 22 Mar 2002 02:04:40 -0500) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:2119 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:2119 > From: Colin Walters > Date: 22 Mar 2002 02:04:40 -0500 > > What is the rationale behind the following change? A user complained on gnu.emacs.bug that query-replace, when invoked on a read-only buffer, only barfs after you are prompted for the FROM and TO strings, which might take a lot of effort to construct. > * replace.el (query-replace-read-args): Immediate error if read-only. > > This breaks ibuffer's multi-buffer query replace functionality, as it > uses `query-replace-read-args' to get the arguments, but the ibuffer > buffer itself is read-only. This could be solved by splitting `query-replace-read-args' into 2 parts, one that does the real work unconditionally, the other that tests whether the buffer is read-only and only invokes the real code if it isn't. You could then use the unconditional part in ibuffer. _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel