From: "Eli Zaretskii" <eliz@is.elta.co.il>
Cc: emacs-devel@gnu.org
Subject: Re: change to query-replace-read-args
Date: Fri, 22 Mar 2002 12:24:11 +0200 [thread overview]
Message-ID: <2950-Fri22Mar2002122411+0200-eliz@is.elta.co.il> (raw)
In-Reply-To: <1016780680.3568.18.camel@space-ghost> (message from Colin Walters on 22 Mar 2002 02:04:40 -0500)
> From: Colin Walters <walters@verbum.org>
> Date: 22 Mar 2002 02:04:40 -0500
>
> What is the rationale behind the following change?
A user complained on gnu.emacs.bug that query-replace, when invoked on
a read-only buffer, only barfs after you are prompted for the FROM and
TO strings, which might take a lot of effort to construct.
> * replace.el (query-replace-read-args): Immediate error if read-only.
>
> This breaks ibuffer's multi-buffer query replace functionality, as it
> uses `query-replace-read-args' to get the arguments, but the ibuffer
> buffer itself is read-only.
This could be solved by splitting `query-replace-read-args' into 2
parts, one that does the real work unconditionally, the other that
tests whether the buffer is read-only and only invokes the real code
if it isn't. You could then use the unconditional part in ibuffer.
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
prev parent reply other threads:[~2002-03-22 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-22 7:04 change to query-replace-read-args Colin Walters
2002-03-22 10:24 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2950-Fri22Mar2002122411+0200-eliz@is.elta.co.il \
--to=eliz@is.elta.co.il \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).