* [PATCH v3] Improve find-sibling-rules option type
@ 2023-10-02 4:54 Paul W. Rankin via Emacs development discussions.
2023-10-03 10:27 ` Mauro Aranda
0 siblings, 1 reply; 3+ messages in thread
From: Paul W. Rankin via Emacs development discussions. @ 2023-10-02 4:54 UTC (permalink / raw)
To: emacs-devel; +Cc: Paul W. Rankin
* lisp/files.el (find-sibling-rules): use alist with tags for custom
type
---
v3, make alist value a repeating string type.
lisp/files.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/files.el b/lisp/files.el
index 9d76668..eceed75 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -7572,7 +7572,8 @@ find-sibling-rules
In this example, if you're in \"src/emacs/emacs-27/lisp/abbrev.el\",
and a \"src/emacs/emacs-28/lisp/abbrev.el\" file exists, it's now
defined as a sibling."
- :type 'sexp
+ :type '(alist :key-type (regexp :tag "Match")
+ :value-type (repeat (string :tag "Expansion")))
:version "29.1")
(defun find-sibling-file (file)
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Improve find-sibling-rules option type
2023-10-02 4:54 [PATCH v3] Improve find-sibling-rules option type Paul W. Rankin via Emacs development discussions.
@ 2023-10-03 10:27 ` Mauro Aranda
2023-10-05 7:46 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-10-03 10:27 UTC (permalink / raw)
To: Paul W. Rankin, emacs-devel
On 2/10/23 01:54, Paul W. Rankin via Emacs development discussions. wrote:
> * lisp/files.el (find-sibling-rules): use alist with tags for custom
> type
> ---
> v3, make alist value a repeating string type.
>
>
> lisp/files.el | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/files.el b/lisp/files.el
> index 9d76668..eceed75 100644
> --- a/lisp/files.el
> +++ b/lisp/files.el
> @@ -7572,7 +7572,8 @@ find-sibling-rules
> In this example, if you're in \"src/emacs/emacs-27/lisp/abbrev.el\",
> and a \"src/emacs/emacs-28/lisp/abbrev.el\" file exists, it's now
> defined as a sibling."
> - :type 'sexp
> + :type '(alist :key-type (regexp :tag "Match")
> + :value-type (repeat (string :tag "Expansion")))
> :version "29.1")
>
> (defun find-sibling-file (file)
FWIW, the change looks good to me.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Improve find-sibling-rules option type
2023-10-03 10:27 ` Mauro Aranda
@ 2023-10-05 7:46 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2023-10-05 7:46 UTC (permalink / raw)
To: Mauro Aranda; +Cc: hello, emacs-devel
> Date: Tue, 3 Oct 2023 07:27:38 -0300
> From: Mauro Aranda <maurooaranda@gmail.com>
>
> On 2/10/23 01:54, Paul W. Rankin via Emacs development discussions. wrote:
> > * lisp/files.el (find-sibling-rules): use alist with tags for custom
> > type
> > ---
> > v3, make alist value a repeating string type.
> >
> >
> > lisp/files.el | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lisp/files.el b/lisp/files.el
> > index 9d76668..eceed75 100644
> > --- a/lisp/files.el
> > +++ b/lisp/files.el
> > @@ -7572,7 +7572,8 @@ find-sibling-rules
> > In this example, if you're in \"src/emacs/emacs-27/lisp/abbrev.el\",
> > and a \"src/emacs/emacs-28/lisp/abbrev.el\" file exists, it's now
> > defined as a sibling."
> > - :type 'sexp
> > + :type '(alist :key-type (regexp :tag "Match")
> > + :value-type (repeat (string :tag "Expansion")))
> > :version "29.1")
> >
> > (defun find-sibling-file (file)
>
> FWIW, the change looks good to me.
Thanks, installed on master.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-05 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-02 4:54 [PATCH v3] Improve find-sibling-rules option type Paul W. Rankin via Emacs development discussions.
2023-10-03 10:27 ` Mauro Aranda
2023-10-05 7:46 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).