From: Mauro Aranda <maurooaranda@gmail.com>
To: "Paul W. Rankin" <hello@paulwrankin.com>, emacs-devel@gnu.org
Subject: Re: [PATCH v3] Improve find-sibling-rules option type
Date: Tue, 3 Oct 2023 07:27:38 -0300 [thread overview]
Message-ID: <a0ca74c3-6e05-5c77-fefe-8341c7255eb7@gmail.com> (raw)
In-Reply-To: <20231002045524.59955-1-hello@paulwrankin.com>
On 2/10/23 01:54, Paul W. Rankin via Emacs development discussions. wrote:
> * lisp/files.el (find-sibling-rules): use alist with tags for custom
> type
> ---
> v3, make alist value a repeating string type.
>
>
> lisp/files.el | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/files.el b/lisp/files.el
> index 9d76668..eceed75 100644
> --- a/lisp/files.el
> +++ b/lisp/files.el
> @@ -7572,7 +7572,8 @@ find-sibling-rules
> In this example, if you're in \"src/emacs/emacs-27/lisp/abbrev.el\",
> and a \"src/emacs/emacs-28/lisp/abbrev.el\" file exists, it's now
> defined as a sibling."
> - :type 'sexp
> + :type '(alist :key-type (regexp :tag "Match")
> + :value-type (repeat (string :tag "Expansion")))
> :version "29.1")
>
> (defun find-sibling-file (file)
FWIW, the change looks good to me.
next prev parent reply other threads:[~2023-10-03 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 4:54 [PATCH v3] Improve find-sibling-rules option type Paul W. Rankin via Emacs development discussions.
2023-10-03 10:27 ` Mauro Aranda [this message]
2023-10-05 7:46 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0ca74c3-6e05-5c77-fefe-8341c7255eb7@gmail.com \
--to=maurooaranda@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=hello@paulwrankin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).