From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v3] Improve find-sibling-rules option type Date: Thu, 05 Oct 2023 10:46:39 +0300 Message-ID: <83fs2p4ilc.fsf@gnu.org> References: <20231002045524.59955-1-hello@paulwrankin.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40866"; mail-complaints-to="usenet@ciao.gmane.io" Cc: hello@paulwrankin.com, emacs-devel@gnu.org To: Mauro Aranda Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 05 09:47:32 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qoJ52-000AIK-1W for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Oct 2023 09:47:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoJ4A-0005JT-DA; Thu, 05 Oct 2023 03:46:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoJ45-0005IC-Lh for emacs-devel@gnu.org; Thu, 05 Oct 2023 03:46:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoJ45-0004Yf-9E; Thu, 05 Oct 2023 03:46:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qC/xkzg7ILLpSc0K5TjjTVh1n5bQpRy7/sGUcWVcfuI=; b=iVQ8s/rJv2rD YKW3GabBPcTCxnzIr2miU8M4vBHArkliyzVDeObt0uqdTINBNjSmKQQGf0miSkD2l17/9jh0bULdg SozLxNTixFCUYogPqHj0XP2QTLY715NFIIXL3nOyUumDrdnTO285Khn4/oijqi2rTppnUcgkBicgl Yey5eqyxiyXnaphLzidg/23rw30UqCPTd0xbPu6Z/a+YYXpc2CCUxRgcixlCvIR36ktAuh0mtwCyG EmWqPT0B0mBFvFe2jNRJV6U8drMFCl0eqHpSVej3iXCNPOsKO9FKiLwu0FhhIdDOoRjVeygVBJA7X 15X80Q/sxX8Q4ArsCSzriA==; In-Reply-To: (message from Mauro Aranda on Tue, 3 Oct 2023 07:27:38 -0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311293 Archived-At: > Date: Tue, 3 Oct 2023 07:27:38 -0300 > From: Mauro Aranda > > On 2/10/23 01:54, Paul W. Rankin via Emacs development discussions. wrote: > > * lisp/files.el (find-sibling-rules): use alist with tags for custom > > type > > --- > > v3, make alist value a repeating string type. > > > > > > lisp/files.el | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lisp/files.el b/lisp/files.el > > index 9d76668..eceed75 100644 > > --- a/lisp/files.el > > +++ b/lisp/files.el > > @@ -7572,7 +7572,8 @@ find-sibling-rules > > In this example, if you're in \"src/emacs/emacs-27/lisp/abbrev.el\", > > and a \"src/emacs/emacs-28/lisp/abbrev.el\" file exists, it's now > > defined as a sibling." > > - :type 'sexp > > + :type '(alist :key-type (regexp :tag "Match") > > + :value-type (repeat (string :tag "Expansion"))) > > :version "29.1") > > > > (defun find-sibling-file (file) > > FWIW, the change looks good to me. Thanks, installed on master.