Re: Mac OS Sierra tab feature breaks C-x 5 2

[Alan Third <alan@idiocy.org>]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

On Thu, Jul 06, 2017 at 06:42:04PM +0100, Alan Third wrote:
> We can make it a run time check, which would look something like
> 
>     if ([win respondsToSelector: @selector(setTabbingMode)])
>       [win setTabbingMode: NSWindowTabbingModeDisallowed];
> 
> but this will throw up compiler warnings on pre‐Sierra versions of
> macOS. I guess that’s maybe just the price to be paid.

I’ve attached a patch to master for this. Can someone on macOS 10.11
or below give it a try and confirm that it compiles and runs?
-- 
Alan Third

[-- Attachment #2: 0001-Use-a-run-time-check-for-macOS-Sierra-tabbing-suppor.patch --]
[-- Type: text/plain, Size: 1120 bytes --]

From c22264617bf4d50116c4e55525935241931c2cf1 Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Thu, 6 Jul 2017 23:10:49 +0100
Subject: [PATCH] Use a run-time check for macOS Sierra tabbing support

* src/nsterm.m (initFrameFromEmacs) [NS_IMPL_COCOA]: Switch from
compile-time check to run-time.
---
 src/nsterm.m | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/nsterm.m b/src/nsterm.m
index bf83550b3d..f88b279987 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -7073,9 +7073,9 @@ - (instancetype) initFrameFromEmacs: (struct frame *)f
   /* macOS Sierra automatically enables tabbed windows.  We can't
      allow this to be enabled until it's available on a Free system.
      Currently it only happens by accident and is buggy anyway. */
-#if defined (NS_IMPL_COCOA) && \
-  MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_12
-  [win setTabbingMode: NSWindowTabbingModeDisallowed];
+#ifdef NS_IMPL_COCOA
+  if ([win respondsToSelector: @selector(setTabbingMode:)])
+    [win setTabbingMode: NSWindowTabbingModeDisallowed];
 #endif
 
   ns_window_num++;
-- 
2.12.0