Re: Mac OS Sierra tab feature breaks C-x 5 2

[Anders Lindgren <andlind@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

Now it compiles, but with a warning:

----
nsterm.m:7078:10: warning: instance method '-setTabbingMode:' not found
(return type defaults to 'id') [-Wobjc-method-access]
    [win setTabbingMode: NSWindowTabbingModeDisallowed];
         ^~~~~~~~~~~~~~
/System/Library/Frameworks/AppKit.framework/Headers/NSWindow.h:167:12:
note: receiver is instance of class declared here
@interface NSWindow : NSResponder <NSAnimatablePropertyContainer,
NSUserInterfaceValidations, NSUserInterfaceItemIdentifica...
-----


I've seen other packages declare methods in NSWindows, but I don't know how
"correct" that is. For example:

https://github.com/electron/electron/blob/master/atom/browser/native_window_mac.mm#L450

    -- Anders

On Mon, Jul 10, 2017 at 9:52 PM, Alan Third <alan@idiocy.org> wrote:

> On Mon, Jul 10, 2017 at 09:17:58PM +0200, Anders Lindgren wrote:
> > Unfortunately, it doesn't compile. I get the following error when I build
> > on 10.10.5:
> >
> > nsterm.m:7078:26: error: use of undeclared identifier
> > 'NSWindowTabbingModeDisallowed'
> >     [win setTabbingMode: NSWindowTabbingModeDisallowed];
> >
> > Fortunately, the fix is simple. If we build on an older system, we can
> > define the NSWindowTabbingModeXxx constants ourselves.
>
> I think this should do it, then...
> --
> Alan Third
>

[-- Attachment #2: Type: text/html, Size: 2101 bytes --]