From: Alan Third <alan@idiocy.org>
To: Jean-Christophe Helary <jean.christophe.helary@gmail.com>
Cc: Paul Michael Reilly <pmr@pajato.com>,
Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: Mac OS Sierra tab feature breaks C-x 5 2
Date: Thu, 6 Jul 2017 18:42:04 +0100 [thread overview]
Message-ID: <20170706174204.GA19121@breton.holly.idiocy.org> (raw)
In-Reply-To: <191BFCA3-3C5B-4A75-8985-A958E638ADCE@gmail.com>
On Fri, Jul 07, 2017 at 12:05:32AM +0900, Jean-Christophe Helary wrote:
>
> > On Jul 6, 2017, at 23:35, Alan Third <athird@googlemail.com> wrote:
>
> > I've just realised that we're using a build time version check,
> > and the Emacs for macOS releases are built on an older version of
> > macOS... I'm not sure what the best solution here is...
>
> Is the result very different depending on the version of macOS?
> What's the version you are building on?
I build on Sierra.
We have this code
#if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_12
[win setTabbingMode: NSWindowTabbingModeDisallowed];
#endif
in initFrameFromEmacs in nsterm.m. The idea being that since this code
only works in 10.12 and up, we only include it when Emacs is compiled
on 10.12. This might be why you’re not seeing the broken behaviour.
I believe that the emacsformacosx builds are built on 10.9 or 10.10 or
something? I can’t remember exactly. That means this code is not
included.
We can make it a run time check, which would look something like
if ([win respondsToSelector: @selector(setTabbingMode)])
[win setTabbingMode: NSWindowTabbingModeDisallowed];
but this will throw up compiler warnings on pre‐Sierra versions of
macOS. I guess that’s maybe just the price to be paid.
--
Alan Third
next prev parent reply other threads:[~2017-07-06 17:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 11:29 Mac OS Sierra tab feature breaks C-x 5 2 Paul Michael Reilly
2017-07-06 12:14 ` Jean-Christophe Helary
2017-07-06 12:46 ` Sebastian Christ
2017-07-06 12:53 ` Alan Third
2017-07-06 14:35 ` Alan Third
2017-07-06 15:05 ` Jean-Christophe Helary
2017-07-06 17:42 ` Alan Third [this message]
2017-07-06 22:16 ` Alan Third
2017-07-10 19:17 ` Anders Lindgren
2017-07-10 19:52 ` Alan Third
2017-07-10 20:22 ` Anders Lindgren
2017-07-12 18:23 ` Alan Third
2017-07-12 21:20 ` Anders Lindgren
2017-07-13 20:22 ` Alan Third
2017-07-16 18:43 ` Anders Lindgren
2017-07-16 23:01 ` Alan Third
2017-07-17 20:09 ` Charles A. Roelli
2017-07-18 6:06 ` Anders Lindgren
2017-07-18 18:33 ` Charles A. Roelli
2017-07-18 22:16 ` Alan Third
2017-07-19 4:57 ` Charles A. Roelli
2017-07-21 20:31 ` Anders Lindgren
2017-07-22 11:22 ` Alan Third
2017-07-23 12:17 ` NS runtime feature detection (was: Mac OS Sierra tab feature breaks C-x 5 2) Alan Third
2017-07-24 19:02 ` NS runtime feature detection Charles A. Roelli
2017-07-24 20:45 ` Alan Third
2017-07-23 22:35 ` Mac OS Sierra tab feature breaks C-x 5 2 Tim Cross
-- strict thread matches above, loose matches on Subject: below --
2017-07-06 17:24 Matthew Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706174204.GA19121@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
--cc=jean.christophe.helary@gmail.com \
--cc=pmr@pajato.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).