From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Mac OS Sierra tab feature breaks C-x 5 2 Date: Thu, 6 Jul 2017 18:42:04 +0100 Message-ID: <20170706174204.GA19121@breton.holly.idiocy.org> References: <191BFCA3-3C5B-4A75-8985-A958E638ADCE@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1499362963 28554 195.159.176.226 (6 Jul 2017 17:42:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 6 Jul 2017 17:42:43 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: Paul Michael Reilly , Emacs-Devel devel To: Jean-Christophe Helary Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 06 19:42:38 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTAnV-00076J-Et for ged-emacs-devel@m.gmane.org; Thu, 06 Jul 2017 19:42:37 +0200 Original-Received: from localhost ([::1]:52655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTAna-0007RN-Rx for ged-emacs-devel@m.gmane.org; Thu, 06 Jul 2017 13:42:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTAn2-0007QQ-Sm for emacs-devel@gnu.org; Thu, 06 Jul 2017 13:42:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTAn2-0002xp-1G for emacs-devel@gnu.org; Thu, 06 Jul 2017 13:42:08 -0400 Original-Received: from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]:35468) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dTAn1-0002xI-Pz for emacs-devel@gnu.org; Thu, 06 Jul 2017 13:42:07 -0400 Original-Received: by mail-wr0-x22c.google.com with SMTP id k67so12471643wrc.2 for ; Thu, 06 Jul 2017 10:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=rbjQOUIDY2BuQ/BfMUySvN9xSdr3Kw0pQAla3WNOmNo=; b=HuWPM9XiCEDMiPEhUBShmqXdqMQgbmei98YEnZ77OOEtMVjpxvex569Bxhy/K+0RHp eGqNB/FMkUKpscUIYtm1kU+BOsxVhQRo31IocOcVO7jULXSHJYTk94zSvAKmTI/qyBMJ wB68zVI+qGIuf6M87SIlE8qin3rrvVi7qLR+vD6jYrhZDqMvKB6JNohx/U9sSdoVt3n4 j6Y4eum+LcB1zp0c4AzFJc12/Zypb3Lp3xUbrs3HzABy/9kwM/j/t5d7pj11HszYIQ74 RcVKSDUzcaQNPIgKKs9wXjsReELDI4h2aMCKmRV3UYxElASjJrYauHk8LSOWEmAmMUOf xMTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=rbjQOUIDY2BuQ/BfMUySvN9xSdr3Kw0pQAla3WNOmNo=; b=V8hmZ9WTY096M1hrPcwYFPGYwnJQ1qDxNedGOo5TPnWhlevQwL4WqAEmpl4WSzVU0Q XHIz6911UBLGFY2BSE8duV7iM7ibpnX1IhZdAbE4Oa4+w03ADDw7oZmJPw0CKP1FZ5PZ cIm8IlcYaa4Ut+K0/KeL1VeX3GMkg2zOB0GnjypZ/qo6gVM6CL/QZZkUgq1enb8gmltu 35eNZrWYTqSdNBdpJFYlQXofTvi1QT5jkBw34B1xGpLeUl1Vsv0GDMMN3HzoChrtUDb3 BnUDsStEdfwrNkj5gr9ODsjKWiwyZqF253l4ulPLVFQeqooY/mEYSopLJ7Bay/cYCD6K U1NA== X-Gm-Message-State: AIVw111geRZSpA6nJozzjbFoDe2k+YyfdHypJygBiWvs5CG7kIaa8ME5 jNg1BwgBpA3QOg== X-Received: by 10.28.91.141 with SMTP id p135mr271947wmb.19.1499362926576; Thu, 06 Jul 2017 10:42:06 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-e9a1-3503-5c3f-d7d9.holly.idiocy.org. [2001:8b0:3f8:8129:e9a1:3503:5c3f:d7d9]) by smtp.gmail.com with ESMTPSA id j31sm468702wre.67.2017.07.06.10.42.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jul 2017 10:42:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: <191BFCA3-3C5B-4A75-8985-A958E638ADCE@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216242 Archived-At: On Fri, Jul 07, 2017 at 12:05:32AM +0900, Jean-Christophe Helary wrote: > > > On Jul 6, 2017, at 23:35, Alan Third wrote: > > > I've just realised that we're using a build time version check, > > and the Emacs for macOS releases are built on an older version of > > macOS... I'm not sure what the best solution here is... > > Is the result very different depending on the version of macOS? > What's the version you are building on? I build on Sierra. We have this code #if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_12 [win setTabbingMode: NSWindowTabbingModeDisallowed]; #endif in initFrameFromEmacs in nsterm.m. The idea being that since this code only works in 10.12 and up, we only include it when Emacs is compiled on 10.12. This might be why you’re not seeing the broken behaviour. I believe that the emacsformacosx builds are built on 10.9 or 10.10 or something? I can’t remember exactly. That means this code is not included. We can make it a run time check, which would look something like if ([win respondsToSelector: @selector(setTabbingMode)]) [win setTabbingMode: NSWindowTabbingModeDisallowed]; but this will throw up compiler warnings on pre‐Sierra versions of macOS. I guess that’s maybe just the price to be paid. -- Alan Third