From: Giorgos Keramidas <gkeramidas@gmail.com>
To: Roland Winkler <winkler@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Recent read-face patch breaks `M-x customize-face'
Date: Fri, 5 Apr 2013 21:04:30 +0200 [thread overview]
Message-ID: <20130405190429.GA17775@saturn> (raw)
In-Reply-To: <20831.8015.295605.904153@gargle.gargle.HOWL>
On 2013-04-05 14:00, Roland Winkler <winkler@gnu.org> wrote:
> On Fri Apr 5 2013 Roland Winkler wrote:
> > So I guess the best fix is to replace "all faces" by nil.
>
> ...both for customize-face and customize-face-other-window.
Correct. This fixes `M-x customize-face' in trunk. Thanks!
===========================================================================
diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index d19e2de..b82c67b 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -1319,7 +1319,7 @@ If OTHER-WINDOW is non-nil, display in another window.
Interactively, when point is on text which has a face specified,
suggest to customize that face, if it's customizable."
- (interactive (list (read-face-name "Customize face" "all faces" t)))
+ (interactive (list (read-face-name "Customize face" nil t)))
(if (member face '(nil ""))
(setq face (face-list)))
(if (and (listp face) (null (cdr face)))
@@ -1350,7 +1350,7 @@ If FACE is actually a face-alias, customize the face it is aliased to.
Interactively, when point is on text which has a face specified,
suggest to customize that face, if it's customizable."
- (interactive (list (read-face-name "Customize face" "all faces" t)))
+ (interactive (list (read-face-name "Customize face" nil t)))
(customize-face face t))
(defalias 'customize-customized 'customize-unsaved)
===========================================================================
next prev parent reply other threads:[~2013-04-05 19:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 17:50 Recent read-face patch breaks `M-x customize-face' Giorgos Keramidas
2013-04-05 17:52 ` Giorgos Keramidas
2013-04-05 18:56 ` Roland Winkler
2013-04-05 19:00 ` Roland Winkler
2013-04-05 19:04 ` Giorgos Keramidas [this message]
2013-04-05 21:40 ` Stefan Monnier
2013-04-06 11:55 ` Roland Winkler
2013-04-06 14:02 ` Stefan Monnier
2013-04-06 15:50 ` Γιώργος Κεραμίδας
2013-04-06 21:22 ` Roland Winkler
2013-04-07 0:29 ` Stefan Monnier
2013-04-07 21:15 ` Roland Winkler
2013-04-13 1:15 ` Roland Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405190429.GA17775@saturn \
--to=gkeramidas@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).