From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Giorgos Keramidas Newsgroups: gmane.emacs.devel Subject: Re: Recent read-face patch breaks `M-x customize-face' Date: Fri, 5 Apr 2013 21:04:30 +0200 Message-ID: <20130405190429.GA17775@saturn> References: <20130405175032.GA29138@saturn> <20831.7759.573008.165973@gargle.gargle.HOWL> <20831.8015.295605.904153@gargle.gargle.HOWL> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: ger.gmane.org 1365278738 31001 80.91.229.3 (6 Apr 2013 20:05:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Apr 2013 20:05:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: Roland Winkler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 22:05:39 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UOZJJ-0001KY-CW for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2013 22:02:01 +0200 Original-Received: from localhost ([::1]:58091 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOBwQ-0003bT-7P for ged-emacs-devel@m.gmane.org; Fri, 05 Apr 2013 15:04:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOBwK-0003Zj-TO for emacs-devel@gnu.org; Fri, 05 Apr 2013 15:04:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOBwH-0001IS-Rr for emacs-devel@gnu.org; Fri, 05 Apr 2013 15:04:44 -0400 Original-Received: from mail-ee0-f42.google.com ([74.125.83.42]:59661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOBwC-0001HK-Sr; Fri, 05 Apr 2013 15:04:37 -0400 Original-Received: by mail-ee0-f42.google.com with SMTP id d4so735132eek.1 for ; Fri, 05 Apr 2013 12:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to; bh=zz/mVjF/7kFom+cgZb7CZGsPnkdtRXW/GJY2fc/VE0A=; b=0Ql1HqmhtBZjbROqCFSyP8ZV3BiIN0zQ2Wuz3P7alMrim3ldVwAFiSpgM5eLn8dFOV fOWyWUrTEVbMHrNR0BlB8Gxv4dOIIN7ASOHSQW4Oo4Hv1qWD4IfJwFTYzaRvQ1Um411O IYoWQkahoKppCx1AXwxf6r/enjgVI/kyn3PuYHcroqCJXwnXo8FEzH20V7yputrEChlE ObRt1IHWmROzeuFrFuFYeKxP299TBW3s+4KbaFZSVzUarscbVVDIxZ5Wew5e1jIyJXMD 685I72R3wdwJ98a6bqJY7UjAIgtazhfnYaSnt3KYHWXvOZTegRE3nWLotqiIMQK/FG7y eAQQ== X-Received: by 10.14.173.67 with SMTP id u43mr22213416eel.22.1365188675848; Fri, 05 Apr 2013 12:04:35 -0700 (PDT) Original-Received: from saturn (217-162-217-29.dynamic.hispeed.ch. [217.162.217.29]) by mx.google.com with ESMTPS id s47sm17058988eeg.8.2013.04.05.12.04.33 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 05 Apr 2013 12:04:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20831.8015.295605.904153@gargle.gargle.HOWL> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.83.42 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158732 Archived-At: On 2013-04-05 14:00, Roland Winkler wrote: > On Fri Apr 5 2013 Roland Winkler wrote: > > So I guess the best fix is to replace "all faces" by nil. > > ...both for customize-face and customize-face-other-window. Correct. This fixes `M-x customize-face' in trunk. Thanks! =========================================================================== diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el index d19e2de..b82c67b 100644 --- a/lisp/cus-edit.el +++ b/lisp/cus-edit.el @@ -1319,7 +1319,7 @@ If OTHER-WINDOW is non-nil, display in another window. Interactively, when point is on text which has a face specified, suggest to customize that face, if it's customizable." - (interactive (list (read-face-name "Customize face" "all faces" t))) + (interactive (list (read-face-name "Customize face" nil t))) (if (member face '(nil "")) (setq face (face-list))) (if (and (listp face) (null (cdr face))) @@ -1350,7 +1350,7 @@ If FACE is actually a face-alias, customize the face it is aliased to. Interactively, when point is on text which has a face specified, suggest to customize that face, if it's customizable." - (interactive (list (read-face-name "Customize face" "all faces" t))) + (interactive (list (read-face-name "Customize face" nil t))) (customize-face face t)) (defalias 'customize-customized 'customize-unsaved) ===========================================================================