From: "Roland Winkler" <winkler@gnu.org>
To: Giorgos Keramidas <gkeramidas@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Recent read-face patch breaks `M-x customize-face'
Date: Fri, 5 Apr 2013 13:56:15 -0500 [thread overview]
Message-ID: <20831.7759.573008.165973@gargle.gargle.HOWL> (raw)
In-Reply-To: <20130405175032.GA29138@saturn>
On Fri Apr 5 2013 Giorgos Keramidas wrote:
> Does customize-face depend on some bogus assumption that this
> commit has now rendered broken??
The patch of read-face-name made this function behave as promised by
its docstring. This says that the arg DEFAULT should be a list of
faces. (Previously, quite to the contrary, the actual code of
read-face-name assumed that DEFAULT should be a single string.)
When I installed the patch, I somehow overlooked that customize-face
calls read-face-name with DEFAULT having the value "all faces".
This is certainly not a very meaningful value to begin with.
So I guess the best fix is to replace "all faces" by nil.
Or am I once again overlooking something?
Roland
next prev parent reply other threads:[~2013-04-05 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 17:50 Recent read-face patch breaks `M-x customize-face' Giorgos Keramidas
2013-04-05 17:52 ` Giorgos Keramidas
2013-04-05 18:56 ` Roland Winkler [this message]
2013-04-05 19:00 ` Roland Winkler
2013-04-05 19:04 ` Giorgos Keramidas
2013-04-05 21:40 ` Stefan Monnier
2013-04-06 11:55 ` Roland Winkler
2013-04-06 14:02 ` Stefan Monnier
2013-04-06 15:50 ` Γιώργος Κεραμίδας
2013-04-06 21:22 ` Roland Winkler
2013-04-07 0:29 ` Stefan Monnier
2013-04-07 21:15 ` Roland Winkler
2013-04-13 1:15 ` Roland Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20831.7759.573008.165973@gargle.gargle.HOWL \
--to=winkler@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gkeramidas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).