unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Roland Winkler" <winkler@gnu.org>
Cc: Giorgos Keramidas <gkeramidas@gmail.com>, emacs-devel@gnu.org
Subject: Re: Recent read-face patch breaks `M-x customize-face'
Date: Sat, 06 Apr 2013 20:29:21 -0400	[thread overview]
Message-ID: <jwvppy72nh5.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20832.37370.297168.937525@gargle.gargle.HOWL> (Roland Winkler's message of "Sat, 6 Apr 2013 16:22:02 -0500")

> This behavior of read-face-name appears a bit of a kludge to me,

Agreed.

> Removing this magic from read-face-name would require in turn that
> commands such as make-face-bold call face-at-point for a reasonable
> value of DEFAULT. In my humble opinion, this appears to be the
> cleanest solution.

I think the for sake of backward compatibility, it is best to just
preserve the kludge.


        Stefan



  reply	other threads:[~2013-04-07  0:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-05 17:50 Recent read-face patch breaks `M-x customize-face' Giorgos Keramidas
2013-04-05 17:52 ` Giorgos Keramidas
2013-04-05 18:56 ` Roland Winkler
2013-04-05 19:00   ` Roland Winkler
2013-04-05 19:04     ` Giorgos Keramidas
2013-04-05 21:40   ` Stefan Monnier
2013-04-06 11:55     ` Roland Winkler
2013-04-06 14:02       ` Stefan Monnier
2013-04-06 15:50         ` Γιώργος Κεραμίδας
2013-04-06 21:22         ` Roland Winkler
2013-04-07  0:29           ` Stefan Monnier [this message]
2013-04-07 21:15             ` Roland Winkler
2013-04-13  1:15         ` Roland Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvppy72nh5.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=gkeramidas@gmail.com \
    --cc=winkler@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).